[Ref-Conformance] Adding a forwardRef to react-internal ContextualMenu #15625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6e92f0d:
|
Asset size changes
Baseline commit: b14a4ed22b4ea4cd45fa09a4a34f9ccfe71d32dd (build) |
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 2, 2020
microsoft#15625) * Adding a forwardRef to ContextualMenu * Adding a forwardRef to ContextualMenu * Updating ContextualMenu.base.tsx * Change files * Change files
2 tasks
behowell
added a commit
that referenced
this pull request
Jul 23, 2021
…nously (#19122) PR #15625 moved the `hostElement` ref from an inner `div` of ContextualMenu, to the root `Callout` element. If the Callout component is loaded asynchronously, this can cause a crash when the ref doesn't refer to a fully loaded element. This change un-merges the `forwardedRef` and `hostElement` ref. It still applies the forwarded ref to the root Callout (to maintain the fix from #15625), but puts the `hostElement` ref back to the inner `div`.
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
…nously (microsoft#19122) PR microsoft#15625 moved the `hostElement` ref from an inner `div` of ContextualMenu, to the root `Callout` element. If the Callout component is loaded asynchronously, this can cause a crash when the ref doesn't refer to a fully loaded element. This change un-merges the `forwardedRef` and `hostElement` ref. It still applies the forwarded ref to the root Callout (to maintain the fix from microsoft#15625), but puts the `hostElement` ref back to the inner `div`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
ContextualMenutargetComponentsupport to component-handles-refdefaultTestdisabledTestsfrom ContextualMenu.test.tsxFocus areas to test
ContextualMenu