Multi version docsite #15692
Merged
Multi version docsite #15692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ling1726
commented
Oct 26, 2020
| `/pr-deploy-site/${process.env.BUILD_SOURCEBRANCH}/react-northstar/` | ||
| : '/'; | ||
|
|
||
| if (process.env.OFFICIALRELEASE) { |
There was a problem hiding this comment.
I might not need process.env.OFFICIALRELEASE but I need to find out how/where process.env.PR_DEPLOY is set
There was a problem hiding this comment.
using this env variable would still give us an easy way to build docsites for single versions
ling1726
commented
Oct 26, 2020
| @@ -0,0 +1,116 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Any cleaner naming for this file ?
ling1726
requested review from
assuncaocharles,
dzearing,
ecraig12345,
jurokapsiar,
layershifter,
miroslavstastny,
pompomon and
xugao
as code owners
packages/fluentui/docs/src/components/Sidebar/VersionDropdown.tsx
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1267d8d:
|
| displayName: 'Publish docsite as pipeline artifact' | ||
| inputs: | ||
| PathtoPublish: 'packages/fluentui/docs/dist' | ||
| ArtifactName: 'docsite_v$(docsiteVersion)' |
There was a problem hiding this comment.
no, I think but it's handy to have the artifacts available... storage is cheap and we can backfill easily if we ever move storage or have to clean it for some reason
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: eb0f2c4b76a921fa9a8b069189ecdacff7029117 (build) |
| @@ -486,6 +487,7 @@ const Sidebar: React.FC<RouteComponentProps & SidebarProps> = props => { | |||
| > | |||
| Fluent <span style={gradientTextStyles}>UI</span> | |||
| </Text> | |||
| <VersionDropdown width={props.width} /> | |||
There was a problem hiding this comment.
Suggested change
| <VersionDropdown width={props.width} /> | |
| {process.env.NODE_ENV === 'production' && <VersionDropdown width={props.width} />} |
So we hide this during local builds?
There was a problem hiding this comment.
This is should already be covered in the component itself, although you reminded me that I have no catch for the fetch.... is that enough for you or should we be more explicit to not render this locally at all ? It might be necessary to locally host a manifest to display this dropdown if you're working on it (like I have)
miroslavstastny
approved these changes
Oct 29, 2020
miroslavstastny
approved these changes
Oct 30, 2020
ecraig12345
approved these changes
Oct 30, 2020
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 23, 2020
* Dropdown and shell for multi version docsite * Add deployment artifacts and config * PR fixes * revert yarn build * Add existing semver version in repo to docs * Fix basepath * added changelog entry * fix changelog entry * fixed parentheses in changelog * add dependency for versiondropdown * Use compare-versions to validate semver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Adds multi version support to the current N* docsite
Focus areas to test
(optional)