-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[isConformant] Implementing component-handles-classname test #15707
[isConformant] Implementing component-handles-classname test #15707
Conversation
…eat/isConformant-classname-tests
packages/react-internal/src/components/ColorPicker/__snapshots__/ColorPicker.test.tsx.snap
Outdated
Show resolved
Hide resolved
Thanks, @ecraig12345 can you please merge once you've signed off? |
packages/react-focus/src/components/FocusZone/__snapshots__/FocusZone.test.tsx.snap
Outdated
Show resolved
Hide resolved
packages/react-internal/src/components/CommandBar/__snapshots__/CommandBar.test.tsx.snap
Outdated
Show resolved
Hide resolved
packages/react-internal/src/components/MessageBar/__snapshots__/MessageBar.test.tsx.snap
Outdated
Show resolved
Hide resolved
...nternal/src/components/TextField/MaskedTextField/__snapshots__/MaskedTextField.test.tsx.snap
Outdated
Show resolved
Hide resolved
…eat/isConformant-classname-tests
'component-handles-classname': (componentInfo: ComponentDoc, testInfo: IsConformantOptions) => { | ||
const { Component, wrapperComponent, helperComponents = [], requiredProps, customMount = mount } = testInfo; | ||
|
||
const defaultEl = customMount(<Component {...requiredProps} />); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this but each test (it()
) should be standalone, and mounting components should happen inside the test itself.
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
Pull request checklist
$ yarn change
Description of changes
Summary
component-handles-classname
test to isConformant's defaultTests.component-handles-classname
What this test does:
defaultErrorMessages
If the component doesn't correctly handle the classname prop.
If the default classname isn't correctly handled.
List of removed
react-northstar
tests:( Basic Tests ) replaced with
name-matches-filename
,exports-component
: * Component exports * Component has a constructor name( ClassName Tests ) replaced with
component-handles-classname
:List of removed
ComponentConformance
tests:( Component File Conformance ) replaced with
component-handles-classname
:( Top Level Component File Conformance ) replaced with
exported-top-level
,has-top-level-file
:Disabled V8 Components
Breadcrumb
: Doesn't apply the test className to the root.Callout
: Doesn't apply the test className to the root.TeachingBubble
: Doesn't apply the test className to the root.ContextualMenu
: Requires createPortal.Rating
: Doesn't apply the defaultClassName to the root.Callout
: Doesn't apply the test className to the root.BaseSelectedItemsList
: Doesn't apply the test className to the root.SelectedPeopleList
: Doesn't apply the test className to the root.ButtonGrid
: Doesn't apply the test className to the root.Modal
: Requires createPortal.PersonaPresence
: Doesn't apply the test className to the root.Coachmark
: Doesn't apply the test className to the root.Dialog
: Refers to modalProps.className.Nav
: Doesn't apply the test className to the root.Panel
: Doesn't apply the test className to the root.Sticky
: Doesn't apply the test className to the root.SelectionZone
: Doesn't apply the test className to the root.CalendarDayGrid
: Doesn't apply the test className to the root.