Use v8 react-button hooks in v0 button #15777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurokapsiar
reviewed
Nov 3, 2020
| @@ -32,5 +32,8 @@ export const useButtonState = (draftState: ButtonState) => { | |||
| } | |||
| } | |||
|
|
|||
| draftState.disabled = draftState['aria-disabled'] = draftState.disabled || draftState.loading; | |||
| // TODO: v0 buttons are not disabled while loading, removed `disabled = loading` logic here | |||
There was a problem hiding this comment.
not disabling buttons while loading was intentional - while the UI is loading, it is useful to have the button still focused, because quite often, there is no other suitable place to move focus to.
levithomason
commented
Nov 3, 2020
|
|
||
| export const renderImage = (state: ImageState) => { | ||
| const { slots, slotProps } = getSlots(state); | ||
|
|
||
| return <slots.root {...slotProps.root} />; | ||
| }; | ||
|
|
||
| const mergeProps = makeMergeProps<ImageState>(); |
There was a problem hiding this comment.
TODO: Add tests to show why we cannot rely on a static list of props to deeply merge.
|
@levithomason Guessing this can be closed now that we're taking a totally different approach? |
|
Closing since we're no longer considering this approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating v8 hooks in v0. Please wait for review.
TODO