Jspurlin/combo box focus fix 7.0 #15784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before calling the passed in onItemClick callback or calling setSelectedItem
msft-github-bot
added
the
needs cherry-pick
jspurlin
commented
Oct 30, 2020
|
|
||
| // Continue processing the click only after | ||
| // performing menu close / control focus(inner working) | ||
| onItemClick && onItemClick(ev, item, index); |
There was a problem hiding this comment.
The only things changed as part of this PR is moving lines 1593 and 1594 to here (lines 1609 and 1610)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f3a0214:
|
Perf AnalysisNo significant results to display. All results
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9c0596c67f5fad10823f6b626926f0444873bc8c (build) |
joschect
approved these changes
Oct 30, 2020
|
🎉 Handy links: |
ecraig12345
removed
the
needs cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Previous to this change there was a case when a controlled comboBox could move focus as part of either
onItemClickoronChangeprop callbacks, but then the comboBox would refocus the input afterwards leading to unexpected focus behavior.This PR allows the comboBox to handle its internal focus handling and potential menu closing prior to calling the
onItemClickandonChangecallbacks. This allows the comboBox to deal with its inner focus handling before communicating outwardly fixing the potential unexpected stealing of focus back to the inputFocus areas to test
Verified that the comboBox functionality didn't change and the comboBox no longer steals focus back if it was moved as part of
onItemClickoronChange