Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin button: ensure default fonts are set #15801

Merged
merged 2 commits into from Oct 31, 2020
Merged

Conversation

LeslieW
Copy link
Contributor

@LeslieW LeslieW commented Oct 31, 2020

Pull request checklist

Description of changes

Currently, the SpinButton font family is not inherited from Fabric and defaults to 'Times'.

This change adds fonts.medium to the SpinButton component styles so that font family results in the Fabric default. This change mimics the use of font styling across other button types.

Before:
spin_button_before

After:
spin_button_after

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 31, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b94cc54:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 960 957 5000
Breadcrumb mount 43089 42650 5000
Checkbox mount 1679 1677 5000
CheckboxBase mount 1375 1398 5000
ChoiceGroup mount 5240 5263 5000
ComboBox mount 948 1006 1000
CommandBar mount 7962 7850 1000
ContextualMenu mount 14002 13687 1000
DefaultButton mount 1176 1180 5000
DetailsRow mount 3774 3739 5000
DetailsRowFast mount 3655 3744 5000
DetailsRowNoStyles mount 3615 3431 5000
Dialog mount 1570 1539 1000
DocumentCardTitle mount 1833 1828 1000
Dropdown mount 2649 2682 5000
FocusTrapZone mount 1783 1703 5000
FocusZone mount 1800 1787 5000
IconButton mount 1814 1861 5000
Label mount 337 348 5000
Layer mount 2057 2033 5000
Link mount 441 464 5000
MenuButton mount 1578 1600 5000
MessageBar mount 2153 2120 5000
Nav mount 3434 3529 1000
OverflowSet mount 1467 1432 5000
Panel mount 1478 1527 1000
Persona mount 874 863 1000
Pivot mount 1492 1469 1000
PrimaryButton mount 1394 1355 5000
Rating mount 8047 8119 5000
SearchBox mount 1329 1347 5000
Shimmer mount 2781 2704 5000
Slider mount 1543 1571 5000
SpinButton mount 5220 5372 5000
Spinner mount 401 404 5000
SplitButton mount 3322 3312 5000
Stack mount 544 526 5000
StackWithIntrinsicChildren mount 1614 1659 5000
StackWithTextChildren mount 5012 4975 5000
SwatchColorPicker mount 10698 10671 5000
TagPicker mount 2832 2960 5000
TeachingBubble mount 50885 51110 5000
Text mount 463 454 5000
TextField mount 1492 1448 5000
Toggle mount 900 867 5000
button mount 97 109 5000

@size-auditor
Copy link

size-auditor bot commented Oct 31, 2020

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-SpinButton 186.391 kB 186.375 kB BelowBaseline     -16 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 1867e11134aef221cf9376b5f29562637c199bf6 (build)

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 21 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@xugao xugao merged commit ba7160c into microsoft:7.0 Oct 31, 2020
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.149.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-examples@v0.8.7 has been released which incorporates this pull request.:tada:

Handy links:

@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants