Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (web components): start end fixed width height #16359

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "update start and end to remove fixed width and height",
"packageName": "@fluentui/web-components",
"email": "sethdonohue@Admins-MBP.guest.corp.microsoft.com",
"dependentChangeType": "patch",
"date": "2021-01-04T19:34:11.159Z"
}
3 changes: 2 additions & 1 deletion packages/web-components/src/menu-item/menu-item.styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const MenuItemStyles = css`
outline: none;
box-sizing: border-box;
height: calc(${heightNumber} * 1px);
grid-template-columns: 42px auto 42px;
grid-template-columns: minmax(42px, auto) 1fr minmax(42px, auto);
grid-template-rows: auto;
justify-items: center;
align-items: center;
Expand Down Expand Up @@ -72,6 +72,7 @@ export const MenuItemStyles = css`
replace when adaptive typography is figured out */ ''
} width: 16px;
height: 16px;
display: flex;
}

:host(:hover) .start,
Expand Down
6 changes: 5 additions & 1 deletion packages/web-components/src/styles/patterns/button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@ export const BaseButtonStyles: ElementStyles = css`
}

.start,
.end,
.end {
display: flex;
}

::slotted(svg) {
${
/* Glyph size and margin-left is temporary -
Expand Down Expand Up @@ -260,6 +263,7 @@ export const HypertextStyles = css`
font-size: inherit;
line-height: inherit;
background: transparent;
min-width: 0;
}

:host(.hypertext) .control {
Expand Down
12 changes: 7 additions & 5 deletions packages/web-components/src/text-field/text-field.styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,15 @@ export const TextFieldStyles = css`

.start,
.end {
${
/* Glyph size and margin-left is temporary -
margin: auto;
fill: currentcolor;
}

::slotted(svg) { ${
/* Glyph size and margin-left is temporary -
replace when adaptive typography is figured out */ ''
} width: 16px;
} width: 16px;
height: 16px;
margin: auto;
fill: ${neutralForegroundRestBehavior.var};
}

.start {
Expand Down
6 changes: 5 additions & 1 deletion packages/web-components/src/tree-item/tree-item.styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,14 @@ export const TreeItemStyles = css`
}
.start,
.end {
display: flex;
fill: currentcolor;
}

::slotted(svg) {
${/* Glyph size is temporary -
replace when glyph-size var is added */ ''} width: 16px;
height: 16px;
fill: ${neutralForegroundRestBehavior.var};
}

.start {
Expand Down