Updating to webpack 5 #16447
Updating to webpack 5 #16447
Conversation
dzearing
requested review from
assuncaocharles,
behowell,
bigbadcapers,
chrisdholt,
ecraig12345,
evlevy,
Jahnp,
JasonGore,
joschect,
jurokapsiar,
khmakoto,
layershifter,
ling1726,
lorejoh12,
miroslavstastny,
pompomon,
Raghurk and
xugao
as code owners
Asset size changes
Baseline commit: 540e928dec12666f9d13d30d1ab9000b77b33a14 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f9cb3c:
|
change/@fluentui-web-components-2021-01-12-10-32-22-chore-update-webpack5.json
Outdated
Show resolved
Hide resolved
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
#### Pull request checklist - [x] Addresses an existing issue: Fixes #17208, fixes #17213 #### Description of changes The webpack 5 change #16447 broke bundles in production builds because the webpack CLI arg for turning on production mode has changed from `--production` to `--mode=production`. This was causing a build error, but it didn't cause the release build to fail because `scripts/runPublished.js` wasn't appropriately handling the exit code. This PR fixes both issues, and switches the publish build/bundle to run using lage rather than lerna for consistency.
#### Pull request checklist - [x] Addresses an existing issue: Fixes microsoft#17208, fixes microsoft#17213 #### Description of changes The webpack 5 change microsoft#16447 broke bundles in production builds because the webpack CLI arg for turning on production mode has changed from `--production` to `--mode=production`. This was causing a build error, but it didn't cause the release build to fail because `scripts/runPublished.js` wasn't appropriately handling the exit code. This PR fixes both issues, and switches the publish build/bundle to run using lage rather than lerna for consistency.
This changelist updates all webpack references to 5, and updates all loaders and plugins to latest bits.