adding lines in vertical stacked bar chart complex combo chart (#15551) #16639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8c73eb3:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesUnable to find bundle size details for Baseline commit: cc0450e Possible causes
Recommendations
|
|
I suspect you're missing snapshot updates. You'll need to merge with master (which has an update-snapshots fix) then: yarn
yarn buildto react-examples
yarn workspace @fluentui/react-charting update-snapshots
# maybe, not sure if this affects example snapshots
yarn workspace @fluentui/react-examples update-snapshots |
ecraig12345
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Once the snapshots are fixed you can have an admin merge this (I think @layershifter should be able to do that if you don't want to wait for US time)
…soft#15551) * adding lines in the vertical stacked bar chart * Change files * fix build errors * fix build erros * when only the line is highlighted we should show callout to that * fix build issues * making the callout sort according to the rects * updating snapshots Co-authored-by: v-sivsar <v-sivsar@microsoft.com>
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding lines in the vertical stacked bar chart
Change files
fix build errors
fix build erros
when only the line is highlighted we should show callout to that
fix build issues
making the callout sort according to the rects
updating snapshots
Co-authored-by: v-sivsar v-sivsar@microsoft.com