Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic MenuList with items #16865

Merged
merged 45 commits into from
Feb 8, 2021
Merged

Basic MenuList with items #16865

merged 45 commits into from
Feb 8, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Feb 8, 2021

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Adds a basic MenuList implementation with MenuItems cherry-picked from the larger PR: #16805

Focus areas to test

(optional)

ling1726 and others added 16 commits February 5, 2021 16:59
@ling1726
Auto-generate react-menu
d48612b
@ling1726
use correct react-menu version
abd8efa
@ling1726 @layershifter
Update packages/react-menu/package.json
fc46c5b 
Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@ling1726
update files
101354c
@ling1726
Merge branch 'feat/converged-menu-implem' of https://github.com/ling1…
65c03bf 
…726/fluentui into feat/converged-menu-implem
@ling1726
remove unnecessary
3670150
@ling1726
modified codeowners
7d59397
@ling1726
update codeowners
ce9bc5e
@ling1726
modify codeowners
b2b8da7
@ling1726
Change files
8cf1b35
@ling1726
Merge branch 'feat/converged-menu-implem' of https://github.com/ling1…
95156a9 
…726/fluentui into feat/converged-menu-implem
@ecraig12345
Merge branch 'master' into feat/converged-menu-implem
6cf5fca
@ling1726
Merge remote-tracking branch 'origin' into feat/converged-menu-implem
df206a4
@ling1726
add react-hooks dep
5b80fc5
@ling1726
Merge branch 'feat/converged-menu-implem' of https://github.com/ling1…
728ddf0 
…726/fluentui into feat/converged-menu-implem
@ling1726
revert unnecessary files
8d23df5
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 8, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c0fd3a5:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 8, 2021 •
edited

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: e6a1c49

Possible causes

  • The baseline build e6a1c49 is broken
  • The Size Auditor run for the baseline build e6a1c49 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 8, 2021 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 841 845 5000
BaseButtonCompat mount 929 942 5000
Breadcrumb mount 40887 41082 5000
Checkbox mount 1616 1609 5000
CheckboxBase mount 1421 1305 5000
ChoiceGroup mount 4802 4873 5000
ComboBox mount 959 961 1000
CommandBar mount 9835 9928 1000
ContextualMenu mount 5930 5925 1000
DefaultButtonCompat mount 1183 1145 5000
DetailsRow mount 3587 3599 5000
DetailsRowFast mount 3729 3630 5000
DetailsRowNoStyles mount 3517 3585 5000
Dialog mount 1510 1461 1000
DocumentCardTitle mount 1729 1738 1000
Dropdown mount 3361 3376 5000
FocusTrapZone mount 1782 1768 5000
FocusZone mount 1771 1772 5000
IconButtonCompat mount 1795 1826 5000
Label mount 330 324 5000
Layer mount 1784 1872 5000
Link mount 453 481 5000
MakeStyles mount 1959 1953 50000
MenuButtonCompat mount 1486 1507 5000
MessageBar mount 1941 1953 5000
Nav mount 3249 3330 1000
OverflowSet mount 1022 988 5000
Panel mount 1447 1433 1000
Persona mount 869 827 1000
Pivot mount 1407 1395 1000
PrimaryButtonCompat mount 1289 1286 5000
Rating mount 7635 7880 5000
SearchBox mount 1359 1361 5000
Shimmer mount 2626 2588 5000
Slider mount 1893 1901 5000
SpinButton mount 4989 5053 5000
Spinner mount 396 410 5000
SplitButtonCompat mount 3263 3277 5000
Stack mount 502 514 5000
StackWithIntrinsicChildren mount 1561 1554 5000
StackWithTextChildren mount 4633 4659 5000
SwatchColorPicker mount 10235 10394 5000
Tabs mount 1406 1411 1000
TagPicker mount 2786 2795 5000
TeachingBubble mount 11446 11438 5000
Text mount 437 438 5000
TextField mount 1461 1402 5000
ThemeProvider mount 1377 1378 5000
ThemeProvider virtual-rerender 574 586 5000
ThemeProviderNext mount 2095 2116 5000
Toggle mount 815 821 5000
button mount 681 689 5000
buttonNative mount 109 104 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.19 0.52 0.37:1 2000 386
🦄 Button.Fluent 0.13 0.2 0.65:1 5000 639
🔧 Checkbox.Fluent 0.66 0.35 1.89:1 1000 659
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 839
🔧 Dropdown.Fluent 3.07 0.41 7.49:1 1000 3066
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 723
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 458
🔧 Slider.Fluent 1.57 0.43 3.65:1 1000 1571
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 397
🦄 Tooltip.Fluent 0.12 0.87 0.14:1 5000 591

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 236 206 1.15:1
AnimationMinimalPerf.default 478 426 1.12:1
LayoutMinimalPerf.default 471 429 1.1:1
ListNestedPerf.default 664 606 1.1:1
PortalMinimalPerf.default 173 160 1.08:1
Image.Fluent 458 423 1.08:1
AttachmentMinimalPerf.default 196 183 1.07:1
LabelMinimalPerf.default 476 445 1.07:1
IconMinimalPerf.default 757 707 1.07:1
HeaderSlotsPerf.default 895 842 1.06:1
StatusMinimalPerf.default 824 775 1.06:1
ToolbarMinimalPerf.default 1063 1004 1.06:1
DialogMinimalPerf.default 859 815 1.05:1
DropdownManyItemsPerf.default 794 758 1.05:1
ListWith60ListItems.default 698 667 1.05:1
BoxMinimalPerf.default 407 391 1.04:1
ButtonMinimalPerf.default 193 186 1.04:1
ChatMinimalPerf.default 679 656 1.04:1
RefMinimalPerf.default 248 239 1.04:1
SegmentMinimalPerf.default 418 402 1.04:1
SliderMinimalPerf.default 1622 1562 1.04:1
TableManyItemsPerf.default 2264 2185 1.04:1
TableMinimalPerf.default 453 434 1.04:1
Checkbox.Fluent 659 631 1.04:1
Tooltip.Fluent 591 569 1.04:1
ButtonUseCssNestingPerf.default 1138 1105 1.03:1
FlexMinimalPerf.default 330 321 1.03:1
LoaderMinimalPerf.default 764 745 1.03:1
MenuButtonMinimalPerf.default 1690 1645 1.03:1
RadioGroupMinimalPerf.default 491 476 1.03:1
TextAreaMinimalPerf.default 562 543 1.03:1
CardMinimalPerf.default 639 626 1.02:1
CarouselMinimalPerf.default 534 522 1.02:1
ChatWithPopoverPerf.default 465 457 1.02:1
DropdownMinimalPerf.default 3108 3052 1.02:1
ItemLayoutMinimalPerf.default 1337 1309 1.02:1
MenuMinimalPerf.default 971 952 1.02:1
ProviderMinimalPerf.default 972 951 1.02:1
TextMinimalPerf.default 398 390 1.02:1
Dialog.Fluent 839 823 1.02:1
Text.Fluent 397 389 1.02:1
SplitButtonMinimalPerf.default 3955 3897 1.01:1
TreeMinimalPerf.default 832 827 1.01:1
VideoMinimalPerf.default 704 695 1.01:1
Dropdown.Fluent 3066 3038 1.01:1
Icon.Fluent 723 716 1.01:1
ButtonOverridesMissPerf.default 1741 1740 1:1
ButtonSlotsPerf.default 627 629 1:1
DatepickerMinimalPerf.default 47736 47684 1:1
SkeletonMinimalPerf.default 417 418 1:1
CustomToolbarPrototype.default 3700 3684 1:1
Avatar.Fluent 386 387 1:1
AttachmentSlotsPerf.default 1218 1226 0.99:1
ButtonUseCssPerf.default 869 876 0.99:1
CheckboxMinimalPerf.default 2877 2913 0.99:1
ImageMinimalPerf.default 422 426 0.99:1
PopupMinimalPerf.default 711 715 0.99:1
ProviderMergeThemesPerf.default 1542 1555 0.99:1
Button.Fluent 639 645 0.99:1
DividerMinimalPerf.default 428 435 0.98:1
EmbedMinimalPerf.default 4318 4389 0.98:1
GridMinimalPerf.default 370 376 0.98:1
HeaderMinimalPerf.default 421 428 0.98:1
ListMinimalPerf.default 550 561 0.98:1
RosterPerf.default 1269 1298 0.98:1
TooltipMinimalPerf.default 824 842 0.98:1
Slider.Fluent 1571 1608 0.98:1
ListCommonPerf.default 700 725 0.97:1
TreeWith60ListItems.default 191 197 0.97:1
AlertMinimalPerf.default 315 327 0.96:1
ChatDuplicateMessagesPerf.default 371 387 0.96:1
InputMinimalPerf.default 1314 1363 0.96:1
ReactionMinimalPerf.default 432 448 0.96:1
FormMinimalPerf.default 467 490 0.95:1
AccordionMinimalPerf.default 168 191 0.88:1

@ling1726 ling1726 closed this Feb 8, 2021
@ling1726 ling1726 reopened this Feb 8, 2021
@ling1726 ling1726 closed this Feb 8, 2021
@ling1726 ling1726 reopened this Feb 8, 2021
@ling1726 ling1726 closed this Feb 8, 2021
@ling1726 ling1726 reopened this Feb 8, 2021
@ling1726 ling1726 closed this Feb 8, 2021
@ling1726 ling1726 reopened this Feb 8, 2021
@ling1726 ling1726 closed this Feb 8, 2021
@ling1726 ling1726 reopened this Feb 8, 2021
@ling1726 ling1726 merged commit fe4959d into microsoft:master Feb 8, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-theme-provider@v1.0.0-beta.21 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-text@v0.1.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-image@v0.6.21 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-provider@v0.1.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-make-styles@v0.2.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-utils@v0.3.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-avatar@v0.9.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-menu@v0.2.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-button@v1.0.0-beta.29 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite@v1.0.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-cards@v1.0.0-beta.50 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite-resources@v1.0.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-examples@v1.1.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@dzearing dzearing Awaiting requested review from dzearing

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

@xugao xugao Awaiting requested review from xugao

Assignees

@joschect joschect

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ling1726 @fabricteam @msft-fluent-ui-bot @layershifter @joschect @ecraig12345