feat: new withFluentProvider decorator for converged Provider #16869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Feb 8, 2021
| @@ -2,5 +2,5 @@ import { merge } from '@fluentui/utilities'; | |||
| import { PartialTheme, Theme } from '../types'; | |||
|
|
|||
| export function mergeThemes(a: Theme, b: PartialTheme | Theme): Theme { | |||
| return merge(a, b) as Theme; | |||
| return merge({}, a, b) as Theme; | |||
There was a problem hiding this comment.
A small bugfix, merge() mutates the first object 😨
There was a problem hiding this comment.
can this be covered in unit tests?
There was a problem hiding this comment.
Oops, overlooked your comment, yes it can be
ling1726
reviewed
Feb 8, 2021
| return <FluentProvider theme={theme}>{props.children}</FluentProvider>; | ||
| }; | ||
|
|
||
| export const withFluentProvider = makeDecorator({ |
There was a problem hiding this comment.
will you add this to react-examples in a separate PR ?
There was a problem hiding this comment.
It's done per package, for react-avatar it's done in #16793.
There was a problem hiding this comment.
I see the author has to explicitly enable this decorator
layershifter
requested review from
dzearing,
ecraig12345 and
xugao
as code owners
ling1726
reviewed
Feb 8, 2021
ling1726
approved these changes
Feb 8, 2021
miroslavstastny
approved these changes
Feb 8, 2021
layershifter
commented
Feb 8, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a66ee06:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b6e11cbb2ee4037c927927560e0e78b1e1f8e377 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds a new
withFluentProvider()to be used with converged components anduseTheme()to switch themes.