Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v7.0] ChoiceGroup: Focus border is now visible when focus method is called #16897

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Feb 9, 2021

Pull request checklist

Description of changes

  • Sets focus visibility to true when the focus method is invoked
  • Example:

focus-border-shows-after-focus-method-is-invoked

master PR: #16797

@msft-fluent-ui-bot msft-fluent-ui-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 9, 2021
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 9, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ebf6762:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 917 884 5000
Breadcrumb mount 42533 42884 5000
Checkbox mount 1583 1556 5000
CheckboxBase mount 1249 1255 5000
ChoiceGroup mount 4955 4823 5000
ComboBox mount 918 889 1000
CommandBar mount 7750 7669 1000
ContextualMenu mount 14435 14526 1000
DefaultButton mount 1115 1120 5000
DetailsRow mount 3607 3584 5000
DetailsRowFast mount 3521 3676 5000
DetailsRowNoStyles mount 3344 3455 5000
Dialog mount 1485 1460 1000
DocumentCardTitle mount 1789 1819 1000
Dropdown mount 2527 2524 5000
FocusTrapZone mount 1720 1747 5000
FocusZone mount 1833 1784 5000
IconButton mount 1750 1741 5000
Label mount 317 322 5000
Layer mount 1928 1960 5000
Link mount 439 422 5000
MenuButton mount 1467 1447 5000
MessageBar mount 2094 2005 5000
Nav mount 3221 3250 1000
OverflowSet mount 1384 1470 5000
Panel mount 1454 1473 1000
Persona mount 819 823 1000
Pivot mount 1387 1417 1000
PrimaryButton mount 1278 1271 5000
Rating mount 7534 7573 5000
SearchBox mount 1261 1271 5000
Shimmer mount 2501 2530 5000
Slider mount 1447 1465 5000
SpinButton mount 4996 4972 5000
Spinner mount 441 413 5000
SplitButton mount 3105 3167 5000
Stack mount 494 495 5000
StackWithIntrinsicChildren mount 1516 1507 5000
StackWithTextChildren mount 4618 4627 5000
SwatchColorPicker mount 10188 10169 5000
TagPicker mount 2818 2770 5000
TeachingBubble mount 51234 51227 5000
Text mount 432 436 5000
TextField mount 1398 1381 5000
Toggle mount 823 828 5000
button mount 108 108 5000

@size-auditor
Copy link

size-auditor bot commented Feb 9, 2021

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-ChoiceGroup 60.757 kB 60.967 kB ExceedsBaseline     210 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: d5941bc737c3b59a7a8058a63a78687b4bb9ece8 (build)

@TristanWatanabe TristanWatanabe merged commit 169645b into microsoft:7.0 Feb 9, 2021
@TristanWatanabe TristanWatanabe deleted the 14191 branch February 9, 2021 19:36
@msft-fluent-ui-bot
Copy link
Collaborator

🎉office-ui-fabric-react@v7.159.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants