Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v7.0] PersonaCoin: now accepts initialsTextColor prop which sets the text color of the Persona Coin #16908

Merged
merged 3 commits into from
Feb 10, 2021

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Feb 10, 2021

Pull request checklist

Description of changes

cherry-picking master PR: #16873

  • PersonaCoin component now takes prop initialsTextColor which sets the text color.
  • Persona component now passes initialsTextColor prop to PersonaCoin.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c23fd0:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 960 944 5000
Breadcrumb mount 43460 40786 5000
Checkbox mount 1736 1735 5000
CheckboxBase mount 1438 1433 5000
ChoiceGroup mount 5348 5375 5000
ComboBox mount 945 951 1000
CommandBar mount 7920 7974 1000
ContextualMenu mount 14028 13879 1000
DefaultButton mount 1276 1265 5000
DetailsRow mount 3787 3924 5000
DetailsRowFast mount 3851 3881 5000
DetailsRowNoStyles mount 3553 3572 5000
Dialog mount 1535 1525 1000
DocumentCardTitle mount 1801 1811 1000
Dropdown mount 2704 2681 5000
FocusTrapZone mount 1760 1701 5000
FocusZone mount 1847 1850 5000
IconButton mount 1882 1858 5000
Label mount 329 328 5000
Layer mount 2023 2085 5000
Link mount 449 457 5000
MenuButton mount 1567 1551 5000
MessageBar mount 2072 2175 5000
Nav mount 3494 3456 1000
OverflowSet mount 1539 1587 5000
Panel mount 1550 1537 1000
Persona mount 901 919 1000
Pivot mount 1514 1484 1000
PrimaryButton mount 1358 1400 5000
Rating mount 8427 8655 5000
SearchBox mount 1388 1389 5000
Shimmer mount 2651 2777 5000
Slider mount 1621 1635 5000
SpinButton mount 5182 5280 5000
Spinner mount 416 421 5000
SplitButton mount 3272 3246 5000
Stack mount 511 504 5000
StackWithIntrinsicChildren mount 1533 1597 5000
StackWithTextChildren mount 4858 4986 5000
SwatchColorPicker mount 10346 10474 5000
TagPicker mount 2909 2854 5000
TeachingBubble mount 49290 49937 5000
Text mount 448 466 5000
TextField mount 1455 1448 5000
Toggle mount 843 839 5000
button mount 102 107 5000

@size-auditor
Copy link

size-auditor bot commented Feb 10, 2021

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-FloatingPicker 234.373 kB 234.445 kB ExceedsBaseline     72 bytes
office-ui-fabric-react office-ui-fabric-react-SelectedItemsList 223.449 kB 223.521 kB ExceedsBaseline     72 bytes
office-ui-fabric-react office-ui-fabric-react-Pickers 277.4 kB 277.472 kB ExceedsBaseline     72 bytes
office-ui-fabric-react office-ui-fabric-react-Facepile 204.26 kB 204.332 kB ExceedsBaseline     72 bytes
office-ui-fabric-react office-ui-fabric-react-PersonaCoin 111.951 kB 112.023 kB ExceedsBaseline     72 bytes
office-ui-fabric-react office-ui-fabric-react-Persona 111.951 kB 112.023 kB ExceedsBaseline     72 bytes
office-ui-fabric-react office-ui-fabric-react-ActivityItem 67.452 kB 67.482 kB ExceedsBaseline     30 bytes
office-ui-fabric-react office-ui-fabric-react-DocumentCard 209.494 kB 209.524 kB ExceedsBaseline     30 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 15dfd17559f39669f95062b2a5ee2e0d69c2f13d (build)

@xugao xugao removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 10, 2021
@mtennoe mtennoe merged commit 1f39dd8 into microsoft:7.0 Feb 10, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉office-ui-fabric-react@v7.159.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants