fix: add force-colors to backgroundStyles and update button styles to fix the card and button components #17231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c7183e3:
|
khamudom
force-pushed
the
users/khamu/high-contrast-design-system
branch
from
d6695a2
to
143ad63
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 72508b4cde86bc47b0f07b6986cbb2e01601eed8 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
chrisdholt
reviewed
Mar 2, 2021
khamudom
force-pushed
the
users/khamu/high-contrast-design-system
branch
from
40b25a9
to
49280c3
Compare
scomea
approved these changes
Mar 3, 2021
|
smoked, looks as advertised. |
khamudom
force-pushed
the
users/khamu/high-contrast-design-system
branch
from
49280c3
to
c189110
Compare
chrisdholt
approved these changes
Mar 9, 2021
khamudom
force-pushed
the
users/khamu/high-contrast-design-system
branch
from
c189110
to
c7183e3
Compare
nicholasrice
approved these changes
Mar 9, 2021
EisenbergEffect
approved these changes
Mar 13, 2021
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
… fix the card and button components (microsoft#17231) * add force-colors backgroundStyles and set a few HC colors on button styles * Change files * adjust forece colors import order * update to use attribute instead of class. fixed href color issues
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
… fix the card and button components (microsoft#17231) * add force-colors backgroundStyles and set a few HC colors on button styles * Change files * adjust forece colors import order * update to use attribute instead of class. fixed href color issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Added forced-colors to the
backgroundStylestylesheet, in the design system provider. In addition, updated to add selectors to fix high contrast colors in Stealth, Outline, Default, and Neutral buttons when the colors are being inherited from the fluent-card background.Focus areas to test
Screenshots show the before and after buttons in HC dark and light.
before
after
