Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autofill: Fix autofill in controlled cases where the cursor has moved #17475

Merged
merged 5 commits into from
Mar 29, 2021
Merged

Autofill: Fix autofill in controlled cases where the cursor has moved #17475

merged 5 commits into from
Mar 29, 2021

Conversation

joschect
Copy link
Contributor

@joschect joschect commented Mar 17, 2021 •
edited by khmakoto

Pull request checklist

Description of changes

There are still several issues that were uncovered during this process. They are logged in #17474

Focus areas to test

(optional)

@joschect joschect requested review from JustSlone, jdhuntington, khmakoto and jspurlin and removed request for JustSlone March 17, 2021 23:17
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 17, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2389f46:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@khmakoto
Copy link
Member

It seems like you need to update the API file.

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2021 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 933 937 5000
BaseButton mount 900 922 5000
Breadcrumb mount 41160 40036 5000
ButtonNext mount 1333 1309 5000
Checkbox mount 1725 1671 5000
CheckboxBase mount 1440 1413 5000
ChoiceGroup mount 4926 5115 5000
ComboBox mount 957 967 1000
CommandBar mount 9690 9724 1000
ContextualMenu mount 5918 5871 1000
DefaultButton mount 1113 1156 5000
DetailsRow mount 3622 3631 5000
DetailsRowFast mount 3652 3615 5000
DetailsRowNoStyles mount 3373 3472 5000
Dialog mount 1426 1438 1000
DocumentCardTitle mount 1717 1727 1000
Dropdown mount 3362 3338 5000
FocusTrapZone mount 1786 1789 5000
FocusZone mount 1749 1760 5000
IconButton mount 1771 1814 5000
Label mount 346 337 5000
Layer mount 1775 1759 5000
Link mount 470 476 5000
MakeStyles mount 1895 1889 50000
MenuButton mount 1510 1484 5000
MessageBar mount 1938 1950 5000
Nav mount 3261 3249 1000
OverflowSet mount 1018 1020 5000
Panel mount 1389 1383 1000
Persona mount 816 822 1000
Pivot mount 1406 1378 1000
PrimaryButton mount 1317 1275 5000
Rating mount 7820 7908 5000
SearchBox mount 1382 1375 5000
Shimmer mount 2645 2613 5000
Slider mount 1952 1971 5000
SpinButton mount 5035 4943 5000
Spinner mount 417 407 5000
SplitButton mount 3188 3172 5000
Stack mount 503 501 5000
StackWithIntrinsicChildren mount 1516 1545 5000
StackWithTextChildren mount 4632 4656 5000
SwatchColorPicker mount 10110 10266 5000
Tabs mount 1373 1381 1000
TagPicker mount 2792 2808 5000
TeachingBubble mount 11353 11366 5000
Text mount 423 414 5000
TextField mount 1367 1396 5000
ThemeProvider mount 1152 1135 5000
ThemeProvider virtual-rerender 567 566 5000
ThemeProviderNext mount 15107 15090 5000
Toggle mount 816 800 5000
buttonNative mount 104 98 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.18 0.47 0.38:1 2000 359
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 619
🔧 Checkbox.Fluent 0.65 0.36 1.81:1 1000 651
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 819
🔧 Dropdown.Fluent 3.02 0.41 7.37:1 1000 3018
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 733
🎯 Image.Fluent 0.09 0.12 0.75:1 5000 448
🔧 Slider.Fluent 1.51 0.46 3.28:1 1000 1513
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 392
🦄 Tooltip.Fluent 0.14 0.88 0.16:1 5000 716

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ItemLayoutMinimalPerf.default 1368 1270 1.08:1
GridMinimalPerf.default 407 382 1.07:1
Image.Fluent 448 419 1.07:1
ChatDuplicateMessagesPerf.default 308 290 1.06:1
ChatWithPopoverPerf.default 410 387 1.06:1
DividerMinimalPerf.default 434 411 1.06:1
FormMinimalPerf.default 478 449 1.06:1
AttachmentSlotsPerf.default 1272 1209 1.05:1
BoxMinimalPerf.default 417 397 1.05:1
ButtonMinimalPerf.default 198 189 1.05:1
LayoutMinimalPerf.default 455 435 1.05:1
ListCommonPerf.default 716 683 1.05:1
ListMinimalPerf.default 576 551 1.05:1
SkeletonMinimalPerf.default 413 395 1.05:1
TextMinimalPerf.default 402 384 1.05:1
VideoMinimalPerf.default 696 666 1.05:1
Tooltip.Fluent 716 685 1.05:1
HeaderMinimalPerf.default 423 408 1.04:1
HeaderSlotsPerf.default 881 848 1.04:1
TreeWith60ListItems.default 199 191 1.04:1
RefMinimalPerf.default 241 234 1.03:1
Dialog.Fluent 819 795 1.03:1
AlertMinimalPerf.default 330 324 1.02:1
AttachmentMinimalPerf.default 181 177 1.02:1
ButtonUseCssNestingPerf.default 1083 1064 1.02:1
FlexMinimalPerf.default 326 321 1.02:1
LoaderMinimalPerf.default 740 722 1.02:1
MenuMinimalPerf.default 965 944 1.02:1
PopupMinimalPerf.default 719 705 1.02:1
PortalMinimalPerf.default 170 167 1.02:1
RadioGroupMinimalPerf.default 484 476 1.02:1
SegmentMinimalPerf.default 417 408 1.02:1
StatusMinimalPerf.default 803 790 1.02:1
TextAreaMinimalPerf.default 547 536 1.02:1
ToolbarMinimalPerf.default 1043 1023 1.02:1
TooltipMinimalPerf.default 1002 979 1.02:1
Text.Fluent 392 384 1.02:1
ButtonSlotsPerf.default 609 603 1.01:1
ButtonUseCssPerf.default 857 852 1.01:1
DialogMinimalPerf.default 835 824 1.01:1
DropdownManyItemsPerf.default 793 782 1.01:1
EmbedMinimalPerf.default 4266 4243 1.01:1
ListNestedPerf.default 622 613 1.01:1
MenuButtonMinimalPerf.default 1650 1638 1.01:1
Avatar.Fluent 359 357 1.01:1
Checkbox.Fluent 651 642 1.01:1
AvatarMinimalPerf.default 207 207 1:1
ButtonOverridesMissPerf.default 1732 1725 1:1
CardMinimalPerf.default 612 609 1:1
ChatMinimalPerf.default 652 655 1:1
CheckboxMinimalPerf.default 2811 2814 1:1
DatepickerMinimalPerf.default 46309 46353 1:1
LabelMinimalPerf.default 458 458 1:1
ProviderMergeThemesPerf.default 1521 1522 1:1
ProviderMinimalPerf.default 926 930 1:1
SliderMinimalPerf.default 1503 1507 1:1
SplitButtonMinimalPerf.default 3842 3839 1:1
TableManyItemsPerf.default 2208 2199 1:1
CustomToolbarPrototype.default 3661 3678 1:1
TreeMinimalPerf.default 831 832 1:1
Dropdown.Fluent 3018 3007 1:1
Icon.Fluent 733 731 1:1
AccordionMinimalPerf.default 177 179 0.99:1
DropdownMinimalPerf.default 3004 3034 0.99:1
InputMinimalPerf.default 1282 1294 0.99:1
ListWith60ListItems.default 667 675 0.99:1
ReactionMinimalPerf.default 440 444 0.99:1
IconMinimalPerf.default 727 735 0.99:1
TableMinimalPerf.default 439 443 0.99:1
CarouselMinimalPerf.default 493 502 0.98:1
RosterPerf.default 1188 1210 0.98:1
Button.Fluent 619 629 0.98:1
Slider.Fluent 1513 1544 0.98:1
AnimationMinimalPerf.default 438 452 0.97:1
ImageMinimalPerf.default 408 433 0.94:1

@size-auditor
Copy link

size-auditor bot commented Mar 18, 2021 •
edited

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-Pickers 267.591 kB 267.977 kB ExceedsBaseline     386 bytes
office-ui-fabric-react fluentui-react-Autofill 14.972 kB 15.358 kB ExceedsBaseline     386 bytes
office-ui-fabric-react fluentui-react-ComboBox 228.085 kB 228.471 kB ExceedsBaseline     386 bytes
office-ui-fabric-react fluentui-react-ExtendedPicker 87.432 kB 87.818 kB ExceedsBaseline     386 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 565ac2c89b9b302457643e1d4c4f1a28660d46b9 (build)

@andrefcdias
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@JustSlone
Copy link
Collaborator

Re-running checks

@JustSlone JustSlone closed this Mar 24, 2021
@JustSlone JustSlone reopened this Mar 24, 2021
@joschect joschect merged commit d781a4c into microsoft:master Mar 29, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react@v8.7.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot msft-fluent-ui-bot mentioned this pull request Mar 30, 2021
Closed
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request May 5, 2021
@joschect @miroslavstastny
Autofill: Fix autofill in controlled cases where the cursor has moved (…
17070a6 
…microsoft#17475)

* Fix autofill in the case of controlled combobox

* Change files

* fix lint

* fix typing

* update api
@TristanWatanabe TristanWatanabe mentioned this pull request May 13, 2021
Merged
2 tasks
@ecraig12345 ecraig12345 mentioned this pull request Jun 15, 2021
Closed
litong2 added a commit to litong2/fluentui that referenced this pull request Jul 15, 2021
@litong2
Revert "Autofill: Fix autofill in controlled cases where the cursor h…
401e897 
…as moved (microsoft#17475)"

This reverts commit d781a4c.
@litong2 litong2 mentioned this pull request Jul 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhuntington jdhuntington jdhuntington approved these changes

@khmakoto khmakoto khmakoto approved these changes

@jspurlin jspurlin Awaiting requested review from jspurlin

Assignees

@khmakoto khmakoto

Labels
Component: Autofill Component: ComboBox PR: API Modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cursor jumps to the end when typing in freeform ComboBox
7 participants
@joschect @khmakoto @fabricteam @andrefcdias @JustSlone @msft-fluent-ui-bot @jdhuntington