fix(ToolbarMenuItem): missing aria-haspopup when it has submenu #17646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanboXue-Amber
requested review from
assuncaocharles,
jurokapsiar,
layershifter,
ling1726,
miroslavstastny and
pompomon
as code owners
ling1726
reviewed
Mar 31, 2021
| /** Indicated if menu item has submenu. TODO: fix types for all behaviours */ | ||
| menu?: any; | ||
| /** Indicated if menu item has submenu */ | ||
| hasMenu?: boolean; |
There was a problem hiding this comment.
would it make more sense just to intersect `Pick<MenuItemBehaviourProps, 'hasMenu'> ?
There was a problem hiding this comment.
This is a great suggestion, after checking MenuItemBehavior, I changed toolbarMenuItemBehaviorProp to:
export type ToolbarMenuItemBehaviorProps = Omit<MenuItemBehaviorProps, 'vertical'>;
msft-fluent-ui-bot
added
the
Fluent UI react-northstar (v0)
Asset size changes
Baseline commit: 9c4f38b05c23051bdb7e8eb453b72faf3401d9cc (build) |
jurokapsiar
approved these changes
Mar 31, 2021
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0f09074:
|
ling1726
approved these changes
Mar 31, 2021
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…osoft#17646) * fix(ToolbarMenuItem): missing aria-haspopup when it has submenu * changelog * improve typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Before:
Notice item 'Play' has submenu, but its DOM does not have
aria-haspopupAfter:
Focus areas to test
(optional)