Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More shared website setup utility fixes #17672

Merged
merged 1 commit into from Apr 1, 2021
Merged

More shared website setup utility fixes #17672

merged 1 commit into from Apr 1, 2021

Conversation

ecraig12345
Copy link
Member

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Follow-up of #17568 and #17660... Fix two more issues for v5:

  • Pass webpack in to getLoadSiteConfig to ensure the correct version is used (v5 has multiple versions of webpack installed)
  • Fix Node 8-incompatible syntax (apparently optional catch bindings are an ES2019 feature) and use eslint-plugin-es to prevent similar issues from being introduced in the future

I also updated pr-deploy-site to use eslint-plugin-es instead of eslint-plugin-es5 since -es handles the same thing in a more generalized way.

@ecraig12345 ecraig12345 requested a review from Hotell as a code owner April 1, 2021 18:55
@ecraig12345 ecraig12345 added this to In progress in Version 8 via automation Apr 1, 2021
@size-auditor
Copy link

size-auditor bot commented Apr 1, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: dbf0329fd4986aaca1b03e154dab6aa642316958 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e7516e8:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 998 1026 5000
BaseButton mount 1005 1003 5000
Breadcrumb mount 45015 44928 5000
ButtonNext mount 608 596 5000
Checkbox mount 1646 1655 5000
CheckboxBase mount 1419 1390 5000
ChoiceGroup mount 5168 5040 5000
ComboBox mount 1033 1031 1000
CommandBar mount 10502 10420 1000
ContextualMenu mount 6426 6563 1000
DefaultButton mount 1187 1226 5000
DetailsRow mount 3918 3849 5000
DetailsRowFast mount 3893 3807 5000
DetailsRowNoStyles mount 3669 3665 5000
Dialog mount 1523 1510 1000
DocumentCardTitle mount 1839 1838 1000
Dropdown mount 3524 3494 5000
FocusTrapZone mount 1865 1852 5000
FocusZone mount 1890 1817 5000
IconButton mount 1874 1847 5000
Label mount 357 350 5000
Layer mount 1883 1890 5000
Link mount 491 504 5000
MakeStyles mount 1816 1840 50000
MenuButton mount 1587 1563 5000
MessageBar mount 2067 2095 5000
Nav mount 3589 3591 1000
OverflowSet mount 1102 1086 5000
Panel mount 1515 1531 1000
Persona mount 903 892 1000
Pivot mount 1501 1541 1000
PrimaryButton mount 1399 1408 5000
Rating mount 8445 8360 5000
SearchBox mount 1441 1428 5000
Shimmer mount 2766 2958 5000
Slider mount 2123 2144 5000
SpinButton mount 5431 5341 5000
Spinner mount 439 433 5000
SplitButton mount 3391 3409 5000
Stack mount 547 539 5000
StackWithIntrinsicChildren mount 1683 1714 5000
StackWithTextChildren mount 5052 5049 5000
SwatchColorPicker mount 11089 10869 5000
Tabs mount 1456 1487 1000
TagPicker mount 3047 2976 5000
TeachingBubble mount 12384 12271 5000
Text mount 469 468 5000
TextField mount 1485 1502 5000
ThemeProvider mount 1253 1258 5000
ThemeProvider virtual-rerender 637 625 5000
ThemeProviderNext mount 16233 15836 5000
Toggle mount 892 907 5000
buttonNative mount 126 126 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.19 0.51 0.37:1 2000 386
🦄 Button.Fluent 0.13 0.22 0.59:1 5000 640
🔧 Checkbox.Fluent 0.66 0.37 1.78:1 1000 656
🎯 Dialog.Fluent 0.17 0.24 0.71:1 5000 827
🔧 Dropdown.Fluent 3.2 0.45 7.11:1 1000 3200
🔧 Icon.Fluent 0.14 0.07 2:1 5000 702
🦄 Image.Fluent 0.09 0.14 0.64:1 5000 435
🔧 Slider.Fluent 1.68 0.49 3.43:1 1000 1681
🔧 Text.Fluent 0.08 0.04 2:1 5000 403
🦄 Tooltip.Fluent 0.15 0.94 0.16:1 5000 770

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 193 176 1.1:1
BoxMinimalPerf.default 436 403 1.08:1
AvatarMinimalPerf.default 250 234 1.07:1
LayoutMinimalPerf.default 445 414 1.07:1
TableMinimalPerf.default 480 450 1.07:1
TextMinimalPerf.default 419 392 1.07:1
AttachmentSlotsPerf.default 1316 1240 1.06:1
TreeWith60ListItems.default 211 199 1.06:1
AttachmentMinimalPerf.default 198 189 1.05:1
ChatDuplicateMessagesPerf.default 328 312 1.05:1
FlexMinimalPerf.default 337 322 1.05:1
FormMinimalPerf.default 502 479 1.05:1
RefMinimalPerf.default 271 257 1.05:1
VideoMinimalPerf.default 742 707 1.05:1
ChatWithPopoverPerf.default 432 416 1.04:1
SkeletonMinimalPerf.default 424 407 1.04:1
Button.Fluent 640 613 1.04:1
ButtonUseCssNestingPerf.default 1164 1129 1.03:1
CardMinimalPerf.default 638 619 1.03:1
GridMinimalPerf.default 402 389 1.03:1
LabelMinimalPerf.default 446 435 1.03:1
LoaderMinimalPerf.default 766 742 1.03:1
IconMinimalPerf.default 707 686 1.03:1
Avatar.Fluent 386 375 1.03:1
Text.Fluent 403 390 1.03:1
AnimationMinimalPerf.default 457 449 1.02:1
ButtonSlotsPerf.default 625 613 1.02:1
DropdownManyItemsPerf.default 795 776 1.02:1
HeaderSlotsPerf.default 879 863 1.02:1
ListNestedPerf.default 641 631 1.02:1
ListWith60ListItems.default 738 722 1.02:1
PortalMinimalPerf.default 177 174 1.02:1
RadioGroupMinimalPerf.default 506 498 1.02:1
TableManyItemsPerf.default 2198 2161 1.02:1
TreeMinimalPerf.default 889 868 1.02:1
Icon.Fluent 702 687 1.02:1
ButtonUseCssPerf.default 905 894 1.01:1
CarouselMinimalPerf.default 527 521 1.01:1
EmbedMinimalPerf.default 4433 4397 1.01:1
ListCommonPerf.default 713 709 1.01:1
ListMinimalPerf.default 572 566 1.01:1
MenuButtonMinimalPerf.default 1728 1718 1.01:1
PopupMinimalPerf.default 780 771 1.01:1
ReactionMinimalPerf.default 434 431 1.01:1
CustomToolbarPrototype.default 4094 4058 1.01:1
ToolbarMinimalPerf.default 1044 1037 1.01:1
Image.Fluent 435 430 1.01:1
ButtonOverridesMissPerf.default 1815 1813 1:1
CheckboxMinimalPerf.default 2931 2925 1:1
DatepickerMinimalPerf.default 49796 49595 1:1
DialogMinimalPerf.default 796 794 1:1
DividerMinimalPerf.default 425 424 1:1
HeaderMinimalPerf.default 419 420 1:1
ImageMinimalPerf.default 446 445 1:1
InputMinimalPerf.default 1358 1353 1:1
ItemLayoutMinimalPerf.default 1400 1404 1:1
MenuMinimalPerf.default 984 984 1:1
ProviderMinimalPerf.default 1111 1108 1:1
SplitButtonMinimalPerf.default 4106 4105 1:1
TooltipMinimalPerf.default 1058 1062 1:1
Dropdown.Fluent 3200 3188 1:1
ChatMinimalPerf.default 686 692 0.99:1
DropdownMinimalPerf.default 3211 3239 0.99:1
SegmentMinimalPerf.default 399 405 0.99:1
SliderMinimalPerf.default 1662 1681 0.99:1
Slider.Fluent 1681 1692 0.99:1
Tooltip.Fluent 770 776 0.99:1
ButtonMinimalPerf.default 201 206 0.98:1
RosterPerf.default 1309 1339 0.98:1
ProviderMergeThemesPerf.default 1694 1725 0.98:1
StatusMinimalPerf.default 763 776 0.98:1
TextAreaMinimalPerf.default 585 598 0.98:1
Dialog.Fluent 827 842 0.98:1
Checkbox.Fluent 656 673 0.97:1
AlertMinimalPerf.default 319 333 0.96:1

@ecraig12345 ecraig12345 merged commit d9d671d into microsoft:master Apr 1, 2021
Version 8 automation moved this from In progress to Done Apr 1, 2021
@ecraig12345 ecraig12345 deleted the load-site-fix-2 branch April 1, 2021 19:37
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-docsite-components@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite-setup@v0.2.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite-resources@v8.0.26 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-examples@v8.13.0 has been released which incorporates this pull request.:tada:

Handy links:

@ecraig12345 ecraig12345 mentioned this pull request Apr 1, 2021
Merged
1 task
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request May 5, 2021
@ecraig12345 @miroslavstastny
Remove es2019 syntax from website setup script, and pass in webpack i…
4b22cd0 
…nstance (microsoft#17672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@Hotell Hotell Awaiting requested review from Hotell

@jdhuntington jdhuntington Awaiting requested review from jdhuntington

Assignees
No one assigned
Labels
Area: Build System Area: Website
Projects
No open projects
Version 8
  
Done or removed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ecraig12345 @fabricteam @msft-fluent-ui-bot @khmakoto