Improve menu controlling with onOpenChange
#17712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `onOpenChange` callback to the `Menu` which is called when the internals of the menu component request a change to the open state of the menu. When the menu is not controlled (i.e. no `open`) prop, this callback can be used to watch the changes of the menu internal state. When the menu is controlled, allows the consumer to benefit from the popup edge cases that are used internally.
ling1726
changed the title
onOpenChange
layershifter
reviewed
Apr 6, 2021
layershifter
reviewed
Apr 6, 2021
layershifter
reviewed
Apr 6, 2021
layershifter
approved these changes
Apr 6, 2021
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a265b97604609b3f3b1f972aad63ab58859e6e3b (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit be151dd:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
* Improve menu controlling Adds `onOpenChange` callback to the `Menu` which is called when the internals of the menu component request a change to the open state of the menu. When the menu is not controlled (i.e. no `open`) prop, this callback can be used to watch the changes of the menu internal state. When the menu is controlled, allows the consumer to benefit from the popup edge cases that are used internally. * remove console * useEventCallback * remove console * improve types * Change files * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Adds
onOpenChangecallback to theMenuwhich is called when the internals of the menu component request a change to the open state of the menu.When the menu is not controlled (i.e. no
open) prop, this callback can be used to watch the changes of the menu internal state.When the menu is controlled, allows the consumer to benefit from the popup edge cases that are used internally.