Fix website bundling and manifest generation issues #17771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4e5a243010c67069e4aeef715863cf3abc9dc319 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8d3dddd:
|
khmakoto
approved these changes
Apr 10, 2021
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
ecraig12345
force-pushed
the
manifests-again
branch
from
5102be5
to
57b980a
Compare
ecraig12345
changed the title
ecraig12345
force-pushed
the
manifests-again
branch
from
57b980a
to
8d3dddd
Compare
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
This was referenced Apr 13, 2021
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues which only became obvious in the release build or on the real site, and add one minor optimization.
Previous PR accidentally broke the case where a base CDN URL is not provided to
create-site-manifestsand it should use the default instead.In #17568 I removed both the webpack config
output.publicPathsetting and the__webpack_public_path__runtime setting, because both appeared to be unused. Turns outoutput.publicPathwas actually unused (it appears to be a relic from when the whole site was hosted on the sharepoint CDN), but setting__webpack_public_path__is necessary to make loading chunks on the live site work since the chunk files are hosted on a different domain. So now that's back with a nice explanatory comment.The minor optimization is removing the
whatwg-fetchpolyfill from the site, since I realized it's redundant withreact-app-polyfill/ie11which we include automatically.(part of #14691)