Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legends missing accessible name issue resolved by adding aria-label - cherryPick #17978 #17980

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

jameelakowsar
Copy link
Contributor

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Cherry-pick of #https://github.com/microsoft/fluentui/pull/17978/files

Original Description

Description of changes

Added aria-label to the legends, to resolve accessibility issue in Legends.

Focus areas to test

Legends

Before fix

image

After fix

image

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 37b0afc:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 28, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ac2f319d76db747f0d0b1d76cbf4d63ae8864794 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 984 980 5000
Breadcrumb mount 41918 42274 5000
Checkbox mount 1643 1670 5000
CheckboxBase mount 1426 1405 5000
ChoiceGroup mount 5277 5349 5000
ComboBox mount 926 953 1000
CommandBar mount 8000 7925 1000
ContextualMenu mount 14675 14587 1000
DefaultButton mount 1248 1281 5000
DetailsRow mount 3891 4108 5000
DetailsRowFast mount 3900 3929 5000
DetailsRowNoStyles mount 3888 3838 5000
Dialog mount 1828 1799 1000
DocumentCardTitle mount 1904 1875 1000
Dropdown mount 2717 2705 5000
FocusTrapZone mount 1796 1791 5000
FocusZone mount 1898 1899 5000
IconButton mount 1904 1889 5000
Label mount 356 333 5000
Layer mount 2143 2077 5000
Link mount 462 468 5000
MenuButton mount 1601 1637 5000
MessageBar mount 2127 2120 5000
Nav mount 3451 3418 1000
OverflowSet mount 1484 1506 5000
Panel mount 1554 1554 1000
Persona mount 822 838 1000
Pivot mount 1489 1511 1000
PrimaryButton mount 1334 1345 5000
Rating mount 8339 8289 5000
SearchBox mount 1424 1397 5000
Shimmer mount 2705 2735 5000
Slider mount 1581 1555 5000
SpinButton mount 5227 5273 5000
Spinner mount 441 425 5000
SplitButton mount 3325 3443 5000
Stack mount 533 544 5000
StackWithIntrinsicChildren mount 1653 1741 5000
StackWithTextChildren mount 5121 5124 5000
SwatchColorPicker mount 10849 10845 5000
TagPicker mount 3007 2976 5000
TeachingBubble mount 51872 52245 5000
Text mount 453 475 5000
TextField mount 1469 1478 5000
Toggle mount 861 896 5000
button mount 98 114 5000

@jameelakowsar jameelakowsar marked this pull request as ready for review April 29, 2021 01:44
@jameelakowsar jameelakowsar changed the title Legends missing accessible name issue resolved by adding aria-label Legends missing accessible name issue resolved by adding aria-label - cherryPick #17978 Apr 29, 2021
@Raghurk Raghurk merged commit 1549778 into microsoft:7.0 Apr 29, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/charting@v4.15.23 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-examples@v0.13.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants