Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail cypress #18007

Merged
merged 7 commits into from
May 3, 2021
Merged

Fail cypress #18007

merged 7 commits into from
May 3, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Apr 30, 2021 •
edited

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Turns out the Cypress module API does not throw an exception test failure and that has to be handled by the consumer. This PR will at least fail CI if any E2E tests fail.

Might have to rethink this integration a bit and rely on just 馃槶

Focus areas to test

(optional)

@size-auditor
Copy link

size-auditor bot commented Apr 30, 2021 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5e6aa4df0c03051e59d686d24b35f01c721a3b4e (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 30, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 47ddf3e:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 30, 2021 •
edited

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 982 995 5000
BaseButton mount 1021 990 5000
Breadcrumb mount 2709 2736 1000
ButtonNext mount 592 588 5000
Checkbox mount 1704 1710 5000
CheckboxBase mount 1409 1459 5000
ChoiceGroup mount 5135 5201 5000
ComboBox mount 1048 1045 1000
CommandBar mount 10329 10435 1000
ContextualMenu mount 6574 6461 1000
DefaultButton mount 1212 1211 5000
DetailsRow mount 3953 3925 5000
DetailsRowFast mount 4049 4014 5000
DetailsRowNoStyles mount 3753 3733 5000
Dialog mount 1547 1609 1000
DocumentCardTitle mount 164 152 1000
Dropdown mount 3518 3457 5000
FocusTrapZone mount 1882 1875 5000
FocusZone mount 1815 1853 5000
IconButton mount 1863 1858 5000
Label mount 357 349 5000
Layer mount 1951 1890 5000
Link mount 496 477 5000
MakeStyles mount 1828 1803 50000
MenuButton mount 1585 1564 5000
MessageBar mount 2116 2059 5000
Nav mount 3473 3426 1000
OverflowSet mount 1046 1048 5000
Panel mount 1493 1473 1000
Persona mount 860 899 1000
Pivot mount 1467 1507 1000
PrimaryButton mount 1366 1335 5000
Rating mount 8285 8338 5000
SearchBox mount 1411 1434 5000
Shimmer mount 2695 2716 5000
Slider mount 2076 2097 5000
SpinButton mount 5286 5238 5000
Spinner mount 420 429 5000
SplitButton mount 3386 3580 5000
Stack mount 546 539 5000
StackWithIntrinsicChildren mount 1674 1657 5000
StackWithTextChildren mount 4902 4994 5000
SwatchColorPicker mount 10831 10815 5000
Tabs mount 1454 1509 1000
TagPicker mount 2590 2638 5000
TeachingBubble mount 12133 12118 5000
Text mount 449 455 5000
TextField mount 1468 1475 5000
ThemeProvider mount 1242 1224 5000
ThemeProvider virtual-rerender 603 616 5000
ThemeProviderNext mount 8671 8673 5000
Toggle mount 859 875 5000
buttonNative mount 120 102 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
VideoMinimalPerf.default 692 619 1.12:1
GridMinimalPerf.default 425 383 1.11:1
RefMinimalPerf.default 264 238 1.11:1
FlexMinimalPerf.default 328 299 1.1:1
ButtonMinimalPerf.default 206 191 1.08:1
LoaderMinimalPerf.default 783 728 1.08:1
TreeWith60ListItems.default 193 178 1.08:1
PortalMinimalPerf.default 176 164 1.07:1
ReactionMinimalPerf.default 443 415 1.07:1
CarouselMinimalPerf.default 509 482 1.06:1
DividerMinimalPerf.default 413 388 1.06:1
ListMinimalPerf.default 563 531 1.06:1
IconMinimalPerf.default 699 660 1.06:1
ButtonUseCssPerf.default 882 838 1.05:1
FormMinimalPerf.default 494 469 1.05:1
TooltipMinimalPerf.default 1065 1019 1.05:1
AvatarMinimalPerf.default 219 210 1.04:1
ItemLayoutMinimalPerf.default 1466 1403 1.04:1
ListNestedPerf.default 625 603 1.04:1
ListWith60ListItems.default 714 689 1.04:1
TextMinimalPerf.default 388 373 1.04:1
TextAreaMinimalPerf.default 543 523 1.04:1
CardMinimalPerf.default 606 588 1.03:1
ChatMinimalPerf.default 669 650 1.03:1
HeaderMinimalPerf.default 405 393 1.03:1
MenuButtonMinimalPerf.default 1766 1717 1.03:1
PopupMinimalPerf.default 780 754 1.03:1
AnimationMinimalPerf.default 452 442 1.02:1
AttachmentSlotsPerf.default 1248 1229 1.02:1
DialogMinimalPerf.default 789 773 1.02:1
DropdownManyItemsPerf.default 740 727 1.02:1
ListCommonPerf.default 712 700 1.02:1
ProviderMinimalPerf.default 1100 1079 1.02:1
RadioGroupMinimalPerf.default 493 485 1.02:1
SegmentMinimalPerf.default 398 392 1.02:1
AlertMinimalPerf.default 295 292 1.01:1
HeaderSlotsPerf.default 848 839 1.01:1
SplitButtonMinimalPerf.default 4037 3987 1.01:1
StatusMinimalPerf.default 739 735 1.01:1
CustomToolbarPrototype.default 3965 3937 1.01:1
TreeMinimalPerf.default 856 851 1.01:1
ChatDuplicateMessagesPerf.default 300 301 1:1
ChatWithPopoverPerf.default 401 400 1:1
CheckboxMinimalPerf.default 2830 2829 1:1
LabelMinimalPerf.default 426 424 1:1
RosterPerf.default 1312 1309 1:1
SliderMinimalPerf.default 1652 1654 1:1
TableManyItemsPerf.default 2062 2065 1:1
TableMinimalPerf.default 435 433 1:1
ToolbarMinimalPerf.default 988 992 1:1
AccordionMinimalPerf.default 169 171 0.99:1
AttachmentMinimalPerf.default 178 180 0.99:1
ButtonOverridesMissPerf.default 1773 1782 0.99:1
ButtonUseCssNestingPerf.default 1119 1130 0.99:1
DatepickerMinimalPerf.default 5579 5640 0.99:1
ImageMinimalPerf.default 414 418 0.99:1
LayoutMinimalPerf.default 413 418 0.99:1
ButtonSlotsPerf.default 598 611 0.98:1
DropdownMinimalPerf.default 3154 3231 0.98:1
InputMinimalPerf.default 1344 1365 0.98:1
MenuMinimalPerf.default 896 913 0.98:1
EmbedMinimalPerf.default 4367 4509 0.97:1
BoxMinimalPerf.default 373 388 0.96:1
ProviderMergeThemesPerf.default 1661 1725 0.96:1
SkeletonMinimalPerf.default 384 398 0.96:1

@ling1726 ling1726 marked this pull request as ready for review April 30, 2021 13:53
@ling1726 ling1726 requested review from layershifter and a team as code owners April 30, 2021 13:53
@miroslavstastny miroslavstastny requested a review from a team April 30, 2021 14:52
@ling1726 ling1726 merged commit cf345ff into microsoft:master May 3, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

馃帀@fluentui/react-menu@v9.0.0-alpha.18 has been released which incorporates this pull request.:tada:

Handy links:

miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request May 5, 2021
@ling1726 @miroslavstastny
Fail cypress (microsoft#18007)
6ce04b0 
* Fail cypress

* xit

* exit code on failed results

* failing test

* revert yml

* remove failing test

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

Assignees

@tomi-msft tomi-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ling1726 @fabricteam @msft-fluent-ui-bot @layershifter @tomi-msft