Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-label - Migration to new DX #18656

Conversation

tringakrasniqi
Copy link
Contributor

@tringakrasniqi tringakrasniqi commented Jun 22, 2021

Pull request checklist

Description of changes

Migration of package to new DX

@size-auditor
Copy link

size-auditor bot commented Jun 22, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4e3d4bc7a9b14dc50a97bdbe283bb3b3fa5deac8 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 22, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 932 822 5000
BaseButton mount 1017 983 5000
Breadcrumb mount 2778 2625 1000
ButtonNext mount 604 589 5000
Checkbox mount 1587 1668 5000
CheckboxBase mount 1490 1465 5000
ChoiceGroup mount 4951 4943 5000
ComboBox mount 1005 990 1000
CommandBar mount 10741 10599 1000
ContextualMenu mount 6870 6388 1000
DefaultButton mount 1241 1253 5000
DetailsRow mount 4095 4109 5000
DetailsRowFast mount 4079 4126 5000
DetailsRowNoStyles mount 3858 3945 5000
Dialog mount 2270 2280 1000
DocumentCardTitle mount 156 158 1000
Dropdown mount 3607 3608 5000
FocusTrapZone mount 1974 1935 5000
FocusZone mount 1876 1938 5000
IconButton mount 1965 1797 5000
Label mount 366 379 5000
Layer mount 1991 1992 5000
Link mount 510 532 5000
MakeStyles mount 1980 1948 50000
MenuButton mount 1661 1653 5000
MessageBar mount 2213 2252 5000
Nav mount 3754 3691 1000
OverflowSet mount 1143 1135 5000
Panel mount 2260 2269 1000
Persona mount 898 924 1000
Pivot mount 1501 1568 1000
PrimaryButton mount 1481 1419 5000
Rating mount 8720 8783 5000
SearchBox mount 1487 1482 5000
Shimmer mount 2937 2906 5000
Slider mount 2177 2176 5000
SpinButton mount 5373 5506 5000
Spinner mount 464 425 5000
SplitButton mount 3481 3492 5000
Stack mount 566 556 5000
StackWithIntrinsicChildren mount 1647 1657 5000
StackWithTextChildren mount 5153 5204 5000
SwatchColorPicker mount 11229 11271 5000
Tabs mount 1415 1507 1000
TagPicker mount 2657 2497 5000
TeachingBubble mount 12590 12428 5000
Text mount 475 491 5000
TextField mount 1558 1530 5000
ThemeProvider mount 1291 1258 5000
ThemeProvider virtual-rerender 632 627 5000
ThemeProviderNext mount 7996 7396 5000
Toggle mount 896 904 5000
buttonNative mount 141 132 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ImageMinimalPerf.default 446 399 1.12:1
AvatarMinimalPerf.default 216 196 1.1:1
ButtonSlotsPerf.default 618 564 1.1:1
FormMinimalPerf.default 468 425 1.1:1
AttachmentSlotsPerf.default 1211 1113 1.09:1
GridMinimalPerf.default 361 332 1.09:1
ChatWithPopoverPerf.default 377 349 1.08:1
DividerMinimalPerf.default 389 365 1.07:1
LayoutMinimalPerf.default 399 374 1.07:1
ProviderMinimalPerf.default 1159 1084 1.07:1
RefMinimalPerf.default 225 211 1.07:1
CheckboxMinimalPerf.default 2892 2740 1.06:1
DatepickerMinimalPerf.default 6511 6157 1.06:1
PortalMinimalPerf.default 174 164 1.06:1
BoxMinimalPerf.default 369 352 1.05:1
CarouselMinimalPerf.default 483 461 1.05:1
HeaderSlotsPerf.default 836 794 1.05:1
LabelMinimalPerf.default 420 399 1.05:1
CustomToolbarPrototype.default 4278 4078 1.05:1
CardMinimalPerf.default 600 579 1.04:1
FlexMinimalPerf.default 336 322 1.04:1
HeaderMinimalPerf.default 384 368 1.04:1
MenuButtonMinimalPerf.default 1754 1688 1.04:1
TableManyItemsPerf.default 2101 2016 1.04:1
ListNestedPerf.default 628 609 1.03:1
TableMinimalPerf.default 415 403 1.03:1
TreeMinimalPerf.default 899 875 1.03:1
AlertMinimalPerf.default 291 284 1.02:1
ButtonMinimalPerf.default 182 178 1.02:1
LoaderMinimalPerf.default 716 705 1.02:1
TreeWith60ListItems.default 206 201 1.02:1
VideoMinimalPerf.default 719 703 1.02:1
AnimationMinimalPerf.default 434 431 1.01:1
AttachmentMinimalPerf.default 175 173 1.01:1
ButtonOverridesMissPerf.default 1753 1742 1.01:1
DropdownManyItemsPerf.default 731 725 1.01:1
EmbedMinimalPerf.default 4224 4164 1.01:1
ItemLayoutMinimalPerf.default 1389 1374 1.01:1
ListWith60ListItems.default 694 690 1.01:1
MenuMinimalPerf.default 934 922 1.01:1
PopupMinimalPerf.default 573 569 1.01:1
SegmentMinimalPerf.default 362 357 1.01:1
SkeletonMinimalPerf.default 382 379 1.01:1
StatusMinimalPerf.default 759 748 1.01:1
ToolbarMinimalPerf.default 969 962 1.01:1
InputMinimalPerf.default 1372 1366 1:1
ListMinimalPerf.default 587 585 1:1
IconMinimalPerf.default 664 665 1:1
AccordionMinimalPerf.default 154 155 0.99:1
ChatMinimalPerf.default 657 666 0.99:1
DialogMinimalPerf.default 760 768 0.99:1
RadioGroupMinimalPerf.default 477 483 0.99:1
RosterPerf.default 1234 1263 0.98:1
SplitButtonMinimalPerf.default 4059 4138 0.98:1
TooltipMinimalPerf.default 1078 1097 0.98:1
ReactionMinimalPerf.default 392 405 0.97:1
TextMinimalPerf.default 381 391 0.97:1
ListCommonPerf.default 669 700 0.96:1
SliderMinimalPerf.default 1644 1710 0.96:1
TextAreaMinimalPerf.default 543 565 0.96:1
DropdownMinimalPerf.default 3014 3200 0.94:1
ProviderMergeThemesPerf.default 1608 1710 0.94:1
ChatDuplicateMessagesPerf.default 299 325 0.92:1

@Hotell
Copy link
Contributor

Hotell commented Jun 22, 2021

We found 2 bugs.

You can fix them on your own within this PR or wait till we fix those in migration so you can re-run it on your migrated package

@Hotell
Copy link
Contributor

Hotell commented Jun 22, 2021

migration fix #18661 - once it's merged, pls update your branch and re-run the migration 🙏

@Hotell
Copy link
Contributor

Hotell commented Jun 23, 2021

migration fixes landed in master. Please rebase your branch and run the migration again 🙏

@tringakrasniqi tringakrasniqi merged commit 5a6dd90 into microsoft:master Jun 25, 2021
@tringakrasniqi tringakrasniqi deleted the @tringakrasniqi/dx-migration-label branch August 26, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants