Set Id correctly when contextualMenuSection's title is an IContextualMenuItem #18853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changes
Baseline commit: 04992473170ac218369ccdc5f3b28cd0894d63a0 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 378d11f:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Panel | mount | 2095 | 1414 | 1000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 830 | 828 | 5000 | |
| BaseButton | mount | 901 | 921 | 5000 | |
| Breadcrumb | mount | 2640 | 2665 | 1000 | |
| ButtonNext | mount | 549 | 527 | 5000 | |
| Checkbox | mount | 1535 | 1527 | 5000 | |
| CheckboxBase | mount | 1275 | 1289 | 5000 | |
| ChoiceGroup | mount | 4779 | 4825 | 5000 | |
| ComboBox | mount | 990 | 1015 | 1000 | |
| CommandBar | mount | 10339 | 10425 | 1000 | |
| ContextualMenu | mount | 6460 | 6440 | 1000 | |
| DefaultButton | mount | 1132 | 1130 | 5000 | |
| DetailsRow | mount | 3768 | 3764 | 5000 | |
| DetailsRowFast | mount | 3735 | 3735 | 5000 | |
| DetailsRowNoStyles | mount | 3568 | 3669 | 5000 | |
| Dialog | mount | 2130 | 2098 | 1000 | |
| DocumentCardTitle | mount | 140 | 137 | 1000 | |
| Dropdown | mount | 3269 | 3219 | 5000 | |
| FluentProviderNext | mount | 7345 | 7403 | 5000 | |
| FocusTrapZone | mount | 1835 | 1822 | 5000 | |
| FocusZone | mount | 1861 | 1778 | 5000 | |
| IconButton | mount | 1740 | 1749 | 5000 | |
| Label | mount | 339 | 343 | 5000 | |
| Layer | mount | 1799 | 1784 | 5000 | |
| Link | mount | 454 | 462 | 5000 | |
| MakeStyles | mount | 1864 | 1845 | 50000 | |
| MenuButton | mount | 1480 | 1441 | 5000 | |
| MessageBar | mount | 2022 | 2130 | 5000 | |
| Nav | mount | 3339 | 3244 | 1000 | |
| OverflowSet | mount | 1057 | 1050 | 5000 | |
| Panel | mount | 2095 | 1414 | 1000 | Possible regression |
| Persona | mount | 826 | 844 | 1000 | |
| Pivot | mount | 1456 | 1412 | 1000 | |
| PrimaryButton | mount | 1292 | 1288 | 5000 | |
| Rating | mount | 7633 | 7645 | 5000 | |
| SearchBox | mount | 1377 | 1300 | 5000 | |
| Shimmer | mount | 2531 | 2601 | 5000 | |
| Slider | mount | 1956 | 1964 | 5000 | |
| SpinButton | mount | 4986 | 4981 | 5000 | |
| Spinner | mount | 439 | 429 | 5000 | |
| SplitButton | mount | 3124 | 3206 | 5000 | |
| Stack | mount | 509 | 499 | 5000 | |
| StackWithIntrinsicChildren | mount | 1521 | 1529 | 5000 | |
| StackWithTextChildren | mount | 4538 | 4502 | 5000 | |
| SwatchColorPicker | mount | 10134 | 10363 | 5000 | |
| Tabs | mount | 1416 | 1443 | 1000 | |
| TagPicker | mount | 2407 | 2399 | 5000 | |
| TeachingBubble | mount | 11993 | 12023 | 5000 | |
| Text | mount | 421 | 421 | 5000 | |
| TextField | mount | 1383 | 1373 | 5000 | |
| ThemeProvider | mount | 1197 | 1202 | 5000 | |
| ThemeProvider | virtual-rerender | 600 | 609 | 5000 | |
| Toggle | mount | 803 | 811 | 5000 | |
| buttonNative | mount | 121 | 129 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 162 | 149 | 1.09:1 |
| SkeletonMinimalPerf.default | 365 | 340 | 1.07:1 |
| GridMinimalPerf.default | 344 | 326 | 1.06:1 |
| PortalMinimalPerf.default | 184 | 174 | 1.06:1 |
| TreeWith60ListItems.default | 179 | 169 | 1.06:1 |
| SegmentMinimalPerf.default | 357 | 341 | 1.05:1 |
| CardMinimalPerf.default | 560 | 538 | 1.04:1 |
| LabelMinimalPerf.default | 396 | 379 | 1.04:1 |
| RadioGroupMinimalPerf.default | 448 | 431 | 1.04:1 |
| HeaderMinimalPerf.default | 362 | 350 | 1.03:1 |
| ListWith60ListItems.default | 639 | 619 | 1.03:1 |
| VideoMinimalPerf.default | 627 | 606 | 1.03:1 |
| AttachmentSlotsPerf.default | 1084 | 1065 | 1.02:1 |
| CarouselMinimalPerf.default | 480 | 472 | 1.02:1 |
| ChatWithPopoverPerf.default | 359 | 351 | 1.02:1 |
| CheckboxMinimalPerf.default | 2771 | 2709 | 1.02:1 |
| EmbedMinimalPerf.default | 4190 | 4094 | 1.02:1 |
| FlexMinimalPerf.default | 286 | 281 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1233 | 1211 | 1.02:1 |
| PopupMinimalPerf.default | 607 | 593 | 1.02:1 |
| IconMinimalPerf.default | 612 | 601 | 1.02:1 |
| TooltipMinimalPerf.default | 1019 | 1000 | 1.02:1 |
| AccordionMinimalPerf.default | 161 | 159 | 1.01:1 |
| AnimationMinimalPerf.default | 417 | 411 | 1.01:1 |
| BoxMinimalPerf.default | 346 | 343 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1696 | 1685 | 1.01:1 |
| ButtonSlotsPerf.default | 553 | 547 | 1.01:1 |
| DropdownMinimalPerf.default | 3123 | 3090 | 1.01:1 |
| ImageMinimalPerf.default | 379 | 375 | 1.01:1 |
| LayoutMinimalPerf.default | 370 | 365 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1659 | 1649 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1697 | 1682 | 1.01:1 |
| ProviderMinimalPerf.default | 974 | 969 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3774 | 3736 | 1.01:1 |
| TextAreaMinimalPerf.default | 501 | 496 | 1.01:1 |
| TreeMinimalPerf.default | 802 | 795 | 1.01:1 |
| ChatMinimalPerf.default | 650 | 649 | 1:1 |
| DividerMinimalPerf.default | 366 | 367 | 1:1 |
| DropdownManyItemsPerf.default | 676 | 677 | 1:1 |
| FormMinimalPerf.default | 406 | 404 | 1:1 |
| HeaderSlotsPerf.default | 747 | 747 | 1:1 |
| LoaderMinimalPerf.default | 700 | 699 | 1:1 |
| MenuMinimalPerf.default | 862 | 864 | 1:1 |
| SliderMinimalPerf.default | 1568 | 1570 | 1:1 |
| StatusMinimalPerf.default | 672 | 672 | 1:1 |
| TableManyItemsPerf.default | 1912 | 1907 | 1:1 |
| TextMinimalPerf.default | 355 | 355 | 1:1 |
| CustomToolbarPrototype.default | 3849 | 3842 | 1:1 |
| ToolbarMinimalPerf.default | 945 | 945 | 1:1 |
| AlertMinimalPerf.default | 273 | 276 | 0.99:1 |
| AvatarMinimalPerf.default | 187 | 188 | 0.99:1 |
| ButtonMinimalPerf.default | 160 | 162 | 0.99:1 |
| DatepickerMinimalPerf.default | 5495 | 5577 | 0.99:1 |
| InputMinimalPerf.default | 1244 | 1258 | 0.99:1 |
| ListMinimalPerf.default | 502 | 507 | 0.99:1 |
| RefMinimalPerf.default | 232 | 234 | 0.99:1 |
| TableMinimalPerf.default | 403 | 407 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 295 | 300 | 0.98:1 |
| DialogMinimalPerf.default | 755 | 769 | 0.98:1 |
| ListCommonPerf.default | 607 | 621 | 0.98:1 |
| ReactionMinimalPerf.default | 370 | 378 | 0.98:1 |
| ListNestedPerf.default | 539 | 563 | 0.96:1 |
| RosterPerf.default | 1140 | 1187 | 0.96:1 |
ecraig12345
reviewed
Jul 13, 2021
packages/react/src/components/ContextualMenu/ContextualMenu.base.tsx
Outdated
Show resolved
Hide resolved
…etIdPropertlyForTitle
ecraig12345
requested changes
Jul 13, 2021
packages/react/src/components/ContextualMenu/ContextualMenu.base.tsx
Outdated
Show resolved
Hide resolved
ecraig12345
reviewed
Jul 13, 2021
packages/react/src/components/ContextualMenu/ContextualMenu.base.tsx
Outdated
Show resolved
Hide resolved
…se.tsx Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
ecraig12345
approved these changes
Jul 14, 2021
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
2 tasks
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When a menu section's title is an IContextualMenuItem we were not setting the id on the created 'headerContextualMenuItem'.
This meant that the group had an 'aria-labelledby' set on it, but the div around the title's span element did not. So screen readers could not accurately read out when a user entered a menu section