Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charting: CherryPick #18865: Accessibility change for Donut chart #18865 #19150

Merged

Conversation

scharde
Copy link
Contributor

@scharde scharde commented Jul 27, 2021

Original description

Cherry pick of #18865

Description of changes

Changes are related to Donut Chart accessibility

  1. Accessibility Data prop added for the chart title and Callout. Accessibility Data props contain ariaLabel, ariaLabelledBy, and ariaDescribedBy props.
  2. If the user is sending any custom accessibility data, then that will be used. else only visible data will be used by the narrator.
    Custom Accessibility example is added for Donut chart.

Without Custom Accessibility Data:

image

With Custom Accessibility Data:

image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 27, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c4cc054:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 27, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7bc9d43ec591293ee2de4b9e5c5ebfef9192beb3 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 27, 2021

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 1005 1018 5000
Breadcrumb mount 43863 43459 5000
Checkbox mount 1774 1752 5000
CheckboxBase mount 1457 1473 5000
ChoiceGroup mount 5306 5456 5000
ComboBox mount 942 984 1000
CommandBar mount 8206 8145 1000
ContextualMenu mount 15320 14360 1000
DefaultButton mount 1270 1250 5000
DetailsRow mount 4021 3933 5000
DetailsRowFast mount 4072 4026 5000
DetailsRowNoStyles mount 3882 3914 5000
Dialog mount 1813 1867 1000
DocumentCardTitle mount 1865 1861 1000
Dropdown mount 2716 2731 5000
FocusTrapZone mount 1781 1770 5000
FocusZone mount 1895 1913 5000
IconButton mount 1955 1994 5000
Label mount 350 361 5000
Layer mount 2098 2137 5000
Link mount 473 482 5000
MenuButton mount 1683 1603 5000
MessageBar mount 2136 2148 5000
Nav mount 3546 3463 1000
OverflowSet mount 1553 1562 5000
Panel mount 1577 1614 1000
Persona mount 851 847 1000
Pivot mount 1553 1574 1000
PrimaryButton mount 1374 1420 5000
Rating mount 8592 8439 5000
SearchBox mount 1440 1452 5000
Shimmer mount 2712 2906 5000
Slider mount 1609 1636 5000
SpinButton mount 5508 5406 5000
Spinner mount 485 452 5000
SplitButton mount 3559 3557 5000
Stack mount 534 574 5000
StackWithIntrinsicChildren mount 1751 1726 5000
StackWithTextChildren mount 5154 5281 5000
SwatchColorPicker mount 11283 11217 5000
TagPicker mount 3115 3087 5000
TeachingBubble mount 52894 52693 5000
Text mount 477 483 5000
TextField mount 1565 1489 5000
Toggle mount 920 920 5000
button mount 104 114 5000

@scharde scharde closed this Jul 27, 2021
@scharde scharde reopened this Jul 27, 2021
@Raghurk Raghurk merged commit e851260 into microsoft:7.0 Jul 30, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/charting@v4.16.9 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-examples@v0.14.21 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants