Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charting: CherryPick #19059: Accessibility change for HeatMap chart #19059 #19171

Conversation

scharde
Copy link
Contributor

@scharde scharde commented Jul 29, 2021

Original description

Cherry pick of #19059

Description of changes
Changes are related to HeatMap Chart accessibility

  1. Accessibility Data prop added for the Callout content. Accessibility Data props contain ariaLabel, ariaLabelledBy, and ariaDescribedBy props.
  2. If the user is sending any custom accessibility data, then that will be used. else only visible data will be used by the narrator.
  3. Custom Accessibility example is added for the HeatMap chart.

Before Changes
image

After Changes
image

Focus areas to test

(optional)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de4525f:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 29, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7bc9d43ec591293ee2de4b9e5c5ebfef9192beb3 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 967 973 5000
Breadcrumb mount 42236 42302 5000
Checkbox mount 1670 1672 5000
CheckboxBase mount 1378 1397 5000
ChoiceGroup mount 5194 5267 5000
ComboBox mount 972 981 1000
CommandBar mount 7812 7938 1000
ContextualMenu mount 13325 13166 1000
DefaultButton mount 1202 1225 5000
DetailsRow mount 3845 3906 5000
DetailsRowFast mount 3865 3950 5000
DetailsRowNoStyles mount 3654 3646 5000
Dialog mount 1802 1815 1000
DocumentCardTitle mount 1857 1873 1000
Dropdown mount 2660 2644 5000
FocusTrapZone mount 1784 1768 5000
FocusZone mount 1866 1854 5000
IconButton mount 1868 1939 5000
Label mount 361 337 5000
Layer mount 2038 2044 5000
Link mount 459 483 5000
MenuButton mount 1627 1602 5000
MessageBar mount 2102 2145 5000
Nav mount 3418 3451 1000
OverflowSet mount 1466 1466 5000
Panel mount 1498 1504 1000
Persona mount 813 849 1000
Pivot mount 1479 1507 1000
PrimaryButton mount 1354 1348 5000
Rating mount 8302 8405 5000
SearchBox mount 1335 1383 5000
Shimmer mount 2793 2742 5000
Slider mount 1615 1602 5000
SpinButton mount 5190 5324 5000
Spinner mount 425 431 5000
SplitButton mount 3322 3345 5000
Stack mount 533 526 5000
StackWithIntrinsicChildren mount 1649 1628 5000
StackWithTextChildren mount 5015 5050 5000
SwatchColorPicker mount 10802 10721 5000
TagPicker mount 2906 2913 5000
TeachingBubble mount 51014 51128 5000
Text mount 451 460 5000
TextField mount 1487 1441 5000
Toggle mount 869 864 5000
button mount 114 111 5000

@Raghurk Raghurk merged commit 12c6121 into microsoft:7.0 Jul 30, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/fabric-website@v7.16.86 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/fabric-website-resources@v7.9.85 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/charting@v4.16.9 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-examples@v0.14.21 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants