Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize picker search for more icon for Suggestions #19671

Merged
merged 8 commits into from
Sep 9, 2021
Merged

Customize picker search for more icon for Suggestions #19671

merged 8 commits into from
Sep 9, 2021

Conversation

glenchao
Copy link
Contributor

@glenchao glenchao commented Sep 7, 2021 •
edited

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Suggestions currently allow custom search for more text but not icon. This PR makes it so that the icon is also customizable.

Focus areas to test

(optional)

@glenchao glenchao requested a review from a team as a code owner September 7, 2021 21:40
@ghost
Copy link

ghost commented Sep 7, 2021 •
edited by ghost

CLA assistant check
All CLA requirements met.

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 7, 2021 •
edited

📊 Bundle size report

🤖 This report was generated against 2c980c60e3c332f678cc4a74c0e3051756191bac

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 28d6a88:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 8, 2021 •
edited

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-Pickers 272.761 kB 272.786 kB ExceedsBaseline     25 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 2c980c60e3c332f678cc4a74c0e3051756191bac (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 8, 2021 •
edited

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 964 925 5000
BaseButton mount 984 942 5000
Breadcrumb mount 2567 2604 1000
ButtonNext mount 440 457 5000
Checkbox mount 1597 1626 5000
CheckboxBase mount 1340 1328 5000
ChoiceGroup mount 4940 4999 5000
ComboBox mount 1004 1082 1000
CommandBar mount 10118 10046 1000
ContextualMenu mount 6480 6600 1000
DefaultButton mount 1160 1166 5000
DetailsRow mount 3855 3856 5000
DetailsRowFast mount 3819 3881 5000
DetailsRowNoStyles mount 3649 3645 5000
Dialog mount 2426 2476 1000
DocumentCardTitle mount 138 142 1000
Dropdown mount 3349 3330 5000
FluentProviderNext mount 7019 6989 5000
FluentProviderWithTheme mount 340 337 10
FluentProviderWithTheme virtual-rerender 97 88 10
FluentProviderWithTheme virtual-rerender-with-unmount 435 456 10
FocusTrapZone mount 1749 1832 5000
FocusZone mount 1746 1773 5000
IconButton mount 1848 1858 5000
Label mount 349 339 5000
Layer mount 3001 3072 5000
Link mount 473 480 5000
MakeStyles mount 1770 1791 50000
MenuButton mount 1532 1515 5000
MessageBar mount 2004 2020 5000
Nav mount 3336 3359 1000
OverflowSet mount 1128 1090 5000
Panel mount 2384 2361 1000
Persona mount 856 856 1000
Pivot mount 1419 1418 1000
PrimaryButton mount 1365 1334 5000
Rating mount 8149 8039 5000
SearchBox mount 1388 1388 5000
Shimmer mount 2636 2677 5000
Slider mount 2009 1988 5000
SpinButton mount 5059 5132 5000
Spinner mount 411 425 5000
SplitButton mount 3202 3270 5000
Stack mount 498 513 5000
StackWithIntrinsicChildren mount 1640 1600 5000
StackWithTextChildren mount 4757 4918 5000
SwatchColorPicker mount 10434 10621 5000
Tabs mount 1405 1421 1000
TagPicker mount 2679 2689 5000
TeachingBubble mount 13241 13312 5000
Text mount 440 442 5000
TextField mount 1414 1405 5000
ThemeProvider mount 1167 1220 5000
ThemeProvider virtual-rerender 589 584 5000
ThemeProvider virtual-rerender-with-unmount 1920 1931 5000
Toggle mount 833 839 5000
buttonNative mount 107 102 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 313 277 1.13:1
TreeWith60ListItems.default 187 169 1.11:1
TextAreaMinimalPerf.default 551 517 1.07:1
BoxMinimalPerf.default 360 341 1.06:1
ButtonMinimalPerf.default 191 181 1.06:1
CardMinimalPerf.default 596 564 1.06:1
ItemLayoutMinimalPerf.default 1300 1227 1.06:1
PortalMinimalPerf.default 182 172 1.06:1
AnimationMinimalPerf.default 423 404 1.05:1
FormMinimalPerf.default 428 407 1.05:1
HeaderMinimalPerf.default 391 374 1.05:1
ImageMinimalPerf.default 401 382 1.05:1
ListCommonPerf.default 660 627 1.05:1
DropdownManyItemsPerf.default 720 689 1.04:1
MenuButtonMinimalPerf.default 1727 1665 1.04:1
ProviderMergeThemesPerf.default 1659 1595 1.04:1
ToolbarMinimalPerf.default 994 958 1.04:1
EmbedMinimalPerf.default 4260 4148 1.03:1
ListWith60ListItems.default 672 651 1.03:1
RadioGroupMinimalPerf.default 470 457 1.03:1
SkeletonMinimalPerf.default 365 354 1.03:1
TooltipMinimalPerf.default 1053 1021 1.03:1
ChatMinimalPerf.default 678 664 1.02:1
DatepickerMinimalPerf.default 5443 5347 1.02:1
DividerMinimalPerf.default 374 368 1.02:1
HeaderSlotsPerf.default 829 814 1.02:1
RefMinimalPerf.default 225 220 1.02:1
SegmentMinimalPerf.default 349 341 1.02:1
SliderMinimalPerf.default 1583 1558 1.02:1
StatusMinimalPerf.default 720 707 1.02:1
TableManyItemsPerf.default 2000 1964 1.02:1
AttachmentMinimalPerf.default 161 160 1.01:1
AttachmentSlotsPerf.default 1126 1114 1.01:1
CarouselMinimalPerf.default 481 474 1.01:1
ChatDuplicateMessagesPerf.default 297 293 1.01:1
LabelMinimalPerf.default 406 400 1.01:1
ListNestedPerf.default 594 586 1.01:1
MenuMinimalPerf.default 866 860 1.01:1
PopupMinimalPerf.default 591 588 1.01:1
TextMinimalPerf.default 353 349 1.01:1
TreeMinimalPerf.default 828 816 1.01:1
AccordionMinimalPerf.default 165 165 1:1
AlertMinimalPerf.default 277 276 1:1
ButtonSlotsPerf.default 579 579 1:1
InputMinimalPerf.default 1243 1244 1:1
LayoutMinimalPerf.default 375 374 1:1
ListMinimalPerf.default 527 527 1:1
LoaderMinimalPerf.default 706 709 1:1
SplitButtonMinimalPerf.default 4247 4267 1:1
VideoMinimalPerf.default 644 645 1:1
ChatWithPopoverPerf.default 378 381 0.99:1
CheckboxMinimalPerf.default 2746 2779 0.99:1
DialogMinimalPerf.default 772 777 0.99:1
DropdownMinimalPerf.default 3067 3099 0.99:1
ReactionMinimalPerf.default 385 388 0.99:1
CustomToolbarPrototype.default 3864 3902 0.99:1
GridMinimalPerf.default 335 343 0.98:1
ProviderMinimalPerf.default 1004 1023 0.98:1
TableMinimalPerf.default 425 434 0.98:1
RosterPerf.default 1251 1285 0.97:1
IconMinimalPerf.default 630 650 0.97:1
ButtonOverridesMissPerf.default 1709 1774 0.96:1
AvatarMinimalPerf.default 199 209 0.95:1

@glenchao glenchao force-pushed the tschao/customizePickerSearchForMoreIcon branch from ea1c153 to 5e4ef4b Compare September 9, 2021 19:48
@glenchao glenchao force-pushed the tschao/customizePickerSearchForMoreIcon branch from 522debd to a923f49 Compare September 9, 2021 20:12
@ecraig12345
Copy link
Member

Looks like the API file is still out of sync.

@ecraig12345
Copy link
Member

One way you could do this, assuming you have the main repo's remote called upstream:

git pull upstream master
yarn
yarn build --to @fluentui/react

@ecraig12345 ecraig12345 enabled auto-merge (squash) September 9, 2021 22:28
@ecraig12345 ecraig12345 merged commit da0edb6 into microsoft:master Sep 9, 2021
@glenchao glenchao mentioned this pull request Sep 9, 2021
Closed
2 tasks
@glenchao glenchao deleted the tschao/customizePickerSearchForMoreIcon branch September 9, 2021 23:50
@glenchao glenchao restored the tschao/customizePickerSearchForMoreIcon branch September 9, 2021 23:50
@glenchao glenchao deleted the tschao/customizePickerSearchForMoreIcon branch September 9, 2021 23:51
glenchao pushed a commit to glenchao/fluentui that referenced this pull request Sep 10, 2021
CherryPick #microsoft#19671 Customize picker search for more icon for…
d8a76a2 
… Suggestions
@glenchao glenchao mentioned this pull request Sep 10, 2021
Merged
2 tasks
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/theme-samples@v8.2.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tabs@v1.0.0-beta.154 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-monaco-editor@v1.2.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-experiments@v8.3.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-docsite-components@v8.3.26 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-date-time@v8.1.65 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-cards@v0.200.27 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/azure-themes@v8.1.66 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react@v8.33.0 has been released which incorporates this pull request.:tada:

Handy links:

ecraig12345 pushed a commit that referenced this pull request Sep 10, 2021
@glenchao
Cherrypick tschao/customize picker search for more icon (#19737)
c14ee37 
* CherryPick ##19671 Customize picker search for more icon for Suggestions

* Fix cherrypick

* Change files

Co-authored-by: Glen Chao <tschao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels
Component: Pickers PR: API Modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@glenchao @fabricteam @ecraig12345 @msft-fluent-ui-bot @GeoffCoxMSFT