Add null handling returned from promise inside BasePicker #19747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
📊 Bundle size report🤖 This report was generated against cbfa9a3717782183ebc86149abcde6468f97afa8 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0c1f9a:
|
Asset size changes
Baseline commit: cbfa9a3717782183ebc86149abcde6468f97afa8 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 634 | 652 | 5000 | |
| Breadcrumb | mount | 1668 | 1681 | 1000 | |
| Checkbox | mount | 1708 | 1718 | 5000 | |
| CheckboxBase | mount | 1468 | 1476 | 5000 | |
| ChoiceGroup | mount | 2944 | 2968 | 5000 | |
| ComboBox | mount | 622 | 646 | 1000 | |
| CommandBar | mount | 6101 | 6186 | 1000 | |
| ContextualMenu | mount | 11918 | 11921 | 1000 | |
| DefaultButton | mount | 751 | 736 | 5000 | |
| DetailsRow | mount | 2245 | 2136 | 5000 | |
| DetailsRowFast | mount | 2211 | 2196 | 5000 | |
| DetailsRowNoStyles | mount | 2043 | 2052 | 5000 | |
| Dialog | mount | 2626 | 2736 | 1000 | |
| DocumentCardTitle | mount | 231 | 230 | 1000 | |
| Dropdown | mount | 1959 | 1969 | 5000 | |
| FocusTrapZone | mount | 1109 | 1123 | 5000 | |
| FocusZone | mount | 1079 | 1065 | 5000 | |
| GroupedList | mount | 36862 | 41426 | 2 | |
| GroupedList | virtual-rerender | 19835 | 19620 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50306 | 50351 | 2 | |
| GroupedListV2 | mount | 220 | 216 | 2 | |
| GroupedListV2 | virtual-rerender | 208 | 217 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 234 | 228 | 2 | |
| IconButton | mount | 1072 | 1068 | 5000 | |
| Label | mount | 334 | 330 | 5000 | |
| Layer | mount | 2760 | 2711 | 5000 | |
| Link | mount | 396 | 403 | 5000 | |
| MenuButton | mount | 943 | 941 | 5000 | |
| MessageBar | mount | 21316 | 21217 | 5000 | |
| Nav | mount | 1968 | 1885 | 1000 | |
| OverflowSet | mount | 774 | 761 | 5000 | |
| Panel | mount | 1781 | 1798 | 1000 | |
| Persona | mount | 728 | 766 | 1000 | |
| Pivot | mount | 874 | 876 | 1000 | |
| PrimaryButton | mount | 843 | 850 | 5000 | |
| Rating | mount | 4515 | 4623 | 5000 | |
| SearchBox | mount | 923 | 894 | 5000 | |
| Shimmer | mount | 1857 | 1864 | 5000 | |
| Slider | mount | 1308 | 1328 | 5000 | |
| SpinButton | mount | 2852 | 2911 | 5000 | |
| Spinner | mount | 381 | 382 | 5000 | |
| SplitButton | mount | 1801 | 1812 | 5000 | |
| Stack | mount | 407 | 419 | 5000 | |
| StackWithIntrinsicChildren | mount | 864 | 864 | 5000 | |
| StackWithTextChildren | mount | 2594 | 2619 | 5000 | |
| SwatchColorPicker | mount | 6168 | 6085 | 5000 | |
| TagPicker | mount | 1454 | 1432 | 5000 | |
| Text | mount | 364 | 388 | 5000 | |
| TextField | mount | 921 | 952 | 5000 | |
| ThemeProvider | mount | 845 | 842 | 5000 | |
| ThemeProvider | virtual-rerender | 585 | 590 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1263 | 1247 | 5000 | |
| Toggle | mount | 599 | 597 | 5000 | |
| buttonNative | mount | 189 | 197 | 5000 |
|
Because this pull request has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. The pull request will still be available for reference. If it's still relevant to merge at some point, you can reopen or make a new version based on the latest code. |
msft-fluent-ui-bot
added
the
Resolution: Soft Close
|
Hello, |
🕵 fluentuiv8 No visual regressions between this PR and main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
adds null handling returned from promise
Focus areas to test
(optional)