Adds example of primary button with icon #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mike-morrison, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| @@ -1,3 +1,8 @@ | |||
| .ms-BasicButtonsExample .ms-Button { | |||
| margin: 10px 0; | |||
| } | |||
|
|
|||
| .ms-Icon { | |||
There was a problem hiding this comment.
scope this within the example so you don't create a rule that affects all icons
|
Haha :) Thank you! |
|
I am going to watch the PluralSight course on Sass. I will update the PR shortly. :) |
|
@dzearing added the requested changes. |
|
Closing this PR, as I think we don't want to take this one for now. |
This was referenced Apr 28, 2017
christiango
pushed a commit
that referenced
this pull request
Jun 19, 2017
* Add ComboBox functionality * Make a fix for IE where non-allowFreeform is showing the keypresses... * Update the PR with code review feedback. Simplified the code a lot, decoupled the shared props/memebers from comboBox and Dropdown, and extended BaseAutoFill which allowed DynamicAutoFill to be removed * Fixing some build warnings * Update my example page to explicitly not use two mutually exclusive props * The npm-shrinkwrap.json file automatically updated... commiting * Had a bad copy paste, fixing up the incorrectly logic * Removing the fontFamily aspect of the comboBox and utilizing the onRenderOption instead. The fontFamily aspect was too specific for the generic comboBox * Update based on feedback * Jspurlin jspurlin/combo box (#2) * Enable no implicit any in the utilities package (#1970) * Fix no implicit anys in utilities package. * Rush change * Reverse all shrinkwrap changes except the typings one. * Fix bundle minification to exclude debug warnings. (#1973) * Updating shrinkwrap, rush, and making minify build have production flag to remove debug code. * Updates. * removing lockfile. * dropping to 7. Moving back to npm run build. * Downgrading rush. * Applying package updates. * Website: Update dev.office.com header (#1966) * Use Fabric Core 7.1.0 for the website * Adjust position of caret's in header so that they spin around central axis * Update to latest icon font from dev.office.com for header and move outside out :global{} to fix build issue * Remove a u- prefix that was missed earlier * Update dev.office.com header with the latest navigation links * Add change file * Make sure the quote rule is enabled for tsline (#1961) * With responsive mode error (#1956) * withResponsiveMode: Adding error handling around the case where window.innerWidth throws an exception * adding change log file * Create withResponsiveMode.tsx * New Component: Stepper (#1759) * First step at stepper implementation. * Add first implementation of stepper. * Add functionality to stepper * Refine the Stepper class and add tests * let's make sure to put focus back on the text field when submitting via enter * Added documentation to Stepper. * Add flexibility to current stepper implementation. * Modified example implementations. * Add aria-valuemax. * Change Stepper to SpinButton. * Add example with unit. * Implement color scheme in the ContextualMenu control to enable alternative theming. * Improvements to SpinButton. * Fix increment function calls. * Add new width optional parameter. * Add label direction. * Fix border. * Add Position enum. * `defaultValue` is now the deciding prop for using the default implementation or not. * onBlur is now onValidate. * Fix tests. * Fix warnings. * Add implementation for labelGap. * Put some polish on the styling, added some icon support, and added some more example spinButtons * Implement the bar and unit tests and component page * Add the ability for the spinButton buttons to look pressed when spinning via keyboard * Revert "Implement color scheme in the ContextualMenu control to enable alternative theming." This reverts commit 4f830cd. * Don't render an empty icon for an icon-less header menu item. * Revert "Implement Document Title Bar" * update some CSS for high contrast in ff and use css utility instead of concatenating string classnames * Fix quotation issue * Fix Spin Button properties table. * Fix Spin Button example code * Use iconProps instead of string * Extracted `spinning` out of state * Add autobind instead of manually binding private functions to this * Change `+` syntax for more explicit `Number()` * Remove unnecessary cast * Fix typos * `incrementButtonIcon` and `decrementButtonIcon` are now IIconProps * Add KeyboardSpinDirection enum * Fix test description * Fix SpinButton tests * Remove unused onChange callback from SpinButton * Revert onChange * Remove old Stepper.ts file * Use module css instead of global * Fix missing word in comment * Callback functions now allow for void return (state to be updated outside) * Use `_async` instead of window * Fix minor rendering issue with browser zoom * Rename `_spinning` to `_spinningByMouse` for clarity * Fix tests * Fix extra space before label * Remove width outside of SpinButton component and fix styling * Add more tests to SpinButton * Fix SpinButton documentation * Fix typo * Fix AppDefinition for SpinButton and Spinner * Add missing documentation to SpinButton title prop * Various SpinButton fixes * Fix SpinButton path for properties * Fix SpinButton styling issues * Remove labelGap property from SpinButton * merge some changes * merge changes * merge * Fix a new tslint warning after npm installing * Fixing some casing warnings npm start was angry about * Removing an extra line that got added with the last push * Create SelectableOption.ts * Create SelectableOption.ts * Create ComboBox.Props.ts * Create ComboBox.test.tsx * Create ComboBox.Basic.Example.tsx * Create Dropdown.Props.ts * Fix the case sensitivity issue * one more casing issue * changing the reference of utilities in the test file * Actually it look like it has to be pascalCase here * ... really... what's going on with the casing here * Address feedback from in person review with David * A few minor updated to remove uneeded comment and unneeded try/finally in tests * Fix up a typo and fix up to use consistent syntax on a few lines
2 tasks
2 tasks
2 tasks
5 tasks
dzearing
pushed a commit
that referenced
this pull request
Apr 15, 2018
* rush generate * fix utilities * Upgrade fabric react * Rush change * Merge upstream (#2) * In Panel component, isClickableOutsideFocusTrap should not be overriden back to false if it's already set to true in focusTrapZoneProps. (#4354) * In Panel, a true value of isClickableOutsideFocusTrap prop in focusTrapZoneProps should not be overriden. * Add change file. * MessageBar: For single line, put action button before dismiss button (#4365) * Reordered button elements for single line messagebars * New example for single line with dismiss and action buttons * Added change file * [TextField, Panel] Removed componentId internal prop (#3896) * Remove componentId internal prop * change file * Reinstate prop as deprecated * Fixed tslint issue * Update magellan-componentIdInternal_2018-02-06-19-27.json * Fix errors in Signal styles (#4367) * Fix: Website: Does not show neutral quaternary colors (#4188) * Add missing quaternary and alt colors on doc page * + change file * Fix focuszone props (#4335) * Revert "FocusTrapZone does not correctly trap focus when last child is FocusZone (#4172)" This reverts commit 699fa69. * Fix focus zone props so that it doesn't have a typescript error * adding change file * Searchbox: deprecate defaultValue (#4225) * Deprecate SearchBox defaultValue prop. * npm run change output * Do not try to show the suggestions when input is undefined (no more exceptions in IE) (#4294) * [BasePicker] suggestions should not be shown when input does not exist * added change file * Update master_2018-03-16-09-03.json * Remove a redundant "value" prop in ComboBox multi select example to eliminate confusing behaviors. (#4366) * Add multiSelect for ComboBox * Unbreak a unit test * rush change * bug fixes * Merge from upstream and resolve local build issues * Fix merge styles * Fix pending background * Unbreak unit test cases * Fix the merge * Add controled multi-select in the example page to make sure onChanged cb works * Remove trailing white spaces * Fix bug: enter key will not trigger onChanged * Dummy change to trigger another build * refactor * Fix some minor bugs * Update some comments for ComboBox * Minor bug fixes to the example page * rush change * Delete the old rush change file * Remove a trailing space * Remove a redundant property from the ComboBox example * rush chagne * Remove old rush change file * Update stanleyy-fillin_2018-03-26-22-09.json * Moving to ts-loader, throwing on console.warn in ssr tests (#4370) * Break on warnings. * Shrinkwrap update. * Applying package updates. * Missed a reference to awesome-typescript-loader in the webpack-resources file. * Rewrite suggestions for BaseFloatingPicker (experiments) (#4273) * create new suggestions, suggestionsControl, and suggestionsStore in experiments * add change files * fix picker tests and separate scss file into two files * Update BaseFloatingPicker.tsx * remove autobind reference from bad merge * address PR comments * address PR comments, fix selection for shouldSelectFirstItem * Checkbox: text should be selectable, icon shouldn't. (#4378) * Updating checkbox select. * addin change. * Fix snapshot. * Update change output (#4380) * Contextual Menu: Revert Split Button Alignment to Previous Left Aligntment (#4369) * made spin button and base button menu option un-focusable * added spin button test * added split button contextual menu change * got rid of un-needed code * added change files * added abillitiy to not focus on primary button for split button, but only on the container * enter on focus on split button trigger primary action * added split button style for disabled * prevent opening submenu if item is disabled * tighten restrictions on opening split buttons to open with alt + down * refactored button name and fixed test * updated bundle size * changed on menu item click to bw able to take in a keyboard event * updated package json * fixed weird tabbing * changed way we structured the focus * added stop propagation * changed split button container key down to work with other buttons now * update bundle size * added correct split button container styles * removed unnecessary attribute * fixed focusing on menu button when primary button is disabled * added change to focus * added aria hidden * fixed span location and moved TODO * added support to focus on whole container in split button for contextual menus * added comment * fixed styling issues with buttons * fixed style problems for contextual split button where content is centered * reverted change * added appropriate change file * Update contextualMenuAlignSplitButton_2018-03-27-18-13.json * Integrate markdown-to-jsx in example-app-base for use in documentation (#4302) * Add markdown to jsx related packages and update shrinkwrap * Copy template components to example app base and correct imports. * Create example md files * Add Markdown typings * Remove commented code * Test using md files in Activity Item Page * Simplify raw-loader md imports * npm run change output * Expand md import to full path * Applying package updates. * Contextual Menu Fix Split Button Submenu Target (#4368) * Update SplitButton submenu in ContextualMenu to base itself of the splitButtonContainer * rush change * used ref to pass in container instead of parent element for more defenseive code * changed class to use correct refs * added example and refactored focus * Initials for phone numbers (#4376) * Adding option for calculating initials for phone numbers * Added change description * Name change and cleanup * Update initials-for-phonenumbers_2018-03-27-14-10.json * Update initials-for-phonenumbers_2018-03-27-14-10.json * Applying package updates. * Markdown-to-jsx: fix dependencies (#4389) * Add markdown to jsx related packages and update shrinkwrap * Copy template components to example app base and correct imports. * Create example md files * Add Markdown typings * Remove commented code * Test using md files in Activity Item Page * Simplify raw-loader md imports * npm run change output * Expand md import to full path * Move markdown and syntax packages to dependencies. * Move md files to docs folder. * Applying package updates. * Remove root-level imports of office-ui-fabric-react from /experiments (#4392) * Remove root imports of office-ui-fabric-react * Update change output * Fixing tests in experiments to not generate warnings in `npm start`. (#4391) * Applying package updates. * Variants: fix theming output so original input theme values are respected (#4393) * oops * changefile * dry * max line length error * Applying package updates. * OverflowSet: allow the OverflowSet to not be contained within a FocusZone (#4400) * Add a prop so that OverflowSets do not have to contain FocusZones * pull the common aspects into variables so they can be reused * simplify OverflowSet even more (use Tag to remove duplication) * Revert back and remove the key since it's no longer needed * rush change * Make sure the focusZoneProps are still getting passed down * The divProperties only need to be used when doNotContainWithinFocusZone is true * Remove unneeded import * DetailsList: link color invisible for selected row in high-contrast-white (#4395) * DetailsList: link color too close to selected background in high-contrast-white * add change file * SplitButton: Close menu when primary button is clicked (#4403) * Updating the split button to close the menu when the primary button is executed. * change * Fix Signal rendering in IE (#4404) * More Signals fixes * Update change output * Pass all props to Signal Icon elements * Update change output * Pickers: Fix suggestions not having proper value selected (#4408) * Revert "FocusTrapZone does not correctly trap focus when last child is FocusZone (#4172)" This reverts commit 699fa69. * fix picker suggestions and add many tests * adding snap file * adding change file * improve test * fix tests and config * revert test changes * last test update * update test name and snapshot * remove tests to expedite checkin * Breadcrumb: File rename to make the 6.0 merge diff more readable. (#4394) * File rename to make the 6.0 merge diff more readable. * Adding checkbox. * Also moving a few more. * Pickers: Add suggestions tests (#4409) * Revert "FocusTrapZone does not correctly trap focus when last child is FocusZone (#4172)" This reverts commit 699fa69. * fix picker suggestions and add many tests * adding snap file * adding change file * improve test * fix tests and config * revert test changes * last test update * update test name and snapshot * undo suggestions change so it will merge properly * revert change to suggestions * Disable tree shaking (temporarily) (#4410) * Temporarily disable tree shaking. * Adding change files. * HTMLButton -> HTML Element
2 tasks
2 tasks
KevinTCoughlin
added a commit
to KevinTCoughlin/office-ui-fabric-react
that referenced
this pull request
Sep 17, 2018
Closed
2 tasks
2 tasks
sopranopillow
added a commit
to sopranopillow/fluentui
that referenced
this pull request
Jul 25, 2019
Tsx editor- adding requested changes
ValentinaKozlova
added a commit
to ValentinaKozlova/fluentui
that referenced
this pull request
May 31, 2023
ValentinaKozlova
added a commit
to ValentinaKozlova/fluentui
that referenced
this pull request
Jun 15, 2023
ValentinaKozlova
added a commit
to ValentinaKozlova/fluentui
that referenced
this pull request
Sep 29, 2023
ValentinaKozlova
added a commit
to ValentinaKozlova/fluentui
that referenced
this pull request
Oct 2, 2023
ValentinaKozlova
added a commit
to ValentinaKozlova/fluentui
that referenced
this pull request
Feb 19, 2024
ValentinaKozlova
added a commit
to ValentinaKozlova/fluentui
that referenced
this pull request
May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds @dzearing example for adding an inline button. I think once the styles are enhanced to take an icon universally, we should leave this example up to show the flexibility of the button.
Side note: @dzearing Can you tell I was hitting the refresh button nonstop waiting for you to open this project up? 👍 Great work to you and team. Can't wait to dig in more!