Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-card - Bundle size fixtures #20029

Merged
merged 3 commits into from
Oct 1, 2021
Merged

react-card - Bundle size fixtures #20029

merged 3 commits into from
Oct 1, 2021

Conversation

andrefcdias
Copy link
Contributor

Description of changes

Added bundle-size fixtures to Card and respective components

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-card
Card - All
0 B
0 B
13.263 kB
4.984 kB
🆕 New entry
react-card
Card
0 B
0 B
9.139 kB
3.831 kB
🆕 New entry
react-card
CardFooter
0 B
0 B
8.468 kB
3.557 kB
🆕 New entry
react-card
CardHeader
0 B
0 B
9.695 kB
3.99 kB
🆕 New entry
react-card
CardPreview
0 B
0 B
8.753 kB
3.724 kB
🆕 New entry
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
165.643 kB
46.977 kB
react-components
react-components: FluentProvider & webLightTheme
34.361 kB
11.35 kB
🤖 This report was generated against 8952fa63a35532efafbcb5fd7290875fe838caeb

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0762761:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 29, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8952fa63a35532efafbcb5fd7290875fe838caeb (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 770 765 5000
BaseButton mount 763 768 5000
Breadcrumb mount 2246 2273 1000
ButtonNext mount 388 396 5000
Checkbox mount 1313 1289 5000
CheckboxBase mount 1115 1109 5000
ChoiceGroup mount 4073 4025 5000
ComboBox mount 793 798 1000
CommandBar mount 8834 8702 1000
ContextualMenu mount 5484 5504 1000
DefaultButton mount 958 957 5000
DetailsRow mount 3212 3215 5000
DetailsRowFast mount 3200 3247 5000
DetailsRowNoStyles mount 3059 3073 5000
Dialog mount 2082 2061 1000
DocumentCardTitle mount 136 132 1000
Dropdown mount 2731 2758 5000
FluentProviderNext mount 6311 6252 5000
FluentProviderWithTheme mount 305 318 10
FluentProviderWithTheme virtual-rerender 81 84 10
FluentProviderWithTheme virtual-rerender-with-unmount 350 336 10
FocusTrapZone mount 1538 1532 5000
FocusZone mount 1570 1565 5000
IconButton mount 1456 1480 5000
Label mount 301 297 5000
Layer mount 2542 2553 5000
Link mount 395 399 5000
MakeStyles mount 1578 1577 50000
MenuButton mount 1252 1248 5000
MessageBar mount 1726 1699 5000
Nav mount 2851 2854 1000
OverflowSet mount 935 938 5000
Panel mount 2028 1971 1000
Persona mount 708 696 1000
Pivot mount 1222 1216 1000
PrimaryButton mount 1099 1082 5000
Rating mount 6607 6569 5000
SearchBox mount 1138 1108 5000
Shimmer mount 2191 2134 5000
Slider mount 1662 1653 5000
SpinButton mount 4266 4310 5000
Spinner mount 357 358 5000
SplitButton mount 2663 2705 5000
Stack mount 424 426 5000
StackWithIntrinsicChildren mount 1452 1435 5000
StackWithTextChildren mount 3905 3972 5000
SwatchColorPicker mount 8739 8795 5000
Tabs mount 1196 1205 1000
TagPicker mount 2265 2258 5000
TeachingBubble mount 10982 10904 5000
Text mount 362 359 5000
TextField mount 1176 1152 5000
ThemeProvider mount 1004 1015 5000
ThemeProvider virtual-rerender 506 515 5000
ThemeProvider virtual-rerender-with-unmount 1568 1561 5000
Toggle mount 664 686 5000
buttonNative mount 94 108 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FormMinimalPerf.default 361 327 1.1:1
PortalMinimalPerf.default 164 151 1.09:1
GridMinimalPerf.default 298 285 1.05:1
AttachmentMinimalPerf.default 144 138 1.04:1
AttachmentSlotsPerf.default 951 911 1.04:1
BoxMinimalPerf.default 305 293 1.04:1
LayoutMinimalPerf.default 315 302 1.04:1
ListMinimalPerf.default 437 422 1.04:1
ReactionMinimalPerf.default 325 313 1.04:1
SegmentMinimalPerf.default 296 285 1.04:1
TextMinimalPerf.default 303 290 1.04:1
CustomToolbarPrototype.default 3632 3493 1.04:1
VideoMinimalPerf.default 532 512 1.04:1
ButtonMinimalPerf.default 146 142 1.03:1
ButtonSlotsPerf.default 489 477 1.03:1
CardMinimalPerf.default 481 466 1.03:1
ChatMinimalPerf.default 564 548 1.03:1
HeaderMinimalPerf.default 313 305 1.03:1
LabelMinimalPerf.default 331 322 1.03:1
IconMinimalPerf.default 529 512 1.03:1
AccordionMinimalPerf.default 132 130 1.02:1
ChatDuplicateMessagesPerf.default 268 264 1.02:1
DatepickerMinimalPerf.default 4888 4809 1.02:1
DialogMinimalPerf.default 646 635 1.02:1
EmbedMinimalPerf.default 3625 3567 1.02:1
FlexMinimalPerf.default 244 240 1.02:1
LoaderMinimalPerf.default 602 593 1.02:1
MenuMinimalPerf.default 721 707 1.02:1
RosterPerf.default 1027 1011 1.02:1
ProviderMinimalPerf.default 975 960 1.02:1
RadioGroupMinimalPerf.default 380 371 1.02:1
ToolbarMinimalPerf.default 799 786 1.02:1
AlertMinimalPerf.default 244 242 1.01:1
CarouselMinimalPerf.default 405 402 1.01:1
ChatWithPopoverPerf.default 330 328 1.01:1
CheckboxMinimalPerf.default 2344 2315 1.01:1
DropdownManyItemsPerf.default 585 582 1.01:1
DropdownMinimalPerf.default 2718 2697 1.01:1
HeaderSlotsPerf.default 645 641 1.01:1
ImageMinimalPerf.default 313 309 1.01:1
InputMinimalPerf.default 1111 1104 1.01:1
ItemLayoutMinimalPerf.default 1019 1013 1.01:1
ListWith60ListItems.default 548 540 1.01:1
MenuButtonMinimalPerf.default 1378 1363 1.01:1
SliderMinimalPerf.default 1452 1431 1.01:1
TooltipMinimalPerf.default 880 868 1.01:1
TreeMinimalPerf.default 673 668 1.01:1
AnimationMinimalPerf.default 352 351 1:1
ButtonOverridesMissPerf.default 1518 1517 1:1
DividerMinimalPerf.default 303 303 1:1
ProviderMergeThemesPerf.default 1453 1459 1:1
SplitButtonMinimalPerf.default 3611 3595 1:1
StatusMinimalPerf.default 559 559 1:1
TableManyItemsPerf.default 1601 1601 1:1
ListNestedPerf.default 464 471 0.99:1
SkeletonMinimalPerf.default 302 304 0.99:1
TableMinimalPerf.default 336 338 0.99:1
TextAreaMinimalPerf.default 409 413 0.99:1
AvatarMinimalPerf.default 165 169 0.98:1
PopupMinimalPerf.default 498 506 0.98:1
TreeWith60ListItems.default 155 158 0.98:1
ListCommonPerf.default 526 541 0.97:1
RefMinimalPerf.default 190 199 0.95:1

Copy link
Contributor

@tringakrasniqi tringakrasniqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CXE Prague - @microsoft/cxe-prg automation moved this from In progress to Reviewer approved Sep 29, 2021
@andrefcdias andrefcdias merged commit 59c5d0e into microsoft:master Oct 1, 2021
CXE Prague - @microsoft/cxe-prg automation moved this from Reviewer approved to Done Oct 1, 2021
@andrefcdias andrefcdias deleted the card-bundlesize branch October 1, 2021 15:10
@Hotell Hotell moved this from Done to Archive in CXE Prague - @microsoft/cxe-prg Oct 21, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants