Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web-components storybook #20281

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Fix web-components storybook #20281

merged 2 commits into from
Oct 21, 2021

Conversation

ecraig12345
Copy link
Member

#20219 broke building/starting storybook for web-components by causing it to use @storybook/react from the root, rather than @storybook/html from that folder. Fix is to bring back the override scripts using the correct module.

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against d41e8379b190ae05d33dc0d429b5636302f5f28a

@size-auditor
Copy link

size-auditor bot commented Oct 20, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d41e8379b190ae05d33dc0d429b5636302f5f28a (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c0058fd:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 971 986 5000
BaseButton mount 942 981 5000
Breadcrumb mount 2592 2584 1000
ButtonNext mount 542 522 5000
Checkbox mount 1617 1645 5000
CheckboxBase mount 1379 1398 5000
ChoiceGroup mount 5039 5023 5000
ComboBox mount 1003 1009 1000
CommandBar mount 10217 10048 1000
ContextualMenu mount 6369 6429 1000
DefaultButton mount 1214 1244 5000
DetailsRow mount 3970 3989 5000
DetailsRowFast mount 3891 3970 5000
DetailsRowNoStyles mount 3770 3796 5000
Dialog mount 2555 2549 1000
DocumentCardTitle mount 159 190 1000
Dropdown mount 3433 3478 5000
FluentProviderNext mount 3199 3199 5000
FluentProviderWithTheme mount 212 202 10
FluentProviderWithTheme virtual-rerender 112 112 10
FluentProviderWithTheme virtual-rerender-with-unmount 242 244 10
FocusTrapZone mount 1850 1896 5000
FocusZone mount 1800 1788 5000
IconButton mount 1840 1844 5000
Label mount 366 387 5000
Layer mount 3086 3090 5000
Link mount 507 511 5000
MakeStyles mount 1803 1802 50000
MenuButton mount 1555 1600 5000
MessageBar mount 2022 2059 5000
Nav mount 3607 3449 1000
OverflowSet mount 1135 1185 5000
Panel mount 2438 2416 1000
Persona mount 885 878 1000
Pivot mount 1490 1480 1000
PrimaryButton mount 1374 1361 5000
Rating mount 8396 8526 5000
SearchBox mount 1450 1415 5000
Shimmer mount 2774 2738 5000
Slider mount 2034 2052 5000
SpinButton mount 5220 5245 5000
Spinner mount 430 444 5000
SplitButton mount 3263 3291 5000
Stack mount 541 529 5000
StackWithIntrinsicChildren mount 1859 1824 5000
StackWithTextChildren mount 5020 5103 5000
SwatchColorPicker mount 10905 10879 5000
Tabs mount 1499 1446 1000
TagPicker mount 2781 2789 5000
TeachingBubble mount 12887 12926 5000
Text mount 456 472 5000
TextField mount 1465 1507 5000
ThemeProvider mount 1227 1202 5000
ThemeProvider virtual-rerender 644 628 5000
ThemeProvider virtual-rerender-with-unmount 2010 2036 5000
Toggle mount 852 855 5000
buttonNative mount 125 143 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 195 179 1.09:1
LoaderMinimalPerf.default 748 693 1.08:1
AnimationMinimalPerf.default 443 415 1.07:1
LabelMinimalPerf.default 421 395 1.07:1
AvatarMinimalPerf.default 216 203 1.06:1
ChatDuplicateMessagesPerf.default 329 309 1.06:1
FlexMinimalPerf.default 297 281 1.06:1
FormMinimalPerf.default 453 429 1.06:1
InputMinimalPerf.default 1372 1300 1.06:1
ReactionMinimalPerf.default 414 392 1.06:1
TreeWith60ListItems.default 200 189 1.06:1
ImageMinimalPerf.default 414 396 1.05:1
StatusMinimalPerf.default 734 696 1.05:1
TableMinimalPerf.default 431 412 1.05:1
ToolbarMinimalPerf.default 1004 959 1.05:1
ChatWithPopoverPerf.default 415 399 1.04:1
ListWith60ListItems.default 689 660 1.04:1
VideoMinimalPerf.default 688 664 1.04:1
AccordionMinimalPerf.default 170 165 1.03:1
DialogMinimalPerf.default 776 753 1.03:1
GridMinimalPerf.default 366 356 1.03:1
HeaderSlotsPerf.default 828 804 1.03:1
LayoutMinimalPerf.default 397 385 1.03:1
MenuMinimalPerf.default 896 869 1.03:1
RadioGroupMinimalPerf.default 471 458 1.03:1
BoxMinimalPerf.default 381 372 1.02:1
ItemLayoutMinimalPerf.default 1274 1254 1.02:1
ListNestedPerf.default 591 580 1.02:1
MenuButtonMinimalPerf.default 1728 1691 1.02:1
ProviderMinimalPerf.default 1156 1130 1.02:1
IconMinimalPerf.default 647 634 1.02:1
AlertMinimalPerf.default 299 295 1.01:1
CardMinimalPerf.default 610 604 1.01:1
EmbedMinimalPerf.default 4374 4352 1.01:1
ListCommonPerf.default 690 683 1.01:1
PortalMinimalPerf.default 176 174 1.01:1
RefMinimalPerf.default 233 231 1.01:1
TextMinimalPerf.default 368 366 1.01:1
TreeMinimalPerf.default 840 833 1.01:1
CarouselMinimalPerf.default 492 491 1:1
CheckboxMinimalPerf.default 2763 2757 1:1
DatepickerMinimalPerf.default 5573 5589 1:1
HeaderMinimalPerf.default 379 380 1:1
RosterPerf.default 1306 1302 1:1
PopupMinimalPerf.default 605 607 1:1
SegmentMinimalPerf.default 370 370 1:1
SliderMinimalPerf.default 1724 1725 1:1
TableManyItemsPerf.default 2012 2002 1:1
CustomToolbarPrototype.default 4122 4119 1:1
TooltipMinimalPerf.default 1066 1061 1:1
AttachmentSlotsPerf.default 1123 1135 0.99:1
ButtonSlotsPerf.default 581 584 0.99:1
ChatMinimalPerf.default 686 690 0.99:1
DropdownMinimalPerf.default 3167 3190 0.99:1
ProviderMergeThemesPerf.default 1680 1694 0.99:1
SkeletonMinimalPerf.default 373 376 0.99:1
SplitButtonMinimalPerf.default 4390 4430 0.99:1
ButtonOverridesMissPerf.default 1792 1824 0.98:1
DividerMinimalPerf.default 381 393 0.97:1
DropdownManyItemsPerf.default 709 734 0.97:1
TextAreaMinimalPerf.default 536 551 0.97:1
AttachmentMinimalPerf.default 161 167 0.96:1
ListMinimalPerf.default 531 551 0.96:1

@brookdozer
Copy link
Contributor

Tested locally and this works for me, using web components' @storybook/html. Thank you!

V-Build - @microsoft/fluentui-react-build automation moved this from In progress to Reviewer approved Oct 21, 2021
@ecraig12345 ecraig12345 merged commit 619163b into microsoft:master Oct 21, 2021
V-Build - @microsoft/fluentui-react-build automation moved this from Reviewer approved to Done Oct 21, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants