Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(getNativeElementProps): Add support for onAuxClick #20343

Merged
merged 2 commits into from
Oct 26, 2021
Merged

fix(getNativeElementProps): Add support for onAuxClick #20343

merged 2 commits into from
Oct 26, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Oct 26, 2021 •
edited
Loading

Adds support for the onAuxClick native handler

Pull request checklist

Description of changes

(give an overview)

Focus areas to test

(optional)

@ling1726
fix(getNativeElementPrps): Add support for onAuxClick
62f5d65 
Adds support for the `onAuxClick` native handler
@ling1726 ling1726 marked this pull request as ready for review October 26, 2021 08:12
@ling1726 ling1726 requested a review from a team as a code owner October 26, 2021 08:12
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 26, 2021 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)		 57.694 kB
18.16 kB		 57.707 kB
18.166 kB		 13 B
6 B
react-avatar
Avatar		 54.953 kB
15.667 kB		 54.966 kB
15.674 kB		 13 B
7 B
react-badge
Badge		 23.182 kB
6.986 kB		 23.195 kB
6.992 kB		 13 B
6 B
react-badge
CounterBadge		 25.642 kB
7.682 kB		 25.655 kB
7.688 kB		 13 B
6 B
react-badge
PresenceBadge		 30.661 kB
8.815 kB		 30.674 kB
8.821 kB		 13 B
6 B
react-button
Button		 25.501 kB
7.738 kB		 25.514 kB
7.744 kB		 13 B
6 B
react-button
CompoundButton		 30.758 kB
8.689 kB		 30.771 kB
8.696 kB		 13 B
7 B
react-button
MenuButton		 27.526 kB
8.413 kB		 27.539 kB
8.42 kB		 13 B
7 B
react-button
SplitButton		 33.637 kB
9.597 kB		 33.65 kB
9.603 kB		 13 B
6 B
react-button
ToggleButton		 34.727 kB
8.39 kB		 34.74 kB
8.396 kB		 13 B
6 B
react-card
Card - All		 48.995 kB
14.558 kB		 49.008 kB
14.564 kB		 13 B
6 B
react-card
Card		 44.482 kB
13.339 kB		 44.495 kB
13.343 kB		 13 B
4 B
react-card
CardFooter		 8.128 kB
3.424 kB		 8.141 kB
3.43 kB		 13 B
6 B
react-card
CardHeader		 9.448 kB
3.878 kB		 9.461 kB
3.883 kB		 13 B
5 B
react-card
CardPreview		 8.421 kB
3.599 kB		 8.434 kB
3.604 kB		 13 B
5 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 169.335 kB
48.057 kB		 169.348 kB
48.062 kB		 13 B
5 B
react-components
react-components: FluentProvider & webLightTheme		 32.188 kB
10.658 kB		 32.201 kB
10.665 kB		 13 B
7 B
react-divider
Divider		 15.342 kB
5.585 kB		 15.355 kB
5.592 kB		 13 B
7 B
react-image
Image		 9.771 kB
3.975 kB		 9.784 kB
3.982 kB		 13 B
7 B
react-input
Input		 31.319 kB
11.305 kB		 31.332 kB
11.311 kB		 13 B
6 B
react-label
Label		 8.952 kB
3.708 kB		 8.965 kB
3.713 kB		 13 B
5 B
react-link
Link		 11.646 kB
4.699 kB		 11.659 kB
4.704 kB		 13 B
5 B
react-menu
Menu (including children components)		 105.789 kB
32.202 kB		 105.802 kB
32.207 kB		 13 B
5 B
react-menu
Menu (including selectable components)		 108.065 kB
32.575 kB		 108.078 kB
32.58 kB		 13 B
5 B
react-popover
Popover		 101.153 kB
30.37 kB		 101.166 kB
30.376 kB		 13 B
6 B
react-provider
FluentProvider		 15.147 kB
5.573 kB		 15.16 kB
5.58 kB		 13 B
7 B
react-slider
RangedSlider		 41.41 kB
11.97 kB		 41.423 kB
11.975 kB		 13 B
5 B
react-slider
Slider		 34.788 kB
10.855 kB		 34.801 kB
10.861 kB		 13 B
6 B
react-switch
Switch		 26.602 kB
8.557 kB		 26.615 kB
8.562 kB		 13 B
5 B
react-text
Text - Default		 11.338 kB
4.418 kB		 11.351 kB
4.424 kB		 13 B
6 B
react-text
Text - Wrappers		 14.407 kB
4.724 kB		 14.42 kB
4.729 kB		 13 B
5 B
react-tooltip
Tooltip		 45.543 kB
15.541 kB		 45.556 kB
15.549 kB		 13 B
8 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-make-styles
makeStaticStyles (runtime)		 7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)		 22.175 kB
8.366 kB
react-make-styles
makeStyles + mergeClasses (build time)		 2.558 kB
1.204 kB
react-portal
Portal		 6.725 kB
2.237 kB
react-positioning
usePopper		 23.145 kB
7.942 kB
react-utilities
SSRProvider		 213 B
170 B
🤖 This report was generated against 9e5944cda212166fd31791ee438a69b4d1dd595c

@ling1726 ling1726 enabled auto-merge (squash) October 26, 2021 08:23
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f63d60:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration
wispy-tree-8dds7 Issue #20344

@size-auditor
Copy link

size-auditor bot commented Oct 26, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 6f07e52e76aae9e2ae7e59ede73f9265a36b9970 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 709 803 5000
BaseButton mount 767 785 5000
Breadcrumb mount 2295 2266 1000
ButtonNext mount 437 432 5000
Checkbox mount 3645 1324 5000
CheckboxBase mount 1113 1084 5000
ChoiceGroup mount 4006 4012 5000
ComboBox mount 913 859 1000
CommandBar mount 8327 8820 1000
ContextualMenu mount 5518 5521 1000
DefaultButton mount 972 978 5000
DetailsRow mount 3194 3063 5000
DetailsRowFast mount 3226 3256 5000
DetailsRowNoStyles mount 2903 2955 5000
Dialog mount 2149 2034 1000
DocumentCardTitle mount 144 131 1000
Dropdown mount 2752 2728 5000
FluentProviderNext mount 2879 2857 5000
FluentProviderWithTheme mount 180 157 10
FluentProviderWithTheme virtual-rerender 93 73 10
FluentProviderWithTheme virtual-rerender-with-unmount 200 213 10
FocusTrapZone mount 1556 1569 5000
FocusZone mount 1509 1545 5000
IconButton mount 1498 1519 5000
Label mount 307 296 5000
Layer mount 2437 2508 5000
Link mount 425 433 5000
MakeStyles mount 1575 1598 50000
MenuButton mount 1287 1249 5000
MessageBar mount 1762 1725 5000
Nav mount 2672 2767 1000
OverflowSet mount 941 947 5000
Panel mount 2136 1965 1000
Persona mount 720 739 1000
Pivot mount 1203 1231 1000
PrimaryButton mount 1000 1092 5000
Rating mount 6451 6485 5000
SearchBox mount 1166 995 5000
Shimmer mount 2107 2167 5000
Slider mount 1570 1726 5000
SpinButton mount 4283 4200 5000
Spinner mount 366 375 5000
SplitButton mount 2681 2629 5000
Stack mount 398 393 5000
StackWithIntrinsicChildren mount 1494 1481 5000
StackWithTextChildren mount 4038 3955 5000
SwatchColorPicker mount 8879 8874 5000
Tabs mount 1089 1234 1000
TagPicker mount 2210 2270 5000
TeachingBubble mount 10998 10766 5000
Text mount 338 375 5000
TextField mount 1216 1118 5000
ThemeProvider mount 998 998 5000
ThemeProvider virtual-rerender 542 529 5000
ThemeProvider virtual-rerender-with-unmount 1553 1574 5000
Toggle mount 699 653 5000
buttonNative mount 117 125 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AlertMinimalPerf.default 237 244 0.97:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 484 161 3.01:1
ChatDuplicateMessagesPerf.default 771 267 2.89:1
TableMinimalPerf.default 374 331 1.13:1
FlexMinimalPerf.default 256 237 1.08:1
CardMinimalPerf.default 490 464 1.06:1
FormMinimalPerf.default 357 336 1.06:1
DialogMinimalPerf.default 651 622 1.05:1
AttachmentMinimalPerf.default 144 139 1.04:1
AttachmentSlotsPerf.default 948 918 1.03:1
ChatWithPopoverPerf.default 326 318 1.03:1
LayoutMinimalPerf.default 315 305 1.03:1
ListWith60ListItems.default 561 544 1.03:1
PortalMinimalPerf.default 153 149 1.03:1
SliderMinimalPerf.default 1503 1459 1.03:1
TableManyItemsPerf.default 1642 1591 1.03:1
TextMinimalPerf.default 302 292 1.03:1
AccordionMinimalPerf.default 132 130 1.02:1
DropdownMinimalPerf.default 2727 2672 1.02:1
EmbedMinimalPerf.default 3665 3593 1.02:1
InputMinimalPerf.default 1123 1105 1.02:1
CustomToolbarPrototype.default 3456 3383 1.02:1
ToolbarMinimalPerf.default 766 753 1.02:1
BoxMinimalPerf.default 304 301 1.01:1
ChatMinimalPerf.default 568 560 1.01:1
DatepickerMinimalPerf.default 4751 4720 1.01:1
MenuMinimalPerf.default 723 714 1.01:1
SkeletonMinimalPerf.default 308 306 1.01:1
TooltipMinimalPerf.default 879 873 1.01:1
ButtonOverridesMissPerf.default 1471 1473 1:1
ButtonSlotsPerf.default 479 479 1:1
DropdownManyItemsPerf.default 570 571 1:1
HeaderMinimalPerf.default 304 303 1:1
ListCommonPerf.default 553 552 1:1
LoaderMinimalPerf.default 605 605 1:1
PopupMinimalPerf.default 508 510 1:1
ProviderMergeThemesPerf.default 1466 1466 1:1
ProviderMinimalPerf.default 961 960 1:1
RadioGroupMinimalPerf.default 383 384 1:1
SplitButtonMinimalPerf.default 3658 3660 1:1
AnimationMinimalPerf.default 356 360 0.99:1
ButtonMinimalPerf.default 146 148 0.99:1
CheckboxMinimalPerf.default 2264 2295 0.99:1
ImageMinimalPerf.default 321 324 0.99:1
ItemLayoutMinimalPerf.default 1033 1044 0.99:1
ListMinimalPerf.default 426 429 0.99:1
SegmentMinimalPerf.default 290 292 0.99:1
CarouselMinimalPerf.default 389 395 0.98:1
StatusMinimalPerf.default 567 577 0.98:1
IconMinimalPerf.default 537 550 0.98:1
HeaderSlotsPerf.default 616 632 0.97:1
TreeMinimalPerf.default 666 687 0.97:1
VideoMinimalPerf.default 538 557 0.97:1
DividerMinimalPerf.default 301 312 0.96:1
MenuButtonMinimalPerf.default 1368 1431 0.96:1
RosterPerf.default 990 1030 0.96:1
ReactionMinimalPerf.default 315 328 0.96:1
TextAreaMinimalPerf.default 438 456 0.96:1
AvatarMinimalPerf.default 160 169 0.95:1
RefMinimalPerf.default 214 225 0.95:1
ListNestedPerf.default 472 520 0.91:1
GridMinimalPerf.default 266 296 0.9:1
LabelMinimalPerf.default 294 344 0.85:1

@ling1726 ling1726 merged commit b5b7401 into microsoft:master Oct 26, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@ling1726
fix(getNativeElementProps): Add support for onAuxClick (microsoft#2…
3a11f2c 
…0343)

* fix(getNativeElementPrps): Add support for `onAuxClick`

Adds support for the `onAuxClick` native handler

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsunderhus bsunderhus bsunderhus approved these changes

Assignees

@bsunderhus bsunderhus

Labels
Component: Button
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button: Does not support onAuxClick
4 participants
@ling1726 @fabricteam @bsunderhus @msft-fluent-ui-bot