-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semibold Author in compact ChatMessages #20419
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2fa6e29384ee32c3d5bb0f84ea05c2ad648c37f5 (build) |
📊 Bundle size report🤖 This report was generated against 2fa6e29384ee32c3d5bb0f84ea05c2ad648c37f5 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3d0a2fa:
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 979 | 985 | 5000 | |
BaseButton | mount | 966 | 957 | 5000 | |
Breadcrumb | mount | 2657 | 2745 | 1000 | |
ButtonNext | mount | 533 | 522 | 5000 | |
Checkbox | mount | 1559 | 1571 | 5000 | |
CheckboxBase | mount | 1346 | 1362 | 5000 | |
ChoiceGroup | mount | 4905 | 4859 | 5000 | |
ComboBox | mount | 1030 | 1016 | 1000 | |
CommandBar | mount | 10448 | 10436 | 1000 | |
ContextualMenu | mount | 8730 | 8836 | 1000 | |
DefaultButton | mount | 1195 | 1206 | 5000 | |
DetailsRow | mount | 3909 | 3803 | 5000 | |
DetailsRowFast | mount | 3900 | 3842 | 5000 | |
DetailsRowNoStyles | mount | 3743 | 3655 | 5000 | |
Dialog | mount | 2674 | 2626 | 1000 | |
DocumentCardTitle | mount | 176 | 165 | 1000 | |
Dropdown | mount | 3375 | 3320 | 5000 | |
FluentProviderNext | mount | 4202 | 4247 | 5000 | |
FluentProviderWithTheme | mount | 243 | 246 | 10 | |
FluentProviderWithTheme | virtual-rerender | 109 | 104 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 292 | 278 | 10 | |
FocusTrapZone | mount | 1886 | 1883 | 5000 | |
FocusZone | mount | 1853 | 1905 | 5000 | |
IconButton | mount | 1842 | 1865 | 5000 | |
Label | mount | 384 | 368 | 5000 | |
Layer | mount | 3057 | 3049 | 5000 | |
Link | mount | 519 | 493 | 5000 | |
MakeStyles | mount | 1895 | 1899 | 50000 | |
MenuButton | mount | 1540 | 1531 | 5000 | |
MessageBar | mount | 2091 | 2119 | 5000 | |
Nav | mount | 3516 | 3380 | 1000 | |
OverflowSet | mount | 1175 | 1143 | 5000 | |
Panel | mount | 2652 | 2570 | 1000 | |
Persona | mount | 889 | 880 | 1000 | |
Pivot | mount | 1516 | 1467 | 1000 | |
PrimaryButton | mount | 1357 | 1377 | 5000 | |
Rating | mount | 8071 | 7926 | 5000 | |
SearchBox | mount | 1433 | 1357 | 5000 | |
Shimmer | mount | 2641 | 2570 | 5000 | |
Slider | mount | 2041 | 2046 | 5000 | |
SpinButton | mount | 5254 | 5188 | 5000 | |
Spinner | mount | 445 | 466 | 5000 | |
SplitButton | mount | 3361 | 3311 | 5000 | |
Stack | mount | 550 | 533 | 5000 | |
StackWithIntrinsicChildren | mount | 1773 | 1778 | 5000 | |
StackWithTextChildren | mount | 4808 | 4837 | 5000 | |
SwatchColorPicker | mount | 10939 | 10871 | 5000 | |
TagPicker | mount | 2821 | 2781 | 5000 | |
TeachingBubble | mount | 13436 | 13532 | 5000 | |
Text | mount | 448 | 444 | 5000 | |
TextField | mount | 1454 | 1431 | 5000 | |
ThemeProvider | mount | 1231 | 1251 | 5000 | |
ThemeProvider | virtual-rerender | 618 | 644 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1954 | 1909 | 5000 | |
Toggle | mount | 834 | 849 | 5000 | |
buttonNative | mount | 136 | 138 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AttachmentMinimalPerf.default | 173 | 154 | 1.12:1 |
ChatDuplicateMessagesPerf.default | 333 | 305 | 1.09:1 |
ChatWithPopoverPerf.default | 427 | 391 | 1.09:1 |
DividerMinimalPerf.default | 393 | 362 | 1.09:1 |
AvatarMinimalPerf.default | 219 | 203 | 1.08:1 |
TreeWith60ListItems.default | 201 | 188 | 1.07:1 |
CarouselMinimalPerf.default | 502 | 474 | 1.06:1 |
InputMinimalPerf.default | 1375 | 1311 | 1.05:1 |
PortalMinimalPerf.default | 196 | 187 | 1.05:1 |
SkeletonMinimalPerf.default | 367 | 351 | 1.05:1 |
ChatMinimalPerf.default | 693 | 669 | 1.04:1 |
MenuMinimalPerf.default | 885 | 853 | 1.04:1 |
SliderMinimalPerf.default | 1768 | 1699 | 1.04:1 |
AlertMinimalPerf.default | 285 | 276 | 1.03:1 |
DatepickerMinimalPerf.default | 5706 | 5557 | 1.03:1 |
DropdownManyItemsPerf.default | 729 | 706 | 1.03:1 |
DropdownMinimalPerf.default | 3307 | 3201 | 1.03:1 |
HeaderMinimalPerf.default | 382 | 371 | 1.03:1 |
LabelMinimalPerf.default | 399 | 387 | 1.03:1 |
MenuButtonMinimalPerf.default | 1709 | 1658 | 1.03:1 |
CheckboxMinimalPerf.default | 2918 | 2863 | 1.02:1 |
DialogMinimalPerf.default | 778 | 763 | 1.02:1 |
ReactionMinimalPerf.default | 390 | 383 | 1.02:1 |
RefMinimalPerf.default | 247 | 241 | 1.02:1 |
SplitButtonMinimalPerf.default | 4421 | 4331 | 1.02:1 |
StatusMinimalPerf.default | 697 | 682 | 1.02:1 |
TableMinimalPerf.default | 420 | 413 | 1.02:1 |
CustomToolbarPrototype.default | 4285 | 4189 | 1.02:1 |
AccordionMinimalPerf.default | 159 | 157 | 1.01:1 |
AnimationMinimalPerf.default | 417 | 414 | 1.01:1 |
HeaderSlotsPerf.default | 763 | 752 | 1.01:1 |
ProviderMinimalPerf.default | 1164 | 1153 | 1.01:1 |
TextMinimalPerf.default | 360 | 358 | 1.01:1 |
EmbedMinimalPerf.default | 4429 | 4413 | 1:1 |
ImageMinimalPerf.default | 376 | 376 | 1:1 |
PopupMinimalPerf.default | 612 | 610 | 1:1 |
RadioGroupMinimalPerf.default | 450 | 450 | 1:1 |
TableManyItemsPerf.default | 1967 | 1968 | 1:1 |
ToolbarMinimalPerf.default | 965 | 963 | 1:1 |
VideoMinimalPerf.default | 632 | 632 | 1:1 |
AttachmentSlotsPerf.default | 1100 | 1112 | 0.99:1 |
ButtonMinimalPerf.default | 170 | 171 | 0.99:1 |
ButtonOverridesMissPerf.default | 1768 | 1785 | 0.99:1 |
ButtonSlotsPerf.default | 557 | 564 | 0.99:1 |
FormMinimalPerf.default | 417 | 422 | 0.99:1 |
ItemLayoutMinimalPerf.default | 1232 | 1240 | 0.99:1 |
LayoutMinimalPerf.default | 374 | 376 | 0.99:1 |
ListMinimalPerf.default | 528 | 532 | 0.99:1 |
ProviderMergeThemesPerf.default | 1771 | 1786 | 0.99:1 |
BoxMinimalPerf.default | 354 | 362 | 0.98:1 |
CardMinimalPerf.default | 560 | 573 | 0.98:1 |
FlexMinimalPerf.default | 281 | 290 | 0.97:1 |
ListCommonPerf.default | 616 | 637 | 0.97:1 |
ListNestedPerf.default | 562 | 581 | 0.97:1 |
LoaderMinimalPerf.default | 722 | 742 | 0.97:1 |
TooltipMinimalPerf.default | 1036 | 1072 | 0.97:1 |
ListWith60ListItems.default | 667 | 696 | 0.96:1 |
RosterPerf.default | 1200 | 1246 | 0.96:1 |
SegmentMinimalPerf.default | 350 | 365 | 0.96:1 |
IconMinimalPerf.default | 599 | 624 | 0.96:1 |
TreeMinimalPerf.default | 798 | 827 | 0.96:1 |
TextAreaMinimalPerf.default | 500 | 535 | 0.93:1 |
GridMinimalPerf.default | 340 | 368 | 0.92:1 |
Co-authored-by: ling1726 <lingfan.gao@microsoft.com>
* Semibold Author in compact ChatMessages * Add changelog entry * Improve changelog entry Co-authored-by: ling1726 <lingfan.gao@microsoft.com> Co-authored-by: ling1726 <lingfan.gao@microsoft.com>
Revert changes from #19048 as design has changed back.
Reusing screenshots from above PR: