Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(make-styles-webpack-loader): support resolve plugins #20559

Merged
merged 4 commits into from
Nov 9, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Nov 9, 2021

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Adds the resolve plugins from the current webpack compliation object to
enhancedResolve just like aliases are.

This will support third party resolve plugins like ts-config-paths-webpack-plugin

Focus areas to test

(optional)

Adds the resolve plugins from the current webpack compliation object to
`enhancedResolve` just like aliases are.

This will support third party resolve plugins like [ts-config-paths-webpack-plugin](https://github.com/dividab/tsconfig-paths-webpack-plugin)
@fabricteam
Copy link
Collaborator

fabricteam commented Nov 9, 2021

📊 Bundle size report

🤖 This report was generated against b4955b47d766ad8085f86d86ffe7b5add590888b

@size-auditor
Copy link

size-auditor bot commented Nov 9, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b4955b47d766ad8085f86d86ffe7b5add590888b (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 9, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 977 977 5000
BaseButton mount 951 963 5000
Breadcrumb mount 2814 2773 1000
ButtonNext mount 539 550 5000
Checkbox mount 1581 1630 5000
CheckboxBase mount 1335 1369 5000
ChoiceGroup mount 4997 4910 5000
ComboBox mount 1026 1044 1000
CommandBar mount 10703 10816 1000
ContextualMenu mount 8854 8891 1000
DefaultButton mount 1192 1178 5000
DetailsRow mount 4040 3903 5000
DetailsRowFast mount 4112 3920 5000
DetailsRowNoStyles mount 3783 3789 5000
Dialog mount 2722 2700 1000
DocumentCardTitle mount 175 165 1000
Dropdown mount 3426 3398 5000
FluentProviderNext mount 4058 4057 5000
FluentProviderWithTheme mount 241 235 10
FluentProviderWithTheme virtual-rerender 95 110 10
FluentProviderWithTheme virtual-rerender-with-unmount 269 305 10
FocusTrapZone mount 1878 1902 5000
FocusZone mount 1903 1898 5000
IconButton mount 1836 1873 5000
Label mount 371 384 5000
Layer mount 3131 3172 5000
Link mount 499 505 5000
MakeStyles mount 1939 1971 50000
MenuButton mount 1549 1561 5000
MessageBar mount 2133 2103 5000
Nav mount 3568 3433 1000
OverflowSet mount 1185 1192 5000
Panel mount 2560 2654 1000
Persona mount 894 868 1000
Pivot mount 1493 1502 1000
PrimaryButton mount 1359 1376 5000
Rating mount 8019 8098 5000
SearchBox mount 1356 1371 5000
Shimmer mount 2768 2655 5000
Slider mount 2033 2059 5000
SpinButton mount 5387 5281 5000
Spinner mount 461 456 5000
SplitButton mount 3340 3285 5000
Stack mount 552 545 5000
StackWithIntrinsicChildren mount 1804 1764 5000
StackWithTextChildren mount 4932 4878 5000
SwatchColorPicker mount 11028 10856 5000
TagPicker mount 2744 2772 5000
TeachingBubble mount 13859 13932 5000
Text mount 451 470 5000
TextField mount 1452 1488 5000
ThemeProvider mount 1260 1266 5000
ThemeProvider virtual-rerender 645 671 5000
ThemeProvider virtual-rerender-with-unmount 2013 1953 5000
Toggle mount 881 849 5000
buttonNative mount 141 142 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 195 175 1.11:1
AttachmentMinimalPerf.default 170 158 1.08:1
LabelMinimalPerf.default 430 402 1.07:1
RadioGroupMinimalPerf.default 474 443 1.07:1
TableMinimalPerf.default 442 415 1.07:1
AlertMinimalPerf.default 290 274 1.06:1
AnimationMinimalPerf.default 446 421 1.06:1
ChatDuplicateMessagesPerf.default 324 306 1.06:1
ChatWithPopoverPerf.default 413 390 1.06:1
TreeWith60ListItems.default 198 186 1.06:1
AttachmentSlotsPerf.default 1154 1104 1.05:1
CarouselMinimalPerf.default 504 484 1.04:1
DividerMinimalPerf.default 375 359 1.04:1
FlexMinimalPerf.default 304 292 1.04:1
SkeletonMinimalPerf.default 378 362 1.04:1
TooltipMinimalPerf.default 1109 1062 1.04:1
TreeMinimalPerf.default 863 827 1.04:1
ChatMinimalPerf.default 692 669 1.03:1
PopupMinimalPerf.default 640 620 1.03:1
ReactionMinimalPerf.default 390 380 1.03:1
BoxMinimalPerf.default 377 369 1.02:1
CheckboxMinimalPerf.default 2924 2861 1.02:1
HeaderMinimalPerf.default 386 380 1.02:1
ListWith60ListItems.default 685 671 1.02:1
IconMinimalPerf.default 642 632 1.02:1
TextAreaMinimalPerf.default 523 514 1.02:1
AvatarMinimalPerf.default 201 199 1.01:1
ButtonOverridesMissPerf.default 1877 1861 1.01:1
FormMinimalPerf.default 410 406 1.01:1
GridMinimalPerf.default 354 352 1.01:1
LoaderMinimalPerf.default 732 727 1.01:1
PortalMinimalPerf.default 187 186 1.01:1
SegmentMinimalPerf.default 374 372 1.01:1
SplitButtonMinimalPerf.default 4498 4436 1.01:1
ToolbarMinimalPerf.default 977 966 1.01:1
DatepickerMinimalPerf.default 5880 5874 1:1
EmbedMinimalPerf.default 4470 4485 1:1
LayoutMinimalPerf.default 394 395 1:1
ListCommonPerf.default 667 667 1:1
ListMinimalPerf.default 547 545 1:1
ListNestedPerf.default 583 583 1:1
MenuMinimalPerf.default 898 899 1:1
ProviderMergeThemesPerf.default 1831 1826 1:1
ProviderMinimalPerf.default 1176 1178 1:1
VideoMinimalPerf.default 660 662 1:1
ButtonSlotsPerf.default 583 588 0.99:1
DropdownMinimalPerf.default 3309 3326 0.99:1
HeaderSlotsPerf.default 792 800 0.99:1
InputMinimalPerf.default 1373 1382 0.99:1
MenuButtonMinimalPerf.default 1723 1734 0.99:1
SliderMinimalPerf.default 1774 1788 0.99:1
StatusMinimalPerf.default 695 699 0.99:1
CustomToolbarPrototype.default 4280 4314 0.99:1
DialogMinimalPerf.default 787 806 0.98:1
DropdownManyItemsPerf.default 724 740 0.98:1
ImageMinimalPerf.default 387 396 0.98:1
TableManyItemsPerf.default 1961 2000 0.98:1
CardMinimalPerf.default 576 592 0.97:1
RosterPerf.default 1203 1243 0.97:1
AccordionMinimalPerf.default 161 168 0.96:1
ItemLayoutMinimalPerf.default 1264 1311 0.96:1
TextMinimalPerf.default 394 412 0.96:1
RefMinimalPerf.default 249 262 0.95:1

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bc41537:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@ling1726 ling1726 merged commit 165eff4 into microsoft:master Nov 9, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
…20559)

* feat(make-styles-webpack-loader): support resolve plugins

Adds the resolve plugins from the current webpack compliation object to
`enhancedResolve` just like aliases are.

This will support third party resolve plugins like [ts-config-paths-webpack-plugin](https://github.com/dividab/tsconfig-paths-webpack-plugin)

* Change files

* add test

* add correct comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants