docs: notes on migration to @fluentui/react-components@9.0.0-rc.1
#21629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 33092ce:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4a28b5a69d0e6cf53c19c5e93bc93465f9b8a132 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 855 | 836 | 5000 | |
| BaseButton | mount | 973 | 966 | 5000 | |
| Breadcrumb | mount | 2716 | 2779 | 1000 | |
| ButtonNext | mount | 508 | 495 | 5000 | |
| Checkbox | mount | 1605 | 1609 | 5000 | |
| CheckboxBase | mount | 1342 | 1358 | 5000 | |
| ChoiceGroup | mount | 4891 | 5057 | 5000 | |
| ComboBox | mount | 1042 | 1024 | 1000 | |
| CommandBar | mount | 10671 | 10423 | 1000 | |
| ContextualMenu | mount | 8562 | 8570 | 1000 | |
| DefaultButton | mount | 1158 | 1160 | 5000 | |
| DetailsRow | mount | 3825 | 3849 | 5000 | |
| DetailsRowFast | mount | 3869 | 3870 | 5000 | |
| DetailsRowNoStyles | mount | 3699 | 3733 | 5000 | |
| Dialog | mount | 3067 | 3045 | 1000 | |
| DocumentCardTitle | mount | 201 | 192 | 1000 | |
| Dropdown | mount | 3300 | 3294 | 5000 | |
| FluentProviderNext | mount | 1933 | 1957 | 5000 | |
| FluentProviderWithTheme | mount | 166 | 173 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 117 | 117 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 194 | 207 | 10 | |
| FocusTrapZone | mount | 1855 | 1842 | 5000 | |
| FocusZone | mount | 1814 | 1923 | 5000 | |
| IconButton | mount | 1779 | 1795 | 5000 | |
| Label | mount | 388 | 376 | 5000 | |
| Layer | mount | 3068 | 3059 | 5000 | |
| Link | mount | 552 | 506 | 5000 | |
| MakeStyles | mount | 1764 | 1742 | 50000 | |
| MenuButton | mount | 1521 | 1563 | 5000 | |
| MessageBar | mount | 2139 | 2024 | 5000 | |
| Nav | mount | 3361 | 3338 | 1000 | |
| OverflowSet | mount | 1138 | 1201 | 5000 | |
| Panel | mount | 2592 | 2651 | 1000 | |
| Persona | mount | 873 | 900 | 1000 | |
| Pivot | mount | 1491 | 1460 | 1000 | |
| PrimaryButton | mount | 1372 | 1336 | 5000 | |
| Rating | mount | 7972 | 7778 | 5000 | |
| SearchBox | mount | 1376 | 1342 | 5000 | |
| Shimmer | mount | 2600 | 2592 | 5000 | |
| Slider | mount | 2032 | 2032 | 5000 | |
| SpinButton | mount | 5113 | 5119 | 5000 | |
| Spinner | mount | 483 | 488 | 5000 | |
| SplitButton | mount | 3177 | 3191 | 5000 | |
| Stack | mount | 572 | 559 | 5000 | |
| StackWithIntrinsicChildren | mount | 2312 | 2390 | 5000 | |
| StackWithTextChildren | mount | 5396 | 5326 | 5000 | |
| SwatchColorPicker | mount | 11563 | 11604 | 5000 | |
| TagPicker | mount | 2635 | 2695 | 5000 | |
| TeachingBubble | mount | 13473 | 13527 | 5000 | |
| Text | mount | 479 | 462 | 5000 | |
| TextField | mount | 1480 | 1432 | 5000 | |
| ThemeProvider | mount | 1240 | 1242 | 5000 | |
| ThemeProvider | virtual-rerender | 654 | 679 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1948 | 1956 | 5000 | |
| Toggle | mount | 847 | 857 | 5000 | |
| buttonNative | mount | 161 | 164 | 5000 |
Perf Analysis (@fluentui/react-northstar)
layershifter
commented
Feb 8, 2022
…ocus outline functions due to the removal of functions in makeStyles, the removal of the mergeThemes utility, the change to use resizable icons with a default set via fontSize, and changes in the button components.
Hotell
reviewed
Feb 9, 2022
| @@ -0,0 +1,321 @@ | |||
| # Notes on migration to `@fluentui/react-components@9.0.0-rc.1` | |||
There was a problem hiding this comment.
can we specify what version migration are we talking? ( based on previous convo it should be from Beta to RC AFAIR)
There was a problem hiding this comment.
Suggested change
| # Notes on migration to `@fluentui/react-components@9.0.0-rc.1` | |
| # Migration notes from `@fluentui/react-components@9.0.0-beta.5`to `@fluentui/react-components@9.0.0-rc.1` |
There was a problem hiding this comment.
Good call, added "from `9.0.0-beta.5`"
khmakoto
approved these changes
Feb 9, 2022
ling1726
reviewed
Feb 10, 2022
Co-authored-by: ling1726 <lingfangao@hotmail.com>
ling1726
approved these changes
Feb 10, 2022
JustSlone
approved these changes
Feb 10, 2022
tudorpopams
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migration notes for
@fluentui/react-components@9.0.0-rc.1to help customers with the upgrade.The goal is to describe breaking changes and migration path for them.