Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@fluentui/theme missing a ./lib/createTheme export #22006

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

dzearing
Copy link
Member

@dzearing dzearing commented Mar 8, 2022

It turns out some repos are consuming the v8 @fluentui/theme through v7 @uifabric/styling package references via pinning to disregard semver.

This is a problem in itself, but was working until exports maps were introduced. When @uifabric/styling imports createTheme, it gets it from @fluentui/theme/lib/createTheme which now breaks in a webpack 5 environment. v8 packages do not use this theme, so separately we need to remove v7, but to unblock the partial upgrade in 1JS, we need to add this entry.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 06c438e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 8, 2022

📊 Bundle size report

🤖 This report was generated against 4c3dad268cac06f9b4d38c64b3fa41e95a6ac069

@size-auditor
Copy link

size-auditor bot commented Mar 8, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4c3dad268cac06f9b4d38c64b3fa41e95a6ac069 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 8, 2022

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 382 396 10 Possible regression
SpinButton mount 4588 4589 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 960 943 5000
BaseButton mount 977 976 5000
Breadcrumb mount 2516 2610 1000
ButtonNext mount 578 596 5000
Checkbox mount 1452 1501 5000
CheckboxBase mount 1183 1283 5000
ChoiceGroup mount 4311 4248 5000
ComboBox mount 1034 1034 1000
CommandBar mount 9229 9174 1000
ContextualMenu mount 14499 14658 1000
DefaultButton mount 1177 1135 5000
DetailsRow mount 3561 3493 5000
DetailsRowFast mount 3485 3435 5000
DetailsRowNoStyles mount 3372 3316 5000
Dialog mount 2085 2104 1000
DocumentCardTitle mount 315 333 1000
Dropdown mount 3030 3029 5000
FluentProviderNext mount 1908 1905 5000
FluentProviderWithTheme mount 305 284 10
FluentProviderWithTheme virtual-rerender 285 278 10
FluentProviderWithTheme virtual-rerender-with-unmount 382 396 10 Possible regression
FocusTrapZone mount 1658 1754 5000
FocusZone mount 1775 1670 5000
IconButton mount 1686 1704 5000
Label mount 447 493 5000
Layer mount 2768 2764 5000
Link mount 581 599 5000
MakeStyles mount 1600 1613 50000
MenuButton mount 1495 1506 5000
MessageBar mount 2020 2009 5000
Nav mount 3021 3062 1000
OverflowSet mount 1149 1154 5000
Panel mount 1993 2049 1000
Persona mount 947 910 1000
Pivot mount 1452 1444 1000
PrimaryButton mount 1344 1328 5000
Rating mount 6772 6795 5000
SearchBox mount 1287 1312 5000
Shimmer mount 2371 2367 5000
Slider mount 1866 1867 5000
SpinButton mount 4588 4589 5000 Possible regression
Spinner mount 565 560 5000
SplitButton mount 2968 2915 5000
Stack mount 615 638 5000
StackWithIntrinsicChildren mount 2184 2208 5000
StackWithTextChildren mount 4607 4719 5000
SwatchColorPicker mount 10220 10165 5000
TagPicker mount 2517 2468 5000
TeachingBubble mount 89922 52583 5000
Text mount 537 579 5000
TextField mount 1442 1300 5000
ThemeProvider mount 1195 1156 5000
ThemeProvider virtual-rerender 767 774 5000
ThemeProvider virtual-rerender-with-unmount 1794 1709 5000
Toggle mount 898 883 5000
buttonNative mount 288 304 5000

Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was a way to add comments in package.json...without that, there's a bigger risk of these references to nonexistent files being deleted later :(

@dzearing dzearing merged commit 3e2137c into microsoft:master Mar 8, 2022
@dzearing dzearing deleted the dzearing/more-exports branch March 8, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants