SpinButton updates from accessibility testing #22489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor styling and story updates based on accessibility testing.
Adds default, English, labels to the increment and decrement buttons of SpinButton. This provides a default description for assistive tech users. This commit implements a new prop, `strings` per RFC microsoft#19258. Default values are provided for English and the strings support a token, `{step}` that will be replaced with the value of the `step` prop. The `{step}` token may be omitted. All string keys are required but invididual labels may be overridden by passing the `aria-label` prop to a slot.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 725a5bf:
|
📊 Bundle size report
🤖 This report was generated against 399a179957a37480093eaaf5b0ddfb37a97ad7a8 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 399a179957a37480093eaaf5b0ddfb37a97ad7a8 (build) |
khmakoto
reviewed
Apr 13, 2022
packages/react-spinbutton/src/components/SpinButton/useSpinButton.tsx
Outdated
Show resolved
Hide resolved
packages/react-spinbutton/src/components/SpinButton/useSpinButton.tsx
Outdated
Show resolved
Hide resolved
khmakoto
approved these changes
Apr 15, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* react-spinbutton: a11y updates Minor styling and story updates based on accessibility testing. * react-spinbutton: add labels to spinner buttons Adds default, English, labels to the increment and decrement buttons of SpinButton. This provides a default description for assistive tech users. This commit implements a new prop, `strings` per RFC microsoft#19258. Default values are provided for English and the strings support a token, `{step}` that will be replaced with the value of the `step` prop. The `{step}` token may be omitted. All string keys are required but invididual labels may be overridden by passing the `aria-label` prop to a slot. * react-spinbutton: update API snapshot * react-spinbutton: remove commented out TODOs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
New Behavior
stringsprop has been added to SpinButton allowing labels be applied to the increment and decrement buttons. These strings support a token,{step}, that will be replaced with the value of thestepprop when present in the string. This allows the labels to be localized as needed. By default the English localization is included.Related Issue(s)
#22307