The outline and the filled part of MicPulseOff were both filled. Fixing. #23021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-fluent-ui-bot
added
the
Fluent UI react-northstar (v0)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fbf8388:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9c431fb57b2c1ea13558e81e24ec7f3498359f2f (build) |
📊 Bundle size report🤖 This report was generated against 9c431fb57b2c1ea13558e81e24ec7f3498359f2f |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ListMinimalPerf.default | 536 | 485 | 1.11:1 |
| AvatarMinimalPerf.default | 203 | 186 | 1.09:1 |
| GridMinimalPerf.default | 337 | 314 | 1.07:1 |
| ListNestedPerf.default | 588 | 551 | 1.07:1 |
| AlertMinimalPerf.default | 273 | 258 | 1.06:1 |
| ChatDuplicateMessagesPerf.default | 300 | 283 | 1.06:1 |
| PortalMinimalPerf.default | 180 | 170 | 1.06:1 |
| VideoMinimalPerf.default | 669 | 633 | 1.06:1 |
| LoaderMinimalPerf.default | 717 | 681 | 1.05:1 |
| RadioGroupMinimalPerf.default | 463 | 439 | 1.05:1 |
| TextAreaMinimalPerf.default | 509 | 485 | 1.05:1 |
| ChatMinimalPerf.default | 756 | 729 | 1.04:1 |
| ReactionMinimalPerf.default | 379 | 364 | 1.04:1 |
| SegmentMinimalPerf.default | 370 | 356 | 1.04:1 |
| IconMinimalPerf.default | 614 | 590 | 1.04:1 |
| AttachmentMinimalPerf.default | 161 | 156 | 1.03:1 |
| ButtonSlotsPerf.default | 565 | 549 | 1.03:1 |
| EmbedMinimalPerf.default | 4154 | 4040 | 1.03:1 |
| LayoutMinimalPerf.default | 360 | 351 | 1.03:1 |
| ProviderMinimalPerf.default | 418 | 406 | 1.03:1 |
| TreeMinimalPerf.default | 834 | 811 | 1.03:1 |
| TreeWith60ListItems.default | 175 | 170 | 1.03:1 |
| AnimationMinimalPerf.default | 557 | 544 | 1.02:1 |
| BoxMinimalPerf.default | 347 | 340 | 1.02:1 |
| DialogMinimalPerf.default | 796 | 781 | 1.02:1 |
| LabelMinimalPerf.default | 387 | 378 | 1.02:1 |
| PopupMinimalPerf.default | 645 | 630 | 1.02:1 |
| TableManyItemsPerf.default | 1995 | 1963 | 1.02:1 |
| ButtonMinimalPerf.default | 163 | 162 | 1.01:1 |
| CardMinimalPerf.default | 575 | 572 | 1.01:1 |
| CheckboxMinimalPerf.default | 2792 | 2771 | 1.01:1 |
| DropdownManyItemsPerf.default | 694 | 684 | 1.01:1 |
| DropdownMinimalPerf.default | 3087 | 3054 | 1.01:1 |
| InputMinimalPerf.default | 1285 | 1271 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 1169 | 1158 | 1.01:1 |
| SkeletonMinimalPerf.default | 350 | 346 | 1.01:1 |
| StatusMinimalPerf.default | 684 | 676 | 1.01:1 |
| TextMinimalPerf.default | 345 | 343 | 1.01:1 |
| ChatWithPopoverPerf.default | 387 | 388 | 1:1 |
| DatepickerMinimalPerf.default | 6343 | 6316 | 1:1 |
| DividerMinimalPerf.default | 349 | 349 | 1:1 |
| ImageMinimalPerf.default | 362 | 363 | 1:1 |
| MenuMinimalPerf.default | 868 | 870 | 1:1 |
| SplitButtonMinimalPerf.default | 4448 | 4443 | 1:1 |
| TableMinimalPerf.default | 404 | 403 | 1:1 |
| ButtonOverridesMissPerf.default | 1530 | 1539 | 0.99:1 |
| FlexMinimalPerf.default | 272 | 274 | 0.99:1 |
| FormMinimalPerf.default | 382 | 384 | 0.99:1 |
| HeaderSlotsPerf.default | 730 | 736 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1753 | 1773 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1305 | 1323 | 0.99:1 |
| RefMinimalPerf.default | 244 | 246 | 0.99:1 |
| SliderMinimalPerf.default | 1712 | 1726 | 0.99:1 |
| CustomToolbarPrototype.default | 2801 | 2818 | 0.99:1 |
| ToolbarMinimalPerf.default | 937 | 944 | 0.99:1 |
| HeaderMinimalPerf.default | 333 | 341 | 0.98:1 |
| ListCommonPerf.default | 622 | 633 | 0.98:1 |
| AttachmentSlotsPerf.default | 1110 | 1139 | 0.97:1 |
| CarouselMinimalPerf.default | 475 | 490 | 0.97:1 |
| TooltipMinimalPerf.default | 1128 | 1166 | 0.97:1 |
| RosterPerf.default | 1087 | 1131 | 0.96:1 |
| AccordionMinimalPerf.default | 139 | 149 | 0.93:1 |
| ListWith60ListItems.default | 578 | 621 | 0.93:1 |
ling1726
approved these changes
May 17, 2022
ling1726
reviewed
May 17, 2022
Co-authored-by: ling1726 <lingfangao@hotmail.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ling1726
reviewed
May 18, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…ng. (microsoft#23021) * the outline and the filled part were both filled. Fixing. * editing the changelog * should not set the fill * the format looks right to me, but maybe the '.' is throwing checking off * Update packages/fluentui/CHANGELOG.md Co-authored-by: ling1726 <lingfangao@hotmail.com> * Update CHANGELOG.md * Update packages/fluentui/CHANGELOG.md * Update CHANGELOG.md * fix changelog Co-authored-by: Juraj Kapsiar <jurokapsiar@gmail.com> Co-authored-by: ling1726 <lingfangao@hotmail.com> Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
MicPulseOff path for outline and filled is the same
Fixes #
Fixes the MicPulseOff outline path per what is in the Figma file.