fix(eslint-plugin): move ban-context to react config from base #23240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 59ecd76:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 913 | 907 | 5000 | |
| Button | mount | 576 | 600 | 5000 | |
| FluentProvider | mount | 1919 | 2241 | 5000 | |
| FluentProviderWithTheme | mount | 268 | 277 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 247 | 226 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 305 | 290 | 10 | |
| MakeStyles | mount | 1658 | 1680 | 50000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 133 | 124 | 1.07:1 |
| FormMinimalPerf.default | 372 | 350 | 1.06:1 |
| ChatWithPopoverPerf.default | 311 | 297 | 1.05:1 |
| DividerMinimalPerf.default | 326 | 318 | 1.03:1 |
| ImageMinimalPerf.default | 338 | 328 | 1.03:1 |
| TreeMinimalPerf.default | 723 | 703 | 1.03:1 |
| AvatarMinimalPerf.default | 160 | 157 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1176 | 1153 | 1.02:1 |
| CarouselMinimalPerf.default | 365 | 359 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 235 | 230 | 1.02:1 |
| DropdownMinimalPerf.default | 2537 | 2497 | 1.02:1 |
| InputMinimalPerf.default | 1010 | 986 | 1.02:1 |
| LayoutMinimalPerf.default | 323 | 317 | 1.02:1 |
| PortalMinimalPerf.default | 145 | 142 | 1.02:1 |
| SegmentMinimalPerf.default | 312 | 307 | 1.02:1 |
| StatusMinimalPerf.default | 621 | 606 | 1.02:1 |
| IconMinimalPerf.default | 532 | 523 | 1.02:1 |
| TextAreaMinimalPerf.default | 427 | 418 | 1.02:1 |
| AnimationMinimalPerf.default | 495 | 489 | 1.01:1 |
| AttachmentSlotsPerf.default | 860 | 854 | 1.01:1 |
| ChatMinimalPerf.default | 655 | 650 | 1.01:1 |
| DatepickerMinimalPerf.default | 4808 | 4764 | 1.01:1 |
| DialogMinimalPerf.default | 697 | 688 | 1.01:1 |
| GridMinimalPerf.default | 303 | 300 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 1006 | 994 | 1.01:1 |
| LabelMinimalPerf.default | 349 | 346 | 1.01:1 |
| ListCommonPerf.default | 539 | 534 | 1.01:1 |
| LoaderMinimalPerf.default | 538 | 533 | 1.01:1 |
| RosterPerf.default | 873 | 866 | 1.01:1 |
| PopupMinimalPerf.default | 563 | 555 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1000 | 994 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3357 | 3314 | 1.01:1 |
| TableManyItemsPerf.default | 1640 | 1630 | 1.01:1 |
| CustomToolbarPrototype.default | 2209 | 2198 | 1.01:1 |
| ToolbarMinimalPerf.default | 845 | 834 | 1.01:1 |
| AlertMinimalPerf.default | 226 | 227 | 1:1 |
| CheckboxMinimalPerf.default | 1962 | 1962 | 1:1 |
| EmbedMinimalPerf.default | 2983 | 2991 | 1:1 |
| HeaderSlotsPerf.default | 681 | 680 | 1:1 |
| ListNestedPerf.default | 473 | 471 | 1:1 |
| MenuButtonMinimalPerf.default | 1369 | 1366 | 1:1 |
| RadioGroupMinimalPerf.default | 398 | 397 | 1:1 |
| ReactionMinimalPerf.default | 333 | 333 | 1:1 |
| SliderMinimalPerf.default | 1312 | 1317 | 1:1 |
| TreeWith60ListItems.default | 126 | 126 | 1:1 |
| ButtonMinimalPerf.default | 133 | 134 | 0.99:1 |
| CardMinimalPerf.default | 488 | 494 | 0.99:1 |
| ListMinimalPerf.default | 458 | 463 | 0.99:1 |
| MenuMinimalPerf.default | 748 | 752 | 0.99:1 |
| RefMinimalPerf.default | 206 | 208 | 0.99:1 |
| TableMinimalPerf.default | 359 | 363 | 0.99:1 |
| TooltipMinimalPerf.default | 968 | 982 | 0.99:1 |
| VideoMinimalPerf.default | 567 | 573 | 0.99:1 |
| BoxMinimalPerf.default | 293 | 298 | 0.98:1 |
| DropdownManyItemsPerf.default | 551 | 565 | 0.98:1 |
| FlexMinimalPerf.default | 242 | 247 | 0.98:1 |
| HeaderMinimalPerf.default | 313 | 321 | 0.98:1 |
| ListWith60ListItems.default | 472 | 484 | 0.98:1 |
| ProviderMinimalPerf.default | 312 | 318 | 0.98:1 |
| TextMinimalPerf.default | 302 | 309 | 0.98:1 |
| AccordionMinimalPerf.default | 127 | 131 | 0.97:1 |
| ButtonSlotsPerf.default | 416 | 433 | 0.96:1 |
| SkeletonMinimalPerf.default | 305 | 318 | 0.96:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| buttonNative | mount | 91 | 119 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 790 | 781 | 5000 | |
| Breadcrumb | mount | 2259 | 2260 | 1000 | |
| Checkbox | mount | 1275 | 1258 | 5000 | |
| CheckboxBase | mount | 1073 | 1083 | 5000 | |
| ChoiceGroup | mount | 3910 | 3921 | 5000 | |
| ComboBox | mount | 749 | 764 | 1000 | |
| CommandBar | mount | 8829 | 8883 | 1000 | |
| ContextualMenu | mount | 9198 | 9200 | 1000 | |
| DefaultButton | mount | 975 | 964 | 5000 | |
| DetailsRow | mount | 3055 | 3066 | 5000 | |
| DetailsRowFast | mount | 3082 | 3051 | 5000 | |
| DetailsRowNoStyles | mount | 2917 | 2894 | 5000 | |
| Dialog | mount | 1862 | 1888 | 1000 | |
| DocumentCardTitle | mount | 151 | 156 | 1000 | |
| Dropdown | mount | 2753 | 2787 | 5000 | |
| FocusTrapZone | mount | 1550 | 1517 | 5000 | |
| FocusZone | mount | 1530 | 1553 | 5000 | |
| IconButton | mount | 1393 | 1394 | 5000 | |
| Label | mount | 328 | 315 | 5000 | |
| Layer | mount | 2543 | 2567 | 5000 | |
| Link | mount | 423 | 432 | 5000 | |
| MenuButton | mount | 1222 | 1208 | 5000 | |
| MessageBar | mount | 1861 | 1802 | 5000 | |
| Nav | mount | 2643 | 2636 | 1000 | |
| OverflowSet | mount | 987 | 1000 | 5000 | |
| Panel | mount | 1826 | 1855 | 1000 | |
| Persona | mount | 858 | 864 | 1000 | |
| Pivot | mount | 1118 | 1113 | 1000 | |
| PrimaryButton | mount | 1090 | 1081 | 5000 | |
| Rating | mount | 6659 | 6612 | 5000 | |
| SearchBox | mount | 1121 | 1105 | 5000 | |
| Shimmer | mount | 2227 | 2222 | 5000 | |
| Slider | mount | 1704 | 1706 | 5000 | |
| SpinButton | mount | 3947 | 3952 | 5000 | |
| Spinner | mount | 401 | 393 | 5000 | |
| SplitButton | mount | 2463 | 2500 | 5000 | |
| Stack | mount | 480 | 489 | 5000 | |
| StackWithIntrinsicChildren | mount | 1860 | 1849 | 5000 | |
| StackWithTextChildren | mount | 4614 | 4634 | 5000 | |
| SwatchColorPicker | mount | 9028 | 9080 | 5000 | |
| TagPicker | mount | 1995 | 2039 | 5000 | |
| TeachingBubble | mount | 70442 | 70458 | 5000 | |
| Text | mount | 388 | 400 | 5000 | |
| TextField | mount | 1184 | 1165 | 5000 | |
| ThemeProvider | mount | 944 | 943 | 5000 | |
| ThemeProvider | virtual-rerender | 589 | 609 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1423 | 1410 | 5000 | |
| Toggle | mount | 702 | 703 | 5000 | |
| buttonNative | mount | 91 | 119 | 5000 | Possible regression |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8c00b612d84dbe0f27c5c5043a2d8752cf88e8ee (build) |
Hotell
commented
May 25, 2022
| identifierName = identifier.name; | ||
| const identifierName = identifier.name; | ||
|
|
||
| checkContextType(declaration, identifierName); |
There was a problem hiding this comment.
early exit to mitigate mutations and scope leaks
| @@ -38,8 +38,6 @@ ruleTester.run('ban-context-export', rule, { | |||
| filename: 'src/index.ts', | |||
| }, | |||
| { | |||
| // No way to type generics with jsdoc | |||
| // @ts-ignore | |||
| options: [{ exclude: ['**/special-path/**/*'] }], | |||
| fileNameCheck:(fileName:string)=>boolean; | ||
| }} options | ||
| */ | ||
| function reportViolation(options) { |
There was a problem hiding this comment.
moved logic to this generic function to check violations, as the code was quite similar
| /** | ||
| * | ||
| * @param {{ | ||
| typeProperty: Extract<keyof import('typescript').Type, 'symbol' | 'aliasSymbol'> |
There was a problem hiding this comment.
this enables better API contract with 3rd party types as if our defined literals wouldn't exist, we would get type error later on when used
| module.exports = createRule({ | ||
| name: 'ban-context-export', | ||
| defaultOptions: [], | ||
| defaultOptions: /** @type {ReadonlyArray<Options>} */ ([{}]), |
There was a problem hiding this comment.
with this createRule properly instantiates context generic, thus type intellisense works as expected (even in tests)
ling1726
reviewed
May 25, 2022
|
|
||
| /** | ||
| * | ||
| * @param {{ |
There was a problem hiding this comment.
I'd add some additional doc to this param to explain what the two different symbols are
There was a problem hiding this comment.
thanks for pushing this dude, thanks to this I finally understood the difference 🥇
docs added 59ecd76
ling1726
approved these changes
May 25, 2022
andrefcdias
approved these changes
May 25, 2022
…e some logic in ban-context
…apsulate some logic in ban-context
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…soft#23240) * fix(eslint-plugin): move ban-context to react config from base * refactor(eslint-plugin): improve type inference and encapsulate some logic in ban-context * generate change files * fixup! fix(eslint-plugin): move ban-context to react config from base * fixup! refactor(eslint-plugin): improve type inference and encapsulate some logic in ban-context * fixup! fixup! refactor(eslint-plugin): improve type inference and encapsulate some logic in ban-context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
ban-context-export is part of base, thus is applied on node.js apps which is out of scope
New Behavior
Related Issue(s)
Follows #23141