-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adding scheduler as a peer dependency of packages using @fluentui/react-context-selector #23681
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b1d9bc7:
|
📊 Bundle size reportUnchanged fixtures
|
@@ -28,22 +28,22 @@ | |||
"@fluentui/eslint-plugin": "*", | |||
"@fluentui/react-conformance": "*", | |||
"@fluentui/react-conformance-griffel": "9.0.0-beta.8", | |||
"@fluentui/react-context-selector": "9.0.0-rc.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is react-context-selector being removed fully here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh it was in devDeps and deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the dependency was, for whatever reason, added twice here, once in devDependencies
and once in dependencies
. I'm simply removing the one in devDependencies
to avoid unnecessary duplication.
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1656 | 1655 | 5000 | |
Button | mount | 1239 | 1259 | 5000 | |
FluentProvider | mount | 2256 | 2216 | 5000 | |
FluentProviderWithTheme | mount | 892 | 913 | 10 | |
FluentProviderWithTheme | virtual-rerender | 894 | 855 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 899 | 932 | 10 | |
MakeStyles | mount | 2420 | 2425 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 52f6f9da2687560b5f165309c6c54c63878379f8 (build) |
In this case, shouldn't |
…i/react-components.
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
DropdownManyItemsPerf.default | 804 | 749 | 1.07:1 |
AnimationMinimalPerf.default | 599 | 567 | 1.06:1 |
FlexMinimalPerf.default | 300 | 284 | 1.06:1 |
InputMinimalPerf.default | 1419 | 1342 | 1.06:1 |
HeaderMinimalPerf.default | 402 | 383 | 1.05:1 |
CarouselMinimalPerf.default | 519 | 498 | 1.04:1 |
ListMinimalPerf.default | 570 | 546 | 1.04:1 |
ListNestedPerf.default | 611 | 590 | 1.04:1 |
ProviderMinimalPerf.default | 410 | 393 | 1.04:1 |
RefMinimalPerf.default | 242 | 232 | 1.04:1 |
SegmentMinimalPerf.default | 374 | 360 | 1.04:1 |
SkeletonMinimalPerf.default | 373 | 359 | 1.04:1 |
TreeWith60ListItems.default | 181 | 174 | 1.04:1 |
ButtonMinimalPerf.default | 186 | 181 | 1.03:1 |
ItemLayoutMinimalPerf.default | 1318 | 1283 | 1.03:1 |
PortalMinimalPerf.default | 162 | 157 | 1.03:1 |
TreeMinimalPerf.default | 908 | 885 | 1.03:1 |
DropdownMinimalPerf.default | 3293 | 3227 | 1.02:1 |
LayoutMinimalPerf.default | 379 | 370 | 1.02:1 |
ReactionMinimalPerf.default | 409 | 400 | 1.02:1 |
SliderMinimalPerf.default | 1856 | 1822 | 1.02:1 |
TableManyItemsPerf.default | 2183 | 2146 | 1.02:1 |
TextMinimalPerf.default | 379 | 372 | 1.02:1 |
TextAreaMinimalPerf.default | 553 | 540 | 1.02:1 |
AttachmentSlotsPerf.default | 1199 | 1193 | 1.01:1 |
ButtonSlotsPerf.default | 582 | 578 | 1.01:1 |
ChatMinimalPerf.default | 802 | 796 | 1.01:1 |
CheckboxMinimalPerf.default | 2818 | 2792 | 1.01:1 |
DatepickerMinimalPerf.default | 6004 | 5965 | 1.01:1 |
HeaderSlotsPerf.default | 830 | 824 | 1.01:1 |
ListWith60ListItems.default | 685 | 679 | 1.01:1 |
RosterPerf.default | 1269 | 1262 | 1.01:1 |
PopupMinimalPerf.default | 652 | 643 | 1.01:1 |
RadioGroupMinimalPerf.default | 483 | 479 | 1.01:1 |
StatusMinimalPerf.default | 728 | 724 | 1.01:1 |
IconMinimalPerf.default | 674 | 668 | 1.01:1 |
CustomToolbarPrototype.default | 2940 | 2917 | 1.01:1 |
ToolbarMinimalPerf.default | 1064 | 1056 | 1.01:1 |
AlertMinimalPerf.default | 297 | 297 | 1:1 |
AvatarMinimalPerf.default | 204 | 204 | 1:1 |
ChatDuplicateMessagesPerf.default | 288 | 287 | 1:1 |
DialogMinimalPerf.default | 814 | 817 | 1:1 |
EmbedMinimalPerf.default | 4368 | 4370 | 1:1 |
LabelMinimalPerf.default | 399 | 399 | 1:1 |
MenuButtonMinimalPerf.default | 1833 | 1833 | 1:1 |
ProviderMergeThemesPerf.default | 1233 | 1235 | 1:1 |
SplitButtonMinimalPerf.default | 4735 | 4744 | 1:1 |
TooltipMinimalPerf.default | 1299 | 1296 | 1:1 |
VideoMinimalPerf.default | 718 | 719 | 1:1 |
AccordionMinimalPerf.default | 154 | 155 | 0.99:1 |
AttachmentMinimalPerf.default | 154 | 156 | 0.99:1 |
BoxMinimalPerf.default | 357 | 362 | 0.99:1 |
ButtonOverridesMissPerf.default | 1601 | 1613 | 0.99:1 |
MenuMinimalPerf.default | 891 | 896 | 0.99:1 |
FormMinimalPerf.default | 447 | 457 | 0.98:1 |
ImageMinimalPerf.default | 398 | 407 | 0.98:1 |
ListCommonPerf.default | 707 | 722 | 0.98:1 |
CardMinimalPerf.default | 600 | 619 | 0.97:1 |
ChatWithPopoverPerf.default | 409 | 420 | 0.97:1 |
LoaderMinimalPerf.default | 733 | 765 | 0.96:1 |
TableMinimalPerf.default | 417 | 433 | 0.96:1 |
DividerMinimalPerf.default | 362 | 384 | 0.94:1 |
GridMinimalPerf.default | 360 | 388 | 0.93:1 |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 1090 | 1103 | 5000 | |
Breadcrumb | mount | 2924 | 3155 | 1000 | |
Checkbox | mount | 1684 | 1612 | 5000 | |
CheckboxBase | mount | 1497 | 1488 | 5000 | |
ChoiceGroup | mount | 5401 | 5465 | 5000 | |
ComboBox | mount | 1079 | 1104 | 1000 | |
CommandBar | mount | 11997 | 12083 | 1000 | |
ContextualMenu | mount | 11939 | 12340 | 1000 | |
DefaultButton | mount | 1314 | 1289 | 5000 | |
DetailsRow | mount | 4136 | 4259 | 5000 | |
DetailsRowFast | mount | 4286 | 4218 | 5000 | |
DetailsRowNoStyles | mount | 3871 | 3804 | 5000 | |
Dialog | mount | 3145 | 3099 | 1000 | |
DocumentCardTitle | mount | 203 | 202 | 1000 | |
Dropdown | mount | 3830 | 3800 | 5000 | |
FocusTrapZone | mount | 2074 | 2129 | 5000 | |
FocusZone | mount | 1994 | 1942 | 5000 | |
IconButton | mount | 1991 | 2017 | 5000 | |
Label | mount | 373 | 392 | 5000 | |
Layer | mount | 3351 | 3318 | 5000 | |
Link | mount | 524 | 532 | 5000 | |
MenuButton | mount | 1727 | 1706 | 5000 | |
MessageBar | mount | 2258 | 2376 | 5000 | |
Nav | mount | 3777 | 3637 | 1000 | |
OverflowSet | mount | 1209 | 1217 | 5000 | |
Panel | mount | 2397 | 2395 | 1000 | |
Persona | mount | 1170 | 1175 | 1000 | |
Pivot | mount | 1546 | 1635 | 1000 | |
PrimaryButton | mount | 1454 | 1489 | 5000 | |
Rating | mount | 9017 | 8926 | 5000 | |
SearchBox | mount | 1568 | 1540 | 5000 | |
Shimmer | mount | 2735 | 2852 | 5000 | |
Slider | mount | 2056 | 2044 | 5000 | |
SpinButton | mount | 5694 | 5569 | 5000 | |
Spinner | mount | 502 | 475 | 5000 | |
SplitButton | mount | 3632 | 3581 | 5000 | |
Stack | mount | 618 | 630 | 5000 | |
StackWithIntrinsicChildren | mount | 2754 | 2743 | 5000 | |
StackWithTextChildren | mount | 6118 | 6210 | 5000 | |
SwatchColorPicker | mount | 13309 | 12933 | 5000 | |
TagPicker | mount | 2949 | 3091 | 5000 | |
TeachingBubble | mount | 111130 | 100158 | 5000 | |
Text | mount | 501 | 534 | 5000 | |
TextField | mount | 1604 | 1679 | 5000 | |
ThemeProvider | mount | 1335 | 1362 | 5000 | |
ThemeProvider | virtual-rerender | 720 | 719 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 2060 | 2133 | 5000 | |
Toggle | mount | 911 | 877 | 5000 | |
buttonNative | mount | 140 | 142 | 5000 |
…tui/react-context-selector (microsoft#23681) * Adding scheduler as a peer dependency of packages using @fluentui/react-context-selector. * Removing new line. * Adding change files. * Adding change file.
PR Description
#21769 moved the
scheduler
dependency in@fluentui/react-context-selector
to be a peer dependency instead. However, packages using@fluentui/react-context-selector
did not have this dependency added to them, which causes problems in some build systems using these packages as it is marked as a missing dependency, even if explicitly added there.This PR fixes the issue by adding
scheduler
as a peer dependency of those packages that use@fluentui/react-context-selector
. It also orders some of the dependencies in those packages alphabetically.Related Issue(s)
Fixes #23639