-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox: update stories to import from @fluentui/react-components #23857
Merged
TristanWatanabe
merged 2 commits into
microsoft:master
from
TristanWatanabe:checkbox-import-from-v9-suite
Jul 11, 2022
Merged
Checkbox: update stories to import from @fluentui/react-components #23857
TristanWatanabe
merged 2 commits into
microsoft:master
from
TristanWatanabe:checkbox-import-from-v9-suite
Jul 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
khmakoto
approved these changes
Jul 11, 2022
packages/react-components/react-checkbox/src/stories/Checkbox/index.stories.tsx
Outdated
Show resolved
Hide resolved
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f9363b7:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: aa20bde638dc27d24dbc221a6d4bfe3487a78bbb (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
SpinButton | mount | 2592 | 5719 | 5000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1330 | 1327 | 5000 | |
Button | mount | 912 | 910 | 5000 | |
FluentProvider | mount | 1766 | 1777 | 5000 | |
FluentProviderWithTheme | mount | 614 | 605 | 10 | |
FluentProviderWithTheme | virtual-rerender | 577 | 573 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 639 | 639 | 10 | |
MakeStyles | mount | 1914 | 1927 | 50000 | |
SpinButton | mount | 2592 | 5719 | 5000 | Possible regression |
…index.stories.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
react-checkbox
stories to import from@fluentui/react-components
package suite to demonstrate best practices to users.no-restricted-imports
rule.Part of #23846