Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: update stories to import from @fluentui/react-components #23857

Merged

Conversation

TristanWatanabe
Copy link
Member

Changes

  • updates react-checkbox stories to import from @fluentui/react-components package suite to demonstrate best practices to users.
  • Fixes automatically applied by new no-restricted-imports rule.

Part of #23846

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f9363b7:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 11, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.182 kB
52.141 kB
react-components
react-components: FluentProvider & webLightTheme
31.883 kB
10.516 kB
🤖 This report was generated against 3fcf4d272bb7b723396cec3824a7aeb029a71566

@size-auditor
Copy link

size-auditor bot commented Jul 11, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: aa20bde638dc27d24dbc221a6d4bfe3487a78bbb (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 11, 2022

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
SpinButton mount 2592 5719 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1330 1327 5000
Button mount 912 910 5000
FluentProvider mount 1766 1777 5000
FluentProviderWithTheme mount 614 605 10
FluentProviderWithTheme virtual-rerender 577 573 10
FluentProviderWithTheme virtual-rerender-with-unmount 639 639 10
MakeStyles mount 1914 1927 50000
SpinButton mount 2592 5719 5000 Possible regression

…index.stories.tsx

Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
@TristanWatanabe TristanWatanabe merged commit 99c24b6 into microsoft:master Jul 11, 2022
@TristanWatanabe TristanWatanabe deleted the checkbox-import-from-v9-suite branch July 11, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants