Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinbutton: update stories to import from @fluentui/react-components #23971

Merged

Conversation

TristanWatanabe
Copy link
Member

Changes

  • updates react-spinbutton stories to import from @fluentui/react-components package suite to demonstrate best practices to users.
  • Fixes automatically applied by new no-restricted-imports rule.

Part of #23846

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 18, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dafd1d7:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.057 kB
52.092 kB
react-components
react-components: FluentProvider & webLightTheme
31.883 kB
10.516 kB
react-spinbutton
SpinButton
43.53 kB
12.346 kB
🤖 This report was generated against f190faf095bf2788f859c09bfd5e85a4bd4892eb

@size-auditor
Copy link

size-auditor bot commented Jul 18, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a8ae8890789dd392d2e0e06e0db394aa4d676e38 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1284 1244 5000
Button mount 881 868 5000
FluentProvider mount 1602 1618 5000
FluentProviderWithTheme mount 562 556 10
FluentProviderWithTheme virtual-rerender 531 518 10
FluentProviderWithTheme virtual-rerender-with-unmount 568 571 10
MakeStyles mount 1949 1949 50000
SpinButton mount 2394 2412 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review July 18, 2022 21:02
@TristanWatanabe TristanWatanabe requested review from a team and spmonahan as code owners July 18, 2022 21:02
@TristanWatanabe TristanWatanabe merged commit 2702a94 into microsoft:master Jul 20, 2022
@TristanWatanabe TristanWatanabe deleted the spinbutton-import-from-v9 branch July 20, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants