Spec: Table/DataGrid component #23984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the spec for the table component. This spec is not meant to be exhaustive and will be updated as new features are planned and delvered (e.g selectable rows). Addresses: microsoft#23983
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ce6f970:
|
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3b37078d657a664f7a55ffff35cdf698d16de144 (build) |
spmonahan
reviewed
Jul 19, 2022
bsunderhus
reviewed
Jul 21, 2022
|
Regarding naming I'm in favor of |
bsunderhus
approved these changes
Jul 27, 2022
marcosmoura
approved these changes
Aug 4, 2022
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1300 | 1279 | 5000 | |
| Button | mount | 919 | 911 | 5000 | |
| Field | mount | 1932 | 1953 | 5000 | |
| FluentProvider | mount | 1535 | 1522 | 5000 | |
| FluentProviderWithTheme | mount | 573 | 579 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 549 | 550 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 579 | 586 | 10 | |
| InfoButton | mount | 515 | 520 | 5000 | |
| MakeStyles | mount | 1959 | 1954 | 50000 | |
| Persona | mount | 2847 | 2841 | 5000 | |
| SpinButton | mount | 2288 | 2305 | 5000 |
|
Because this pull request has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. The pull request will still be available for reference. If it's still relevant to merge at some point, you can reopen or make a new version based on the latest code. |
msft-fluent-ui-bot
added
the
Resolution: Soft Close
github-actions
bot
modified the milestones:
July Project Cycle Q3 2022,
October Project Cycle Q4 2022
🕵 fluentuiv9 No visual regressions between this PR and main |
github-actions
bot
modified the milestones:
October Project Cycle Q4 2022,
March Project Cycle Q1 2023
… into spec/react-table
GeoffCoxMSFT
pushed a commit
to GeoffCoxMSFT/fluentui
that referenced
this pull request
Mar 1, 2023
* Fix: Dependency mismatch after v9 release * Spec: Table component Adds the spec for the table component. This spec is not meant to be exhaustive and will be updated as new features are planned and delvered (e.g selectable rows). Addresses: microsoft#23983 * update spec * fix missing sortable example * update medium sie * Add media slot to table cell * update table sorting props * Update Spec.md * Update Spec.md * update spec to current stable form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the spec for the table component. This spec is not meant to be
exhaustive and will be updated as new features are planned and delvered
(e.g selectable rows).
PREVIEW
Fixes #23983