Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-avatar): Rename AvatarGroupOverflow to AvatarGroupPopover #24338

Merged

Conversation

sopranopillow
Copy link
Contributor

This PR renames AvatarGroupOverflow to AvatarGroupPopover.

Fixes #24216

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ba25802:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-alert
Alert
82.771 kB
20.584 kB
react-avatar
Avatar
48.18 kB
13.616 kB
react-avatar
AvatarGroup
15.068 kB
6.016 kB
react-avatar
AvatarGroupItem
68.333 kB
19.018 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.673 kB
51.804 kB
react-components
react-components: FluentProvider & webLightTheme
32.786 kB
10.759 kB
🤖 This report was generated against 27a3480f5361aa5d99f8978817d8395d9037e3b7

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1261 1255 5000
Button mount 957 955 5000
FluentProvider mount 1587 1554 5000
FluentProviderWithTheme mount 623 625 10
FluentProviderWithTheme virtual-rerender 594 593 10
FluentProviderWithTheme virtual-rerender-with-unmount 628 629 10
MakeStyles mount 1931 1920 50000
SpinButton mount 2510 2435 5000

@size-auditor
Copy link

size-auditor bot commented Aug 10, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 27a3480f5361aa5d99f8978817d8395d9037e3b7 (build)

@sopranopillow sopranopillow merged commit 84e2b1a into microsoft:master Aug 11, 2022
@sopranopillow sopranopillow deleted the avatargroupoverflow-rename branch August 11, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AvatarGroup: Rename AvatarGroupOverflow to AvatarGroupPopover to avoid confusion with react-overflow
3 participants