-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added font-icons-mdl2 package to 7.0 #24568
Added font-icons-mdl2 package to 7.0 #24568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this change to the 7.0
branch may not have been submitted to master
yet. Now that version 8 has released, all changes must be submitted to the master
branch first (except in emergencies or if the change is irrelevant to version 8).
Please do one of the following:
- If you've already created a PR to
master
, add a link to it - If the change is irrelevant to version 8, add a comment explaining why
- Otherwise, create a PR to
master
with this same change, and add a link to it
After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).
Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master
PR number).
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2be5152:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 99712be9853486e276e8b4994050e4b32d07af3b (build) |
Perf AnalysisNo significant results to display. All results
|
@@ -0,0 +1,383 @@ | |||
# Change Log - @uifabric/icons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Change Log - @uifabric/icons | |
# Change Log - @fluentui/font-icons-mdl2 |
This allows callers migrating from v7 to v8 to to using the @fluentui/ namespace and the same package name as v8 while remaining on v7. This provides a path for incremental upgrade.
Issues
Updates #24393