Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added font-icons-mdl2 package to 7.0 #24568

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

GeoffCoxMSFT
Copy link
Member

@GeoffCoxMSFT GeoffCoxMSFT commented Aug 29, 2022

This allows callers migrating from v7 to v8 to to using the @fluentui/ namespace and the same package name as v8 while remaining on v7. This provides a path for incremental upgrade.

Issues

Updates #24393

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Aug 29, 2022
@msft-fluent-ui-bot msft-fluent-ui-bot added Fabric 7 needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master labels Aug 29, 2022
Copy link
Collaborator

@msft-fluent-ui-bot msft-fluent-ui-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).

Please do one of the following:

  • If you've already created a PR to master, add a link to it
  • If the change is irrelevant to version 8, add a comment explaining why
  • Otherwise, create a PR to master with this same change, and add a link to it

After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).

Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).

@GeoffCoxMSFT GeoffCoxMSFT changed the title Added font-icons-mdl2 package to @fluentui/react 7.0 Added font-icons-mdl2 package to 7.0 Aug 29, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 29, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2be5152:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 29, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 99712be9853486e276e8b4994050e4b32d07af3b (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 29, 2022

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 759 752 5000
Breadcrumb mount 36187 36251 5000
Checkbox mount 1305 1321 5000
CheckboxBase mount 1078 1083 5000
ChoiceGroup mount 4152 4146 5000
ComboBox mount 756 762 1000
CommandBar mount 6663 6785 1000
ContextualMenu mount 13036 12330 1000
DefaultButton mount 941 957 5000
DetailsRow mount 3249 3198 5000
DetailsRowFast mount 3189 3202 5000
DetailsRowNoStyles mount 3014 3026 5000
Dialog mount 1915 1917 1000
DocumentCardTitle mount 1559 1568 1000
Dropdown mount 2119 2131 5000
FocusTrapZone mount 1490 1474 5000
FocusZone mount 1546 1526 5000
IconButton mount 1483 1481 5000
Label mount 276 279 5000
Layer mount 1651 1671 5000
Link mount 369 377 5000
MenuButton mount 1216 1238 5000
MessageBar mount 1730 1784 5000
Nav mount 2834 2808 1000
OverflowSet mount 1202 1208 5000
Panel mount 1222 1250 1000
Persona mount 804 805 1000
Pivot mount 1243 1272 1000
PrimaryButton mount 1075 1075 5000
Rating mount 6605 6697 5000
SearchBox mount 1065 1057 5000
Shimmer mount 2165 2159 5000
Slider mount 1300 1272 5000
SpinButton mount 4267 4233 5000
Spinner mount 355 357 5000
SplitButton mount 2677 2712 5000
Stack mount 414 410 5000
StackWithIntrinsicChildren mount 1437 1463 5000
StackWithTextChildren mount 4065 4083 5000
SwatchColorPicker mount 9080 9070 5000
TagPicker mount 2477 2462 5000
TeachingBubble mount 43253 43432 5000
Text mount 365 359 5000
TextField mount 1172 1183 5000
Toggle mount 703 702 5000
button mount 90 86 5000

@GeoffCoxMSFT GeoffCoxMSFT removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Aug 29, 2022
@GeoffCoxMSFT GeoffCoxMSFT requested a review from a team as a code owner August 29, 2022 18:21
@@ -0,0 +1,383 @@
# Change Log - @uifabric/icons
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Change Log - @uifabric/icons
# Change Log - @fluentui/font-icons-mdl2

@GeoffCoxMSFT GeoffCoxMSFT merged commit fb7ce1b into microsoft:7.0 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants