Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): Add InfoButton to unstable exports #25686

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

sopranopillow
Copy link
Contributor

This PR adds the following:

  • Add InfoButton to unstable.
  • Change react-infobutton to public.
  • Update documentation to being unstable.

@size-auditor
Copy link

size-auditor bot commented Nov 15, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9cd5e0afbd6505e57f4d3fa70c59190c0608cbb7 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb5e095:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1566 1533 5000
Button mount 1097 1129 5000
FluentProvider mount 1893 1851 5000
FluentProviderWithTheme mount 741 740 10
FluentProviderWithTheme virtual-rerender 730 699 10
FluentProviderWithTheme virtual-rerender-with-unmount 747 773 10
MakeStyles mount 2278 2245 50000
SpinButton mount 3017 2961 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.951 kB
17.675 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
190.427 kB
53.087 kB
react-components
react-components: FluentProvider & webLightTheme
33.456 kB
11.029 kB
react-infobutton
InfoButton
117.938 kB
35.399 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 00815ce18bbe098b1c9cd61c7f2fd04b87d1ae0d

@sopranopillow sopranopillow merged commit e22929a into microsoft:master Nov 16, 2022
@sopranopillow sopranopillow deleted the infobutton/unstable branch November 16, 2022 17:41
@sopranopillow sopranopillow mentioned this pull request Nov 16, 2022
30 tasks
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
…#25686)

* moving infobutton to unstable

* change files

* updating description
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
…#25686)

* moving infobutton to unstable

* change files

* updating description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants