Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE TESTING] Testing running VR Tool with northstar #25845

Closed
wants to merge 72 commits into from

Conversation

TristanWatanabe
Copy link
Member

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@DustyTheBot
Copy link

DustyTheBot commented Nov 30, 2022

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 008c836

@size-auditor
Copy link

size-auditor bot commented Nov 30, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0e6c43dfe0b2f3568d6a9b574cd073cdc9f71608 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 30, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1283 1302 5000
Button mount 921 922 5000
FluentProvider mount 1502 1481 5000
FluentProviderWithTheme mount 584 578 10
FluentProviderWithTheme virtual-rerender 538 537 10
FluentProviderWithTheme virtual-rerender-with-unmount 575 577 10
MakeStyles mount 1967 1949 50000
SpinButton mount 2362 2357 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 30, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 008c836:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 30, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
3.153 kB
1.299 kB
react-accordion
Accordion (including children components)
79.294 kB
24.443 kB
react-alert
Alert
82.967 kB
21.022 kB
react-avatar
Avatar
51.076 kB
14.285 kB
react-avatar
AvatarGroup
15.006 kB
6.009 kB
react-avatar
AvatarGroupItem
67.306 kB
18.581 kB
react-badge
Badge
23.357 kB
7.361 kB
react-badge
CounterBadge
24.247 kB
7.643 kB
react-badge
PresenceBadge
24.001 kB
7.049 kB
react-button
Button
32.923 kB
8.61 kB
react-button
CompoundButton
39.953 kB
9.933 kB
react-button
MenuButton
37.611 kB
9.942 kB
react-button
SplitButton
45.057 kB
11.323 kB
react-button
ToggleButton
48.753 kB
10.715 kB
react-card
Card - All
71.873 kB
20.936 kB
react-card
Card
67.651 kB
19.892 kB
react-card
CardFooter
8.617 kB
3.62 kB
react-card
CardHeader
9.792 kB
3.995 kB
react-card
CardPreview
8.718 kB
3.674 kB
react-combobox
Combobox (including child components)
78.244 kB
25.015 kB
react-combobox
Dropdown (including child components)
77.531 kB
24.927 kB
react-components
react-components: Button, FluentProvider & webLightTheme
59.018 kB
16.371 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
186.456 kB
52.327 kB
react-components
react-components: FluentProvider & webLightTheme
33.48 kB
11.037 kB
react-dialog
Dialog (including children components)
83.036 kB
24.754 kB
react-divider
Divider
16.515 kB
5.921 kB
react-image
Image
10.836 kB
4.283 kB
react-infobutton
InfoButton
117.922 kB
35.391 kB
react-input
Input
24.194 kB
7.89 kB
react-label
Label
9.394 kB
3.88 kB
react-link
Link
11.862 kB
4.885 kB
react-menu
Menu (including children components)
117.61 kB
36.287 kB
react-menu
Menu (including selectable components)
120.679 kB
36.82 kB
react-overflow
hooks only
11.004 kB
4.188 kB
react-persona
Persona
57.131 kB
15.951 kB
react-popover
Popover
103.666 kB
31.858 kB
react-portal
Portal
10.495 kB
3.851 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-positioning
usePositioning
19.826 kB
7.417 kB
react-progress
Progress
13.536 kB
5.107 kB
react-provider
FluentProvider
15.817 kB
5.905 kB
react-radio
Radio
36.42 kB
12.126 kB
react-radio
RadioGroup
14.304 kB
5.72 kB
react-select
Select
23.474 kB
8.017 kB
react-slider
Slider
32.091 kB
10.183 kB
react-spinbutton
SpinButton
44.502 kB
12.812 kB
react-spinner
Spinner
20.013 kB
6.446 kB
react-switch
Switch
33.427 kB
10.581 kB
react-text
Text - Default
11.838 kB
4.625 kB
react-text
Text - Wrappers
15.148 kB
5.06 kB
react-textarea
Textarea
25.733 kB
8.328 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.722 kB
6.462 kB
react-theme
Teams: Light theme
17.51 kB
5.075 kB
react-tooltip
Tooltip
42.032 kB
14.739 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 0e6c43dfe0b2f3568d6a9b574cd073cdc9f71608

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 30, 2022

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 5 screenshots

✅ There was 2 screenshots added, 0 screenshots removed, 1034 screenshots unchanged, 0 screenshots with different dimensions and 3 screenshots with visible difference.

unknown 5 screenshots
Image Name Diff(in Pixels) Image Type
TagPicker.Root.chromium.png 145 Changed
TagPicker.Selected - RTL.chromium.png 145 Changed
TagPicker.Selected.chromium.png 145 Changed
Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png 0 Added
Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png 0 Added

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 30, 2022

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 30, 2022

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
GroupedList mount 2264 2555 2 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1398 1392 5000
Breadcrumb mount 3474 3561 1000
Checkbox mount 3147 3138 5000
CheckboxBase mount 2766 2775 5000
ChoiceGroup mount 5189 5313 5000
ComboBox mount 1529 1503 1000
CommandBar mount 11435 11334 1000
ContextualMenu mount 12872 12992 1000
DefaultButton mount 1659 1631 5000
DetailsRow mount 4331 4251 5000
DetailsRowFast mount 4236 4474 5000
DetailsRowNoStyles mount 4195 4237 5000
Dialog mount 3716 3669 1000
DocumentCardTitle mount 680 710 1000
Dropdown mount 3874 3895 5000
FocusTrapZone mount 2368 2440 5000
FocusZone mount 2316 2286 5000
GroupedList mount 2264 2555 2 Possible regression
GroupedList virtual-rerender 1345 1386 2
GroupedList virtual-rerender-with-unmount 1988 2003 2
GroupedListV2 mount 677 694 2
GroupedListV2 virtual-rerender 646 658 2
GroupedListV2 virtual-rerender-with-unmount 674 690 2
IconButton mount 2298 2333 5000
Label mount 902 875 5000
Layer mount 5043 5233 5000
Link mount 981 1002 5000
MenuButton mount 2017 1994 5000
MessageBar mount 2712 2712 5000
Nav mount 3904 3912 1000
OverflowSet mount 1588 1605 5000
Panel mount 2968 3050 1000
Persona mount 1520 1560 1000
Pivot mount 1917 1942 1000
PrimaryButton mount 1776 1872 5000
Rating mount 8361 8230 5000
SearchBox mount 1842 1780 5000
Shimmer mount 3463 3317 5000
Slider mount 2482 2492 5000
SpinButton mount 5544 5507 5000
Spinner mount 953 959 5000
SplitButton mount 3628 3662 5000
Stack mount 998 1025 5000
StackWithIntrinsicChildren mount 2958 2958 5000
StackWithTextChildren mount 5742 5867 5000
SwatchColorPicker mount 12495 12451 5000
TagPicker mount 3159 3127 5000
TeachingBubble mount 102537 100907 5000
Text mount 950 965 5000
TextField mount 1959 1939 5000
ThemeProvider mount 1865 1841 5000
ThemeProvider virtual-rerender 1310 1360 5000
ThemeProvider virtual-rerender-with-unmount 2603 2617 5000
Toggle mount 1323 1381 5000
buttonNative mount 650 678 5000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants