-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup typescript 4.7 for web-components package #26299
Merged
tudorpopams
merged 4 commits into
microsoft:web-components-v3
from
Hotell:hotell/wc/setup-ts-4-7-pure
Jan 11, 2023
Merged
chore: setup typescript 4.7 for web-components package #26299
tudorpopams
merged 4 commits into
microsoft:web-components-v3
from
Hotell:hotell/wc/setup-ts-4-7-pure
Jan 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b47d50
to
2078ba3
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5e81ad39a172f413a4f5f6e852252ac07639d376 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fae13b7:
|
📊 Bundle size reportUnchanged fixtures
|
2078ba3
to
3923573
Compare
Tested the local branch in #26298 and it works! |
chrisdholt
approved these changes
Jan 11, 2023
tudorpopams
approved these changes
Jan 11, 2023
Hotell
added a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
Hotell
added a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
Hotell
added a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* chore: setup typescript 4.7 for web-components package * chore: generate change-file * fixup! chore: setup typescript 4.7 for web-components package * fixup! fixup! chore: setup typescript 4.7 for web-components package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
TS 4.3 is used within whole repo
New Behavior
Web-components now use TS 4.7 with properly configured tooling.
How was this achieved:
typescript 4.7 tooling support
ts-loader
-> only thing needed was to explicitly provide path to non hoisted compilerrollup
+ loaders -> only thing needed was to explicitly provide path to non hoisted compilerapi-extractor
doesn't support custom compiler versions thus a duplicate needed to be installed that ships with same TS version as will be used for web-components. This is known limitation of api-extractor and it wont change anytime soon AFAIK.nohoist
was usednative ESM support
storybook
- some additional tweaks are necessary as storybook doesn't ship valid ESM packages thus webpack needs to be configured to not error on those violations that happen within./.storybook
folder.karma
- configs and setup that uses CJS needs to be renamed to use.cjs
/.cts
extensioneslint
- moved config tojson
file which is more easier to automate and adhere to any ESM standards 👍Related Issue(s)