Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): check changes folder exists #26941

Merged

Conversation

miroslavstastny
Copy link
Member

Previous Behavior

CI for web-components-v3 PR fails if there is no changes folder:
image

New Behavior

check-wc-3-changefiles checks the folder exists first

@miroslavstastny miroslavstastny requested a review from a team as a code owner February 22, 2023 10:35
@miroslavstastny miroslavstastny changed the title Fix/changes check fix(ci): check changes folder exists Feb 22, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Feb 22, 2023

📊 Bundle size report

🤖 This report was generated against 7a94f57b316b59a463b5971293e6a77b8a9dcd45

@size-auditor
Copy link

size-auditor bot commented Feb 22, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7a94f57b316b59a463b5971293e6a77b8a9dcd45 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cae8c2c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@miroslavstastny
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@miroslavstastny miroslavstastny merged commit 8f61d3d into microsoft:web-components-v3 Feb 22, 2023
@miroslavstastny miroslavstastny deleted the fix/changes-check branch February 22, 2023 11:08
chrisdholt pushed a commit that referenced this pull request Apr 29, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 30, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit that referenced this pull request Apr 30, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit that referenced this pull request May 2, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit that referenced this pull request May 2, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit that referenced this pull request May 2, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit that referenced this pull request May 3, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit that referenced this pull request May 6, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit that referenced this pull request May 6, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit that referenced this pull request May 8, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
radium-v pushed a commit that referenced this pull request May 10, 2024
* fix(ci): skip changes files check if the changes folder does not exist

* test for empty changes folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants