Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding calls to custom style hooks derived from context in react-textarea components #27079

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

GeoffCoxMSFT
Copy link
Member

Changes

  • Updated components to call custom style hook

Issues

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Mar 4, 2023
@GeoffCoxMSFT GeoffCoxMSFT requested review from a team and sopranopillow as code owners March 4, 2023 18:25
@github-actions github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 4, 2023
@size-auditor
Copy link

size-auditor bot commented Mar 4, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 606845129c288af984f0f43dc44c54f9093c39eb (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 4, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-textarea
Textarea
26.336 kB
8.585 kB
29.011 kB
9.076 kB
2.675 kB
491 B
react-textarea
TextareaField
36.537 kB
11.504 kB
39.295 kB
12.002 kB
2.758 kB
498 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
67.061 kB
18.105 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
206.05 kB
57.069 kB
react-components
react-components: FluentProvider & webLightTheme
37.891 kB
12.039 kB
react-portal-compat
PortalCompatProvider
6.324 kB
2.129 kB
🤖 This report was generated against 606845129c288af984f0f43dc44c54f9093c39eb

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de10576:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 4, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1289 1296 5000
Button mount 930 939 5000
Field mount 1953 1954 5000
FluentProvider mount 1541 1541 5000
FluentProviderWithTheme mount 582 589 10
FluentProviderWithTheme virtual-rerender 545 546 10
FluentProviderWithTheme virtual-rerender-with-unmount 583 590 10
InfoButton mount 515 537 5000
MakeStyles mount 1956 1958 50000
Persona mount 2860 2799 5000
SpinButton mount 2300 2299 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 4, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@GeoffCoxMSFT GeoffCoxMSFT enabled auto-merge (squash) March 5, 2023 21:11
@khmakoto khmakoto changed the title Custom style react-textarea feat: Adding calls to custom style hooks derived from context in react-textarea components Mar 6, 2023
GeoffCoxMSFT and others added 2 commits March 7, 2023 11:18
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
@GeoffCoxMSFT GeoffCoxMSFT merged commit 489dfcb into microsoft:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants