-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Spinner and ProgressBar vr-tests to use PauseAnimation #27156
chore: update Spinner and ProgressBar vr-tests to use PauseAnimation #27156
Conversation
📊 Bundle size report🤖 This report was generated against 8a242b14151adf4186df88f0fb234508db47ec06 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8a242b14151adf4186df88f0fb234508db47ec06 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d89cb6a:
|
…c-react into animation-vr-tests-fix
…/fluentui into animation-vr-tests-fix
apps/vr-tests-react-components/src/utilities/TestWrapperDecorator.tsx
Outdated
Show resolved
Hide resolved
apps/vr-tests-react-components/src/utilities/TestWrapperDecorator.tsx
Outdated
Show resolved
Hide resolved
apps/vr-tests-react-components/src/stories/ProgressBar.stories.tsx
Outdated
Show resolved
Hide resolved
apps/vr-tests-react-components/src/utilities/TestWrapperDecorator.tsx
Outdated
Show resolved
Hide resolved
apps/vr-tests-react-components/src/stories/ProgressBar.stories.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
…tor.tsx Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com>
…nimation-vr-tests-fix
…/fluentui into animation-vr-tests-fix
…/fluentui into animation-vr-tests-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, once those are addressed, I think we're good to go.
apps/vr-tests-react-components/src/utilities/TestWrapperDecorator.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com>
Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com>
Noticed you didn't add the styles like tooltip. Any reason why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments about removing redundant tests, especially in Spinner.
apps/vr-tests-react-components/src/stories/ProgressBar.stories.tsx
Outdated
Show resolved
Hide resolved
apps/vr-tests-react-components/src/stories/Skeleton.stories.tsx
Outdated
Show resolved
Hide resolved
apps/vr-tests-react-components/src/utilities/TestWrapperDecorator.tsx
Outdated
Show resolved
Hide resolved
apps/vr-tests-react-components/src/stories/Skeleton.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
This PR is to update the vr-tests for
ProgressBar
andSpinner
to use the proper test decorator, which pauses the animations rather than stopping them entirely.