Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Spinner and ProgressBar vr-tests to use PauseAnimation #27156

Merged
merged 35 commits into from
Jul 19, 2023

Conversation

tomi-msft
Copy link
Contributor

@tomi-msft tomi-msft commented Mar 10, 2023

This PR is to update the vr-tests for ProgressBar and Spinner to use the proper test decorator, which pauses the animations rather than stopping them entirely.

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 10, 2023

📊 Bundle size report

🤖 This report was generated against 8a242b14151adf4186df88f0fb234508db47ec06

@size-auditor
Copy link

size-auditor bot commented Mar 10, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8a242b14151adf4186df88f0fb234508db47ec06 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d89cb6a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

tomi-msft and others added 4 commits May 3, 2023 16:03
….tsx

Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
…tor.tsx

Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com>
Copy link
Contributor

@sopranopillow sopranopillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, once those are addressed, I think we're good to go.

tomi-msft and others added 3 commits July 13, 2023 17:30
Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com>
Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com>
sopranopillow
sopranopillow previously approved these changes Jul 18, 2023
@sopranopillow sopranopillow dismissed their stale review July 18, 2023 20:33

Noticed you didn't add the styles like tooltip. Any reason why?

Copy link
Contributor

@behowell behowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments about removing redundant tests, especially in Spinner.

@tomi-msft tomi-msft merged commit 32c3068 into microsoft:master Jul 19, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spinner and ProgressBar use wrong vr-test decorator
6 participants